From patchwork Sat Oct 29 17:23:35 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 12762 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1439981wru; Sat, 29 Oct 2022 10:27:02 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4J2hiatrIjw88hlvQ8Kx73bUn9ocx56nPmkB+rzvxFtIowzEzRlCDrEbZaktdSrrb0cAHg X-Received: by 2002:a05:6a00:8cb:b0:52c:6962:2782 with SMTP id s11-20020a056a0008cb00b0052c69622782mr5252066pfu.81.1667064421986; Sat, 29 Oct 2022 10:27:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667064421; cv=none; d=google.com; s=arc-20160816; b=y8XLzRct3Rwx4/Z0RhEOgLX7PeWd5iirbTFXkx5q4ynM6Xg2b1sG/OBlz11+3Pjyr+ wlA+IGEEFGIMDenUiE3R6lT9pH/OJciZTR4Iyn0uBDLxQCTcGIoF8CswPS0Gr6gz8OTU wKOSj4UA+YYmJKj852/+dgF/oRcvQFoVn7zJZ+/7HfrVR5zYFTBJxzwUZnCSax2G1TSK +Ht17Fykd1Z4wYrp+TAgCYM84jThVif6SDOCB6crnHJg631kEql6njFVMGiNPtFVTjQg XF/AAnOhCec5ORkRde+6q+/cMS4Sfv/Jo3CIJCW7SxCzRrMxHgm0gqdQrDEF8sp/4cop gm8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=yBnzgeOVv70gnxTpcK6WQn8BCY9lk3Ouvi6oxwV0GhY=; b=SStuuQEdDDHgAhZjRbVXbYiBpDtirmWDE3hs/gghwEnxXPJ7+ap6qtH528WaIB000N 4doTpm7jaD69bDw95oelEoUePp+OcvHMgl7HBf5Ivpx0moWW/+uM05eTRfhTPd/rbb2m kpBglOy/hg7huGhy3jQkbv/43h7h9Kbs3Gk380LaCNp3BhIKRRahrhFPWAfWxbmY0Ofo RQoGDz/pE2pIZSW8RJb3Oqr+Kj276gJOWFDj+aB13gDjxQQvG9OAFkMbuFpkuS/WC2kv k6CZ4kzo/HIiRGCX4kq6OtUTLMHVYgQ8y1/pu5Gc7ghEJ1qOrm0BYR16LVy0zgEqdG9O trCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w127-20020a636285000000b0046f55fec417si2544776pgb.650.2022.10.29.10.26.49; Sat, 29 Oct 2022 10:27:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230013AbiJ2RYt (ORCPT + 99 others); Sat, 29 Oct 2022 13:24:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229763AbiJ2RYO (ORCPT ); Sat, 29 Oct 2022 13:24:14 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3095940009 for ; Sat, 29 Oct 2022 10:24:06 -0700 (PDT) Received: from dslb-188-097-213-253.188.097.pools.vodafone-ip.de ([188.97.213.253] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oopYw-00074v-1b; Sat, 29 Oct 2022 19:24:02 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 11/13] staging: r8188eu: remove return value from on_action_public_default Date: Sat, 29 Oct 2022 19:23:35 +0200 Message-Id: <20221029172337.1574593-12-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221029172337.1574593-1-martin@kaiser.cx> References: <20221029172337.1574593-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748043743620318367?= X-GMAIL-MSGID: =?utf-8?q?1748043743620318367?= The only caller of on_action_public_default does not check the return value. We can make it a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index b395457a6a60..f5923792f067 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3788,22 +3788,15 @@ static void on_action_public_vendor(struct recv_frame *precv_frame) on_action_public_p2p(precv_frame); } -static unsigned int on_action_public_default(struct recv_frame *precv_frame) +static void on_action_public_default(struct recv_frame *precv_frame) { - unsigned int ret = _FAIL; u8 *pframe = precv_frame->rx_data; u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr); u8 token; token = frame_body[2]; - if (rtw_action_public_decache(precv_frame, token) == _FAIL) - goto exit; - - ret = _SUCCESS; - -exit: - return ret; + rtw_action_public_decache(precv_frame, token); } static void on_action_public(struct adapter *padapter, struct recv_frame *precv_frame)