From patchwork Sat Oct 29 17:23:34 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Martin Kaiser X-Patchwork-Id: 12760 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1439838wru; Sat, 29 Oct 2022 10:26:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7ThXvMmMaMrteFw0DSGe2thxhVDOF7xxQFNodPYVJwoOZvIxJdwxgSLjLw31GmaUkB1f+Q X-Received: by 2002:a17:902:ec86:b0:185:483e:e4ec with SMTP id x6-20020a170902ec8600b00185483ee4ecmr5380281plg.164.1667064395231; Sat, 29 Oct 2022 10:26:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667064395; cv=none; d=google.com; s=arc-20160816; b=kOfKMUKUlH9B7hZSZhUnty7d/mstfbSmKOFqbz0aRb0pjkUoL98a3ddr+J7sldJVrb 0n906mFqJpOB/B/bjjHgHoYjZkskBsR1Yn9Ua/4BMmT8sQeeJExTjroQw56WQULk7kRp Yj/OssRkrYPq83OIWATGcpVb7OXNSR3jGtqFHP9/OcKNabdrseNx115FsnYwOq2n/dN+ IiZF/Vq7D0SRVMJEABjYvXgoJnWawrVYaEREN8x+QUerxxmrajvmYwNM9bjmh1+Fhxaj At3+onKqnw4dhfnuiXAVrWbVvbp9dvpm4XiriLfncUaHmoWAQC9TIVGAWkk/gvIgh3nq 4o6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=DMZUsJNikyQLrk20aOH886hKhnIgPHP49kGmFXo+Dg0=; b=MuMlMT2lV5lgAyq3Bume+9pwAhZFwhlA+yfjym5ShYqoEwKQI400WTsKTRddGUZLxp upjC6meQPLaCnhuFXStZ+23u7Va0iyj6g6ArXCx6fsSOtI3ws9GvWg8sP3XPTZO9xB0p z3TMPkY5pku2dFLx7BNiipCQ6hrxY0vnem/vG7q4Su2kYiWFNXXMMh0R6vHvhAbYDOQP I9IF+gms/Ioi5rnrZTxOOr2hej4cPb9iPKISkilukApL8K/+y2EH3OzuVH+EzxnctvZf lHmvlmBeWhG0Vr9TBeR64147GnYO3EKe8LrxjXGWjn9FJsRPdCDU8/b8Gm/rLETJy5Zq 4Y+Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h30-20020a63575e000000b00463f080c19esi2423433pgm.559.2022.10.29.10.26.23; Sat, 29 Oct 2022 10:26:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229970AbiJ2RYe (ORCPT + 99 others); Sat, 29 Oct 2022 13:24:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34072 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229876AbiJ2RYM (ORCPT ); Sat, 29 Oct 2022 13:24:12 -0400 Received: from viti.kaiser.cx (viti.kaiser.cx [IPv6:2a01:238:43fe:e600:cd0c:bd4a:7a3:8e9f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C42050BB5 for ; Sat, 29 Oct 2022 10:24:04 -0700 (PDT) Received: from dslb-188-097-213-253.188.097.pools.vodafone-ip.de ([188.97.213.253] helo=martin-debian-2.paytec.ch) by viti.kaiser.cx with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1oopYv-00074v-7z; Sat, 29 Oct 2022 19:24:01 +0200 From: Martin Kaiser To: Greg Kroah-Hartman Cc: Larry Finger , Phillip Potter , Michael Straube , Pavel Skripkin , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Martin Kaiser Subject: [PATCH 10/13] staging: r8188eu: remove return value from on_action_public_vendor Date: Sat, 29 Oct 2022 19:23:34 +0200 Message-Id: <20221029172337.1574593-11-martin@kaiser.cx> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20221029172337.1574593-1-martin@kaiser.cx> References: <20221029172337.1574593-1-martin@kaiser.cx> MIME-Version: 1.0 X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748043715252760636?= X-GMAIL-MSGID: =?utf-8?q?1748043715252760636?= The only caller of on_action_public_vendor does not check the return value. We can make it a void function. Signed-off-by: Martin Kaiser --- drivers/staging/r8188eu/core/rtw_mlme_ext.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c index b3cef3504ad3..b395457a6a60 100644 --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c @@ -3779,17 +3779,13 @@ static unsigned int on_action_public_p2p(struct recv_frame *precv_frame) return _SUCCESS; } -static unsigned int on_action_public_vendor(struct recv_frame *precv_frame) +static void on_action_public_vendor(struct recv_frame *precv_frame) { - unsigned int ret = _FAIL; u8 *pframe = precv_frame->rx_data; u8 *frame_body = pframe + sizeof(struct ieee80211_hdr_3addr); - if (!memcmp(frame_body + 2, P2P_OUI, 4)) { - ret = on_action_public_p2p(precv_frame); - } - - return ret; + if (!memcmp(frame_body + 2, P2P_OUI, 4)) + on_action_public_p2p(precv_frame); } static unsigned int on_action_public_default(struct recv_frame *precv_frame)