| Message ID | 20221029141633.295650-13-manivannan.sadhasivam@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1371108wru;
Sat, 29 Oct 2022 07:19:58 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM6u4TZwAKg/U5A4VOSxxpPYnTrCWEelDarfmhdMNNAG21GnO5w11idwcFgjqprIXt+no2YJ
X-Received: by 2002:a17:902:d2ca:b0:187:a4e:f9c7 with SMTP id
n10-20020a170902d2ca00b001870a4ef9c7mr2030208plc.88.1667053197634;
Sat, 29 Oct 2022 07:19:57 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1667053197; cv=none;
d=google.com; s=arc-20160816;
b=GuTji9HrCs5O4VIg710d6cYREE+akhmsxz5F9I8Sd/DnO2ItxQjVNt5yh6gVCnyT5T
1oLLbcwVUS7DnK/OnLEAJGbj+zrxbzXLCjVwDuz2vRNHBhiJqyPjDSkJTI9YOxC+oRPJ
18RZV38PSkbQLbJXbiCJnEb4+vCBfAc990Q8zgN+yhzov3P/FUIYKI2ogaiQjMwnop8r
/U2gFvYNcKLtCJf/xq7TnEa+S5S1EtAAzO11s3/xi+DckN9LO9PwgoZ2q8ht/k9OJ8gZ
bOB3sR/ttM/HvdzS9+LaBFrscpMOFpTxqy8mdW3QY6VkpiSXXDr22qNtXit1k3m6693Q
Nmyg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=V6Cn6AAM+ruCSUx7hOhryryIVpbAjdLGLzoffp2NaNY=;
b=caqndBH7ldJz24yuz4Jlf9zIcnbXc6gxo8LJINxlj7WBX+1ffj+p6xS8t/BOmKRoIH
lu8utGe2SmpvGCKoiMt0yoi0OiyJn8n3z0CExWTksTIxtt4fj+Dk6VEcytUCy2xmL8P/
tUcQaBMfg+or8aUFQV8anXlhu4LOSX+z9SZ04sYlwQVNUUeAeT1jGtPv5Rjy3PfSXiaT
jF6OzGPti+Gnq9Ij7an32HZ9QV56/ZnDGnyDzsAhSAq2X/Mii6Y9dCQbNrJDscxI+akV
qnarQHewnMJjb2TYzkCKluCNoWSkDRJH2XHABOxtot1qPKCWnZ4ES3ZGf03SKDLPGswB
OoTQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=WT8C9Z4I;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
b7-20020a170902a9c700b00186be05c702si1818908plr.530.2022.10.29.07.19.45;
Sat, 29 Oct 2022 07:19:57 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=WT8C9Z4I;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229970AbiJ2OTP (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others);
Sat, 29 Oct 2022 10:19:15 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40392 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229872AbiJ2OSl (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 29 Oct 2022 10:18:41 -0400
Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com
[IPv6:2607:f8b0:4864:20::1030])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8A965FC26
for <linux-kernel@vger.kernel.org>;
Sat, 29 Oct 2022 07:17:47 -0700 (PDT)
Received: by mail-pj1-x1030.google.com with SMTP id
m6-20020a17090a5a4600b00212f8dffec9so6861957pji.0
for <linux-kernel@vger.kernel.org>;
Sat, 29 Oct 2022 07:17:47 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=V6Cn6AAM+ruCSUx7hOhryryIVpbAjdLGLzoffp2NaNY=;
b=WT8C9Z4ISqHLbq0ws3aGDgQn4ZnrIZqfE5JVaofV5V8Q/4jxd/1yyHqv+szIEQSkn/
riTWtO4o/TvPc6R8oZY/v+TEMjhwsi/S+LT97zFoYU9jwW+CJ7MOP9ZvNnz8MfbhHCyL
piUS20GmVWf83DmJTqvaoYZTSazuQFQMAC5CQkfSe818aWluRP0HEls7yLgLiIRNeLL9
/Go8f5VbiyicQH0qeVEfZJ+DXXaf5Hkx2G1PrhLJVIFfhxhM4heT3hANhJlELhjj0s1w
5rp+srjuc3fYOW+HOQkxT22kfud+zAn4bo8AVgkIBLU0D8EixcMx/N6GA83haFqO4MNN
LIlQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=V6Cn6AAM+ruCSUx7hOhryryIVpbAjdLGLzoffp2NaNY=;
b=KpW+T9OaCF5kbeZm5SRuVPkNp7E6Ge34uG8e/lbQkMAZajKhEEBViN3fK4R0hR8D67
0jEgGK84f7tuzNn+cyXw8L+rS2sE97T0AWReT5xBHTa27aLMV9CMtdSHU/rF+Y0WxnXm
mYUiY4nIjs9TiUZHuU9wHBzZNqLB6sXYIx+MniIhkDPZj0TOObmc+pnvY96d+xJDUt6x
nnTGSDnp6LJjDwP6VcKnkGIq8puT0RuCF2JlBDPzwzXorDc2o6jv0b+rTrt5DfseC+F1
a/1k6OTne6SKs4NcMleazEOHTXdZcTSBys6+Qqr6N+6L0NWRre9pGt6y64bIm4fGhbfi
jtfQ==
X-Gm-Message-State: ACrzQf179umgxd4bhYGqfaorOicg9qG9TMEnNtDQHlJitR6KToYayHYR
+8v1A2pLkWU36/w+qri9hXKO
X-Received: by 2002:a17:90a:5509:b0:213:98ab:da74 with SMTP id
b9-20020a17090a550900b0021398abda74mr5056156pji.208.1667053067496;
Sat, 29 Oct 2022 07:17:47 -0700 (PDT)
Received: from localhost.localdomain ([117.193.208.18])
by smtp.gmail.com with ESMTPSA id
u4-20020a170902e5c400b001866049ddb1sm1370157plf.161.2022.10.29.07.17.42
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 29 Oct 2022 07:17:46 -0700 (PDT)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: martin.petersen@oracle.com, jejb@linux.ibm.com,
andersson@kernel.org, vkoul@kernel.org,
krzysztof.kozlowski+dt@linaro.org
Cc: konrad.dybcio@somainline.org, robh+dt@kernel.org,
quic_cang@quicinc.com, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-phy@lists.infradead.org, linux-scsi@vger.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH 12/15] scsi: ufs: ufs-qcom: Fix the Qcom register name for
offset 0xD0
Date: Sat, 29 Oct 2022 19:46:30 +0530
Message-Id: <20221029141633.295650-13-manivannan.sadhasivam@linaro.org>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221029141633.295650-1-manivannan.sadhasivam@linaro.org>
References: <20221029141633.295650-1-manivannan.sadhasivam@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1748031973783602570?=
X-GMAIL-MSGID: =?utf-8?q?1748031973783602570?=
|
| Series |
ufs: qcom: Add HS-G4 support
|
|
Commit Message
Manivannan Sadhasivam
Oct. 29, 2022, 2:16 p.m. UTC
Fix the register name used for offset 0xD0. The correct name is
REG_UFS_PARAM0.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/ufs/host/ufs-qcom.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 29/10/2022 17:16, Manivannan Sadhasivam wrote: > Fix the register name used for offset 0xD0. The correct name is > REG_UFS_PARAM0. The vendor kernels starting from 3.10 define this register as RETRY_TIMER_REG (but it is unused). I'd suggest adding a comment about the older register name. > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > drivers/ufs/host/ufs-qcom.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h > index 6cb0776456b3..214ea50acab9 100644 > --- a/drivers/ufs/host/ufs-qcom.h > +++ b/drivers/ufs/host/ufs-qcom.h > @@ -33,7 +33,7 @@ enum { > REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4, > REG_UFS_LOCAL_PORT_ID_REG = 0xC8, > REG_UFS_PA_ERR_CODE = 0xCC, > - REG_UFS_RETRY_TIMER_REG = 0xD0, > + REG_UFS_PARAM0 = 0xD0, > REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8, > REG_UFS_CFG1 = 0xDC, > REG_UFS_CFG2 = 0xE0,
On Sun, Oct 30, 2022 at 01:06:20AM +0300, Dmitry Baryshkov wrote: > On 29/10/2022 17:16, Manivannan Sadhasivam wrote: > > Fix the register name used for offset 0xD0. The correct name is > > REG_UFS_PARAM0. > > The vendor kernels starting from 3.10 define this register as > RETRY_TIMER_REG (but it is unused). I'd suggest adding a comment about the > older register name. > Makes sense to me. Thanks, Mani > > > > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > --- > > drivers/ufs/host/ufs-qcom.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h > > index 6cb0776456b3..214ea50acab9 100644 > > --- a/drivers/ufs/host/ufs-qcom.h > > +++ b/drivers/ufs/host/ufs-qcom.h > > @@ -33,7 +33,7 @@ enum { > > REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4, > > REG_UFS_LOCAL_PORT_ID_REG = 0xC8, > > REG_UFS_PA_ERR_CODE = 0xCC, > > - REG_UFS_RETRY_TIMER_REG = 0xD0, > > + REG_UFS_PARAM0 = 0xD0, > > REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8, > > REG_UFS_CFG1 = 0xDC, > > REG_UFS_CFG2 = 0xE0, > > -- > With best wishes > Dmitry >
diff --git a/drivers/ufs/host/ufs-qcom.h b/drivers/ufs/host/ufs-qcom.h index 6cb0776456b3..214ea50acab9 100644 --- a/drivers/ufs/host/ufs-qcom.h +++ b/drivers/ufs/host/ufs-qcom.h @@ -33,7 +33,7 @@ enum { REG_UFS_TX_SYMBOL_CLK_NS_US = 0xC4, REG_UFS_LOCAL_PORT_ID_REG = 0xC8, REG_UFS_PA_ERR_CODE = 0xCC, - REG_UFS_RETRY_TIMER_REG = 0xD0, + REG_UFS_PARAM0 = 0xD0, REG_UFS_PA_LINK_STARTUP_TIMER = 0xD8, REG_UFS_CFG1 = 0xDC, REG_UFS_CFG2 = 0xE0,