From patchwork Fri Oct 28 14:17:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Arthur Grillo X-Patchwork-Id: 12331 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp862229wru; Fri, 28 Oct 2022 07:26:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6nDFtoABMgg7fwHoM1TCtSZ4F+yr84hk9BlM7DUfUYqb0jlEHdunH4djZ9WRZrxLL464We X-Received: by 2002:a17:906:fe45:b0:788:15a5:7495 with SMTP id wz5-20020a170906fe4500b0078815a57495mr47894979ejb.633.1666967176422; Fri, 28 Oct 2022 07:26:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666967176; cv=none; d=google.com; s=arc-20160816; b=qVrBMa9vYAifOr51SsIFsjbUqxsH5tH3mWXibLIGpcYZheGrb/+w5RSe2K/el1y29U zPi/onR2bEEDqDZ+9ISJwu52oFO/GjIWhF7w3p00FCvousiPnCSrAqAbPHG5gt55IPku fJcHaogA2jtUGftt5dqz6vdt1RIff/5HEAFbq5UwPCzQ/87HLWuMe6WMLBU6M2ybsTs4 GGl2vY4oe5Nl5LYFZmUw+VdA+x1RWfoLAkFYGgPZL1g4OouRe18Fmgye0RedkEhndjqw 1elfCCkJS6FPlTsa2UpstJ4dUXNMxhreLyRd1SrwVU0cr0ZxqEeDE08URUS8uAicM/UQ pjTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Sg5eQasF+zSM54qDVPbvvETvGDiVPSy2/mQ6nnmsJTk=; b=Oph9pEnTeGaphl2La95Jgz27a2qp3KePD8C/jk105tOUuO5o0d1vRHpl7Egh0epmZ2 ze6jaudCoN5gbCehkNZvWAqnNzpczN+emHHzKDpOZVIeyqg88TKv4OGvm+uUL38aS7vR 1EVi0C9h+DwCmfWxgxUceFNvN1ld56fWnPKe6rcWpjtTWmxIZu5NiTIdXnHDn2g2/gWr QNyYZJ8gEH+sUrA0MQ+6K39c5C9m++KoNb8pJ3FVw0wsXic7WZcIwUoEvR7lrq0qo84S pQ1YUPqAJihO+fDQhnC3A8D+AweVrC/fpRZ5q/0sxa44WDGUbg4WGjocKN+sI0v+zpNa +mmg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@riseup.net header.s=squak header.b=H1MemKUQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=riseup.net Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c7-20020aa7c747000000b00459dc4e4b7fsi4252619eds.143.2022.10.28.07.25.52; Fri, 28 Oct 2022 07:26:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@riseup.net header.s=squak header.b=H1MemKUQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=riseup.net Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230119AbiJ1ORa (ORCPT + 99 others); Fri, 28 Oct 2022 10:17:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48750 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229872AbiJ1OR2 (ORCPT ); Fri, 28 Oct 2022 10:17:28 -0400 Received: from mx0.riseup.net (mx0.riseup.net [198.252.153.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 607BF1D6A63 for ; Fri, 28 Oct 2022 07:17:27 -0700 (PDT) Received: from fews1.riseup.net (fews1-pn.riseup.net [10.0.1.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mail.riseup.net", Issuer "R3" (not verified)) by mx0.riseup.net (Postfix) with ESMTPS id 4MzPkt5YXCz9t2l; Fri, 28 Oct 2022 14:17:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=riseup.net; s=squak; t=1666966647; bh=05DwsEtuFxAdWMYdnLuc4HqkK3OOSFQT/s1dsjunvVo=; h=From:To:Cc:Subject:Date:From; b=H1MemKUQwg2r0iR+b0GCsA6ZEHIyiBzZwg/tpgGCTHjxtqqsnKpqUdHvRrSxEwc29 vjB3SYmYXKypboU2KM9Sqoanm3jhnQ/8t0tmcIQ5h/sC0XnTkaDXqFryro0hoNEeys G/tOwICghcm4T+D5PsIOoaM0xmXpKEUYK1+U2pzI= X-Riseup-User-ID: 60BAB0CF0D43BD6345A4C232725DB4247F6C53CBDC54E6A95636B368FF910655 Received: from [127.0.0.1] (localhost [127.0.0.1]) by fews1.riseup.net (Postfix) with ESMTPSA id 4MzPkp5T67z5vRl; Fri, 28 Oct 2022 14:17:22 +0000 (UTC) From: Arthur Grillo To: David Airlie , Daniel Vetter , Javier Martinez Canillas , =?utf-8?q?Ma=C3=ADra_Canal?= , =?utf-8?q?Toke_H?= =?utf-8?q?=C3=B8iland-J=C3=B8rgensen?= , "Jason A. Donenfeld" Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, David Gow , Daniel Latypov , andrealmeid@riseup.net, melissa.srw@gmail.com, Arthur Grillo , =?utf-8?q?Micha=C5=82_Winiarski?= Subject: [PATCH v4] drm/tests: Add back seed value information Date: Fri, 28 Oct 2022 11:17:15 -0300 Message-Id: <20221028141715.290903-1-arthurgrillo@riseup.net> MIME-Version: 1.0 X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_PASS, SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747941708044964316?= X-GMAIL-MSGID: =?utf-8?q?1747941774071183551?= As reported by Michał the drm_mm and drm_buddy unit tests lost the printk with seed value after they were refactored into KUnit. Add kunit_info with seed value information to assure reproducibility. Reported-by: Michał Winiarski Signed-off-by: Arthur Grillo Reviewed-by: Maíra Canal --- v1->v2: https://lore.kernel.org/all/20221026211458.68432-1-arthurgrillo@riseup.net/ - Correct compilation issues - Change tags order - Remove useless line change - Write commit message in imperative form - Remove redundant message part - Correct some grammars nits - Correct checkpatch issues v2->v3: https://lore.kernel.org/all/20221027142903.200169-1-arthurgrillo@riseup.net/ - Change .init to .suite_init - Correct some grammars nits v3->v4: - Correct compilation issues --- drivers/gpu/drm/tests/drm_buddy_test.c | 6 ++++-- drivers/gpu/drm/tests/drm_mm_test.c | 8 ++++++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/tests/drm_buddy_test.c b/drivers/gpu/drm/tests/drm_buddy_test.c index 62f69589a72d..90ec5e8a485b 100644 --- a/drivers/gpu/drm/tests/drm_buddy_test.c +++ b/drivers/gpu/drm/tests/drm_buddy_test.c @@ -726,11 +726,13 @@ static void drm_test_buddy_alloc_limit(struct kunit *test) drm_buddy_fini(&mm); } -static int drm_buddy_init_test(struct kunit *test) +static int drm_buddy_init_suite(struct kunit_suite *suite) { while (!random_seed) random_seed = get_random_u32(); + kunit_info(suite, "Testing DRM buddy manager, with random_seed=0x%x\n", random_seed); + return 0; } @@ -746,7 +748,7 @@ static struct kunit_case drm_buddy_tests[] = { static struct kunit_suite drm_buddy_test_suite = { .name = "drm_buddy", - .init = drm_buddy_init_test, + .suite_init = drm_buddy_init_suite, .test_cases = drm_buddy_tests, }; diff --git a/drivers/gpu/drm/tests/drm_mm_test.c b/drivers/gpu/drm/tests/drm_mm_test.c index c4b66eeae203..4663e4611976 100644 --- a/drivers/gpu/drm/tests/drm_mm_test.c +++ b/drivers/gpu/drm/tests/drm_mm_test.c @@ -2209,11 +2209,15 @@ static void drm_test_mm_color_evict_range(struct kunit *test) vfree(nodes); } -static int drm_mm_init_test(struct kunit *test) +static int drm_mm_init_suite(struct kunit_suite *suite) { while (!random_seed) random_seed = get_random_u32(); + kunit_info(suite, + "Testing DRM range manager, with random_seed=0x%x max_iterations=%u max_prime=%u\n", + random_seed, max_iterations, max_prime); + return 0; } @@ -2246,7 +2250,7 @@ static struct kunit_case drm_mm_tests[] = { static struct kunit_suite drm_mm_test_suite = { .name = "drm_mm", - .init = drm_mm_init_test, + .suite_init = drm_mm_init_suite, .test_cases = drm_mm_tests, };