Message ID | 20221028070439.GA36889@rdm |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp667485wru; Fri, 28 Oct 2022 00:08:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4aDQ4lljNjNbSGfFEWaTJk/oG+ApYNpsznrilIYsYtEITZ8wnr+1HiPX0BW5a3IRnalVs+ X-Received: by 2002:a17:902:bd47:b0:17f:685b:27ee with SMTP id b7-20020a170902bd4700b0017f685b27eemr51638831plx.22.1666940924532; Fri, 28 Oct 2022 00:08:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666940924; cv=none; d=google.com; s=arc-20160816; b=f04XdgV6PPAfVkImlAcBBMiExQJDPire5KoA1UTWDSvTsE9Dwe+HRHiIJuZdCc5liL tIfqgCJ3DL/ZTzRQvLVi8q+QHvoZDybe/6dC+aHVJS++LwEFyUMaWq91KO11y6lVHnor 7BHTbmSSXJJq1n9i83cbVmGorthuyIsF31f5jhWqVR3GcCqu8HX443FQjB+l1565zXUO us3OKkOOgMyn7najjNUKmdUy7GvbqbwAp9SC6Yt6l1P50J2+RK3MlO/+uYbq57pmdNiy zq8+vDiOcnCvQMvESey68MqI11v1+DFUaTDJSHjXOTO9LZx8HwzOAOboNHe1z8858ZWb yuvw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:to:from:date:dkim-signature; bh=4A+DB3MMGxIRPCuM9r59RYr1Fl7TwCHgwudqyCCvsC0=; b=pSKktIFedpv54NuwJgmxMLGVkY4dxjry3SluirumnyGTtpcyHDSMkDb13weYRMXBJL 2bjfxG6FJvS4yvBhU46LFCpZ7dXT4T7/n4hYQPcdqfe3mrBOCJXvHa2jLTIDQpD4/+Lp NwSFJPZZ5VkHjp9bW9WL74HYNfCFAmvqZdDrWthITHcPfj8b7AQU42AswQYH7wwCx08Q WFLR3K3pjQhSF1ZQGhuV/1xyLMSldi+zWuFTzdViFRyZEo1F6La/xn72+ggAeyaLqL0n TsPXXtQKwu9RmAil8eg1n6x9DCbXCIbLZRTMDIfcmbKxLWeMl+UsJcVdMMAh0KGWVTbF /XDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=X294my3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mq16-20020a17090b381000b001fd7cab081bsi10692370pjb.125.2022.10.28.00.08.30; Fri, 28 Oct 2022 00:08:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=X294my3G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbiJ1HFV (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Fri, 28 Oct 2022 03:05:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230029AbiJ1HFH (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Oct 2022 03:05:07 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E0F33638ED for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 00:05:00 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id v1so5738273wrt.11 for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 00:05:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=4A+DB3MMGxIRPCuM9r59RYr1Fl7TwCHgwudqyCCvsC0=; b=X294my3GunzaICmgTrsU5fOQP4WGX6lg1uHXMpulNUGBlU11/LtC8FNRtLxr3Y3Zv7 9aN70wl6eX+0Mudq38kmx4VGAh3AsTniBCfoYNjOUxXUNwGV6HX6bphNBpQCAAywPE8w hyOd8KlFCbkdd9zetRvsEVqyc4PDtLleWAWhMQorQhbNbfH8jjL7wi9Hx6YmatDQ2I20 eTmuDGvCYkcJJYGVl53k/cYGcyKE94Zkw0Iw3eY9OJkaGqy0kj4+3coc55mUeZqYGlIF JuRnX6cxoBpZt+ekJhL/meC7aE3GoEw4UfSYq4mUihWrQuHjZNjtW3ggymJHvrYQuFKa c24Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4A+DB3MMGxIRPCuM9r59RYr1Fl7TwCHgwudqyCCvsC0=; b=s3UVPf7Vv7ODpwV8gXiuNlauqZVTEVwMwobbb6OAJgB05WyE64QvC1qj0SQGUFrzES /d1f4aJba08p3IgXw9r1ujs5+ERtAopnEdyPEuHRqHEKHfYCj4W+ZVVoEqkliLXkge0H BK6MdAsjQlV2nXST/04JGgI7ETUZDbkoy1oAruOdYdzYCHgInsXpOgtasrGg71uyoZFS 8QElTyKc+7wAXgIRHDXD27T6mlgnUU/Qi1EiBvwTbwP7qMVGHvw/NVVIJkNOoYgstWFT MZWuPoLWSSUsLi0dRVnJuaDzUAlOjqZ0imZU27KxXJ6YcKY56eVHpFFdXFrgn2SF9UZN Uyag== X-Gm-Message-State: ACrzQf0wqkBVHaDOD9ghG0te8GkCNNGhrbfZXHUygS98YSM3r87THHbA QmbscxSrgC6otcL7ET+Tx3WtWyCvIXHShM6H X-Received: by 2002:adf:f342:0:b0:236:9035:31b6 with SMTP id e2-20020adff342000000b00236903531b6mr6210790wrp.200.1666940689054; Fri, 28 Oct 2022 00:04:49 -0700 (PDT) Received: from rdm ([41.75.189.203]) by smtp.gmail.com with ESMTPSA id v11-20020a5d4a4b000000b0023662d97130sm2914757wrs.20.2022.10.28.00.04.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Oct 2022 00:04:48 -0700 (PDT) Date: Fri, 28 Oct 2022 10:04:39 +0300 From: UMWARI JOVIAL <umwarijovial@gmail.com> To: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, outreachy@lists.linux.dev Subject: [PATCH] Possible repeated word: 'very' Message-ID: <20221028070439.GA36889@rdm> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747914247188622258?= X-GMAIL-MSGID: =?utf-8?q?1747914247188622258?= |
Series |
Possible repeated word: 'very'
|
|
Commit Message
UMWARI JOVIAL
Oct. 28, 2022, 7:04 a.m. UTC
Reported By checkpatch.pl script
WARNING: Possible repeated word: 'very'
Repetition of the same word in one sentence same line
Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com>
---
drivers/staging/rtl8712/rtl871x_xmit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, Oct 28, 2022 at 10:04:39AM +0300, UMWARI JOVIAL wrote: > Reported By checkpatch.pl script > > WARNING: Possible repeated word: 'very' > > Repetition of the same word in one sentence same line > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index 090345bad223..30a0276b8b58 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > * If we turn on USE_RXTHREAD, then, no need for critical section. > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > * > - * Must be very very cautious... > + * Must be very cautious... > * > */ > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv) > -- > 2.25.1 > This patch is an updated version of another patch you sent, so you must use the "v2" prefix. Furthermore, you need to have to name of the subsystem that change. So it should be something like: [PATCH v2] staging: rtl8712: <short description of the commit> And I think the person who wrote that just wanted to stress it by duplicating "very". So I don't think this patch is necessary. Best regards, Nam
On Fri, Oct 28, 2022 at 10:04:39AM +0300, UMWARI JOVIAL wrote: > Reported By checkpatch.pl script > > WARNING: Possible repeated word: 'very' > > Repetition of the same word in one sentence same line > > Signed-off-by: UMWARI JOVIAL <umwarijovial@gmail.com> > --- > drivers/staging/rtl8712/rtl871x_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c > index 090345bad223..30a0276b8b58 100644 > --- a/drivers/staging/rtl8712/rtl871x_xmit.c > +++ b/drivers/staging/rtl8712/rtl871x_xmit.c > @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) > * If we turn on USE_RXTHREAD, then, no need for critical section. > * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... > * > - * Must be very very cautious... > + * Must be very cautious... > * > */ > struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv) NAK! You send patch with the same content as [1], for which Greg already replied as [2]. The code and its comments imply that calling r8712_alloc_xmitframe() must be done with extreme caution, isn't it? Thanks. [1]: https://lore.kernel.org/lkml/20221028051420.GA30073@rdm/ [2]: https://lore.kernel.org/lkml/Y1tx8XjmR5QKV9lQ@kroah.com/
diff --git a/drivers/staging/rtl8712/rtl871x_xmit.c b/drivers/staging/rtl8712/rtl871x_xmit.c index 090345bad223..30a0276b8b58 100644 --- a/drivers/staging/rtl8712/rtl871x_xmit.c +++ b/drivers/staging/rtl8712/rtl871x_xmit.c @@ -766,7 +766,7 @@ void r8712_free_xmitbuf(struct xmit_priv *pxmitpriv, struct xmit_buf *pxmitbuf) * If we turn on USE_RXTHREAD, then, no need for critical section. * Otherwise, we must use _enter/_exit critical to protect free_xmit_queue... * - * Must be very very cautious... + * Must be very cautious... * */ struct xmit_frame *r8712_alloc_xmitframe(struct xmit_priv *pxmitpriv)