From patchwork Thu Oct 27 21:28:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Won Chung X-Patchwork-Id: 11991 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp469937wru; Thu, 27 Oct 2022 14:44:55 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7QKGskx5pffVyJLuGEGGP1X4d3UW9MscuNvF/hEnV4hr1I3RTWAbTd2CkewnyOX+9G2WmC X-Received: by 2002:a05:6402:1947:b0:461:a47d:274 with SMTP id f7-20020a056402194700b00461a47d0274mr24373206edz.165.1666907095437; Thu, 27 Oct 2022 14:44:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666907095; cv=none; d=google.com; s=arc-20160816; b=VVYVVBewNsVTAkVTt/haPeOSuHyVPwgPomh8+rJtMtJG0mZV4caMSFBEcfy5aa1npO oy5X4q1iAhDo+UqH9taToIlBzJeAVuh2fnDQn+2XmT8cIyFqrb7ehu9KzOekUahbkm+s VwzpXK9YX+UrtGhLNzRBx6ZQHc3hcXlmpQVDBmTe1TS7tbmTQVmxe0DvgDseOW0dVSz7 kOFC7wJZxNH3YrZYwXHLM+IXdmxwhXyxiOUrZBFGzuYXEolI4hkw1lLi3z35cw/JmdjT kF5ts0Rwn2mKf+Qi4MyMGfHItjrjeuWspABDg0X6Pyp53FVHxLiR6JulYLp6CpWZLw7+ N4Xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:to:from:subject:message-id:mime-version:date :dkim-signature; bh=sogLxSdG4yhSyQPPmGTG1lTI5fUEQY8x224g/Iq10fc=; b=amiWMHRvpqWisRbiiD1+KDkEMFi09J57hEKVLmzW3wQJoo/jIxBJMRQ8XJNmPRb1mU 3kwjIGbuZozzu2y01OY+sw9InaT/tht7id8aiwKo5cs7/vC6VFGlIvtv/1ktZoVoxroN rGenJe2ti9gh+FSFEGabs0NeHOPil8KjALUzxhywun3rY09msctSLFLldeenVkRJ6vox GeCQjFIObYtrhvDD/H+LQdn3aM8nzKGk1SRYAsjKn4DJeV+KQt08pbMG1oQ4p7adgs/L APHjEVnWdUsV7LSYqRDGYmq1mZ9IeXm9ie6Idktm00XUb1rqLoNVQnoEVVfeJIYy3qy8 plkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ZfPQ53qW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m4-20020a50d7c4000000b004628e41569esi2572345edj.155.2022.10.27.14.44.31; Thu, 27 Oct 2022 14:44:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=ZfPQ53qW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236877AbiJ0V3F (ORCPT + 99 others); Thu, 27 Oct 2022 17:29:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235686AbiJ0V3D (ORCPT ); Thu, 27 Oct 2022 17:29:03 -0400 Received: from mail-pg1-x54a.google.com (mail-pg1-x54a.google.com [IPv6:2607:f8b0:4864:20::54a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 88DFA62A8B for ; Thu, 27 Oct 2022 14:29:02 -0700 (PDT) Received: by mail-pg1-x54a.google.com with SMTP id p24-20020a63f458000000b0043cd718c49dso1404980pgk.15 for ; Thu, 27 Oct 2022 14:29:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=sogLxSdG4yhSyQPPmGTG1lTI5fUEQY8x224g/Iq10fc=; b=ZfPQ53qWiF9lKVX7A6P52Hq3jFTphhwqs712Act23LApJ68RGcZiAYyi9BwF+Zl+AV a0lM5zs8rBWPovdTteQVAHwN0wrzj990wBJBsnlaf4bKLExxEl9FQbxCP7mOphdTB0SB 4BKGGYsX66p9ToTP9xG8ipeq8gBa0QZo5COoWeUFYvDhXpLmgu9BxECYUW4mXuSITOpb +vpq9LhO5MIkI9j7dtDMgAQyZHeo61lmrhSg7EERHcZrYcWZ4EGm9iALoA36WiLjOGdO 4aats94IGSscqNdxVjuYSH/alw8dVwbFeaWq3H8BwPg0/SpFqo4IyJeTO2fvQ3cplfKt hhAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=sogLxSdG4yhSyQPPmGTG1lTI5fUEQY8x224g/Iq10fc=; b=ENsGXCC0RktqbCv63W+ygrjveZ1raKaHY+KCqDYdqgs4AmslvroU7TkERQwagdOoPe 7fDjTIuJy/k6xuTUjFGWySmovZf3vwDVDqReqyE49IEyZERy48NU3jgJUqbTWJnFtMxU GHF1/aqXAUWDqPNTz7g4M9StsQqWFDr1wbISeyTGN2nuhMzgoORFvtmgLrJtVa07d6D0 L85lYiIimaVxOKz+zZ8hB7I73eYyaPSVXeFxYaeBL3q9vnx3Go3dOY0rUw9FnalHyDiV tSsTZio7oQXKMmYkAK77LpJvgHEHiJ1y/soaYD0xMnYhGWkDO5p+xjraoBxirXbCwyOY 31Gg== X-Gm-Message-State: ACrzQf1Hg1600dCU0JUJw/VwEKYhXGvLvzxmGjI3axqAAiqG5oD9VfSC YSKfPj80X5NgLZzGjNf2RI3TbYaXoncTFA== X-Received: from wonchungspecialist.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:1440]) (user=wonchung job=sendgmr) by 2002:a05:6a00:150e:b0:56c:83b3:d148 with SMTP id q14-20020a056a00150e00b0056c83b3d148mr7337251pfu.48.1666906142035; Thu, 27 Oct 2022 14:29:02 -0700 (PDT) Date: Thu, 27 Oct 2022 21:28:54 +0000 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog Message-ID: <20221027212854.1083686-1-wonchung@google.com> Subject: [PATCH v3] drm/sysfs: Link DRM connectors to corresponding Type-C connectors From: Won Chung To: wonchung@google.com, bleung@google.com, pmalani@chromium.org, heikki.krogerus@linux.intel.com, imre.deak@intel.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@linux.ie, airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747878774270212092?= X-GMAIL-MSGID: =?utf-8?q?1747878774270212092?= Create a symlink pointing to USB Type-C connector for DRM connectors when they are created. The link will be created only if the firmware is able to describe the connection beween the two connectors. Signed-off-by: Won Chung Acked-by: Heikki Krogerus --- Changes from v2: - Resending the patch to dri-devel list Changes from v1: - Fix multiple lines to single line drivers/gpu/drm/drm_sysfs.c | 40 +++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 430e00b16eec..6a9904fa9186 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -11,12 +11,14 @@ */ #include +#include #include #include #include #include #include #include +#include #include #include @@ -95,6 +97,34 @@ static char *drm_devnode(struct device *dev, umode_t *mode) return kasprintf(GFP_KERNEL, "dri/%s", dev_name(dev)); } +static int typec_connector_bind(struct device *dev, + struct device *typec_connector, void *data) +{ + int ret; + + ret = sysfs_create_link(&dev->kobj, &typec_connector->kobj, "typec_connector"); + if (ret) + return ret; + + ret = sysfs_create_link(&typec_connector->kobj, &dev->kobj, "drm_connector"); + if (ret) + sysfs_remove_link(&dev->kobj, "typec_connector"); + + return ret; +} + +static void typec_connector_unbind(struct device *dev, + struct device *typec_connector, void *data) +{ + sysfs_remove_link(&typec_connector->kobj, "drm_connector"); + sysfs_remove_link(&dev->kobj, "typec_connector"); +} + +static const struct component_ops typec_connector_ops = { + .bind = typec_connector_bind, + .unbind = typec_connector_unbind, +}; + static CLASS_ATTR_STRING(version, S_IRUGO, "drm 1.1.0 20060810"); /** @@ -355,6 +385,13 @@ int drm_sysfs_connector_add(struct drm_connector *connector) if (connector->ddc) return sysfs_create_link(&connector->kdev->kobj, &connector->ddc->dev.kobj, "ddc"); + + if (dev_fwnode(kdev)) { + r = component_add(kdev, &typec_connector_ops); + if (r) + drm_err(dev, "failed to add component\n"); + } + return 0; err_free: @@ -367,6 +404,9 @@ void drm_sysfs_connector_remove(struct drm_connector *connector) if (!connector->kdev) return; + if (dev_fwnode(connector->kdev)) + component_del(connector->kdev, &typec_connector_ops); + if (connector->ddc) sysfs_remove_link(&connector->kdev->kobj, "ddc");