From patchwork Thu Oct 27 15:05:54 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11841 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp287413wru; Thu, 27 Oct 2022 08:12:19 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4Q4WRbWidYJdAa+vA1rRPzr48s1GLi1O/vgBG0OFpGxsL2NiiBEPkg/V0+B5JH9bN4IdWf X-Received: by 2002:a05:6402:7c4:b0:462:9bc2:d0d0 with SMTP id u4-20020a05640207c400b004629bc2d0d0mr2819380edy.122.1666883539731; Thu, 27 Oct 2022 08:12:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666883539; cv=none; d=google.com; s=arc-20160816; b=CBcxUeg8nLcaXWs1sU2qkmdWaXUrCW3CDdoFYfha7p9hSYSu3iUTcai94aXTqk3g6q lkTX141C97oz640lTPQgEAHq/9h6E8BQSi4j+COKsVBdlVBkhQY+EiZbewXUqO2J6Yvl XtDYgsLMH6mznDDRh+fAFzF7BkIvljMb8dQj9Xt90CeXywVYzRhvaMYGaCCpOFklyBLu hfOl8rIoRoXaAxMYR7/EuJ5enj5MadQ9ExnbrZFCJfiWRKPNN9xB1fWXVpC6FLC2JBdF Kgubj83GchNzWU5I4a6ei3m71PGWjV5FaXOLtL1y18p3qFL9QLr4+KlM7usxA9weJu+V 7RCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=T/IFwRCpXkpfGu2EvCxOyZPHcmt/6iyYYKY1uEo6ZmA=; b=sWAPrrWVpcGt8nBl70jdG8565eg6sS8XeBZR5gGVJnDxmnZsa+BuRr8RdmUkITiGqn DP0nnmXDcT6Q6S2/hNZShIJkVoX625lcoOQaCiroRSlNgXDKAeZT/ORH3OLlfxXWkFaE bqxvp8gLr/jbhrKg1+CLMnsVZDiH7sAYtZR2Qqdarvfz7kLdQltflOlgor21jQv3FFqj TY/R3dWQpDkTOK9xHsh0DDY5qG4GmDYhlHYzMwpHEl2mIgowlaeoqH2a/8Eay+ON4QjW Cq8QhX3fP6kfM8r4jtlPhYTgAAYphYIMbV5SqJZaa64vHdCsvJMjUK+wD2lU8K1KDTd6 Kucg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dd15-20020a1709069b8f00b007a7f207a1b9si1752589ejc.664.2022.10.27.08.11.55; Thu, 27 Oct 2022 08:12:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236463AbiJ0PK6 (ORCPT + 99 others); Thu, 27 Oct 2022 11:10:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236088AbiJ0PJS (ORCPT ); Thu, 27 Oct 2022 11:09:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE38E18F937 for ; Thu, 27 Oct 2022 08:09:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C300C623C1 for ; Thu, 27 Oct 2022 15:09:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9E617C433D7; Thu, 27 Oct 2022 15:09:15 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oo4Ve-00Bvhr-2p; Thu, 27 Oct 2022 11:09:30 -0400 Message-ID: <20221027150930.702028779@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 27 Oct 2022 11:05:54 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Jaroslav Kysela , Takashi Iwai , Austin Kim , alsa-devel@alsa-project.org Subject: [RFC][PATCH v2 29/31] timers: ALSA: Use del_timer_shutdown() before freeing timer References: <20221027150525.753064657@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747854074504736495?= X-GMAIL-MSGID: =?utf-8?q?1747854074504736495?= From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Austin Kim Cc: alsa-devel@alsa-project.org Signed-off-by: Steven Rostedt (Google) Reviewed-by: Takashi Iwai --- sound/i2c/other/ak4117.c | 2 +- sound/synth/emux/emux.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/i2c/other/ak4117.c b/sound/i2c/other/ak4117.c index 1bc43e927d82..5269ab7321a4 100644 --- a/sound/i2c/other/ak4117.c +++ b/sound/i2c/other/ak4117.c @@ -47,7 +47,7 @@ static void reg_dump(struct ak4117 *ak4117) static void snd_ak4117_free(struct ak4117 *chip) { - del_timer_sync(&chip->timer); + del_timer_shutdown(&chip->timer); kfree(chip); } diff --git a/sound/synth/emux/emux.c b/sound/synth/emux/emux.c index a870759d179e..a43025f466bb 100644 --- a/sound/synth/emux/emux.c +++ b/sound/synth/emux/emux.c @@ -129,7 +129,7 @@ int snd_emux_free(struct snd_emux *emu) if (! emu) return -EINVAL; - del_timer_sync(&emu->tlist); + del_timer_shutdown(&emu->tlist); snd_emux_proc_free(emu); snd_emux_delete_virmidi(emu);