From patchwork Thu Oct 27 15:05:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11844 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp288113wru; Thu, 27 Oct 2022 08:13:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7DTI917EvjYSl/+/CFKpuBexgncqww6vNaf6TlZmMcRY8cGfo7sB5DTNwuEkoj9W4K6bEu X-Received: by 2002:a05:6402:2947:b0:451:32a:2222 with SMTP id ed7-20020a056402294700b00451032a2222mr45471768edb.376.1666883608482; Thu, 27 Oct 2022 08:13:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666883608; cv=none; d=google.com; s=arc-20160816; b=bKjavLfKWP/yHdjMmUptOJCeTZGM3tho8YK9jkWJBkZGSWrnPIE8bzbgl6irLGya/3 3guO6MLYR5Dbn/meFXZisa1cdjlQpXcceSfdZrug72UIE7d2jQFaZI4W2jGAWRmbQF0E +QZTtu52PzGSopA6P42UI/vtUiLDQqnWEKG0EI6PH74kPa9E7p9xLTija/frWuoVnodF bQ/vxKysTacJ4K+uXAwLLNi0w1Zr2tr38sTqbeFqcjxjeiXOR4rH9CAPWP/L3eSC+6GH KIU32ceeKa8vaNajp4eH+p+wEUtLkspBzHLf3wZ6QsuNymD1pwYY6Bn/6XMhRI0gb4AU MgMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=o+Qxlbpq7cXY84Ran2sV5m6w0zf1JZXvGBog8MgOtf4=; b=zTSW9BnLlLkYC3gvn79eMv8l0mndtQbcBwLiNw37jF12BYt5f95zqzfZLiqe0QgVuX ONgR+xFAqu84ovjwZUSxWNWrJiXLtsNhr0jnO/55anzDAr71Huu3of9p91oV5zBp7/Ql 7vGsQZSfnioLIi+rmkDNzaEe65Jw2J/+aQZdHC8HyHJWyG3KfXjEX4jAH+xJku3VRtpJ tQ8vdA58rVnTfRqv4TieV5Xq3d2lj++R9AnjzS75oagUvV7Eq10RN9lUIxTC+Dylvcoj qYIFrAhynOGLH8twsvEo1rUiPF+7RLcX17MJGexkSHhlN2sgvqgOoTyx7jAsk7tjRSmX IUsA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kl7-20020a170907994700b00783a0e64f8asi1284605ejc.246.2022.10.27.08.13.03; Thu, 27 Oct 2022 08:13:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236493AbiJ0PLT (ORCPT + 99 others); Thu, 27 Oct 2022 11:11:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56762 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236087AbiJ0PJS (ORCPT ); Thu, 27 Oct 2022 11:09:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C309D18F0D8; Thu, 27 Oct 2022 08:09:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3132623B9; Thu, 27 Oct 2022 15:09:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F4CCC43141; Thu, 27 Oct 2022 15:09:15 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oo4Ve-00BvhI-2D; Thu, 27 Oct 2022 11:09:30 -0400 Message-ID: <20221027150930.513327801@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 27 Oct 2022 11:05:53 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Ryusuke Konishi , linux-nilfs@vger.kernel.org Subject: [RFC][PATCH v2 28/31] timers: fs/nilfs2: Use del_timer_shutdown() before freeing timer References: <20221027150525.753064657@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747854146617464193?= X-GMAIL-MSGID: =?utf-8?q?1747854146617464193?= From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Ryusuke Konishi Cc: linux-nilfs@vger.kernel.org Signed-off-by: Steven Rostedt (Google) Acked-by: Ryusuke Konishi --- fs/nilfs2/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nilfs2/segment.c b/fs/nilfs2/segment.c index b4cebad21b48..1d3f89de1cd2 100644 --- a/fs/nilfs2/segment.c +++ b/fs/nilfs2/segment.c @@ -2752,7 +2752,7 @@ static void nilfs_segctor_destroy(struct nilfs_sc_info *sci) down_write(&nilfs->ns_segctor_sem); - del_timer_sync(&sci->sc_timer); + del_timer_shutdown(&sci->sc_timer); kfree(sci); }