From patchwork Thu Oct 27 15:05:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11846 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp288562wru; Thu, 27 Oct 2022 08:14:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5D1eWYwLd+vQqMo3biYNQX210oCmfm+8/1ZIni89haPf9h5d+E9taOjo0Oy+MYm0MqXwWU X-Received: by 2002:a17:907:7e87:b0:791:a477:1109 with SMTP id qb7-20020a1709077e8700b00791a4771109mr39404656ejc.354.1666883657386; Thu, 27 Oct 2022 08:14:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666883657; cv=none; d=google.com; s=arc-20160816; b=dtkDiEHplgE33msVWzsUclErWT/CeSHb8MMKVLCauUshgxTpTKMEyD0BxErhHXD2nF GlhsXHZO1QjLhPaaMWneelzQGdf2t7RiMlSHJgN7vmP3zKgPyt1jC8wwR06MYJwDIEVx +WZZh3kvHujDwCnqw4mER2nJpMD40HV2hTSKjCEUshkGSQBtzIrJPpVOJLbyEfIvZEM/ pj1e4mPESp4TJ+k51LDjOVrUDCFBsNGnJurU2fe+k0kHmISqwhOUYj0M683tJaeNhXX9 m7a9NDVTLYmYJiqrS/JWvy/87Aqxg9qQeHAEvZuboy0Q7y+2HR6DQFDOmK1OAZ6e4+WA mm7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=yCVp3WKmsW+m7Q5nR3e+rgwLsL1A1BuGiIiFpsBLjFc=; b=dyytPuCfwl/VJ+zodOwNYvWn3UTFR+RRvdMGCl8Sth3lEMKQyZeyuXuh9HGxRwdHaE +Ih3PX0qlGeQYR2ElczY9PdYixvx8S5f5llWK309AWLU53lip5lAL6oyOq+XnrtdIEBI LN9SvErV5FOjhr+qt2u8eS9t6/p9AgxDvxObLxQvH9x5mQ/yVwLzr7jZ/dc0fiLV//F8 wY1ukdVHoY8ECeouBe04GpvSJjb0A16geAXd8geNo5s4zSBwlwDavWRjbacfVu/0jqBO xWAiYPxjZ/LhI6PilkAPlQmvRr5+Kv1MGQKWUxdpFVVKQc+l8CsMXW89TCwToBq7tTyB rV7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y10-20020a056402358a00b00461cb980126si1926030edc.309.2022.10.27.08.13.53; Thu, 27 Oct 2022 08:14:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236503AbiJ0PLa (ORCPT + 99 others); Thu, 27 Oct 2022 11:11:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236125AbiJ0PJS (ORCPT ); Thu, 27 Oct 2022 11:09:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE29618F26D; Thu, 27 Oct 2022 08:09:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A8B8623BB; Thu, 27 Oct 2022 15:09:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 52D42C433B5; Thu, 27 Oct 2022 15:09:15 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oo4Ve-00Bvgj-1a; Thu, 27 Oct 2022 11:09:30 -0400 Message-ID: <20221027150930.322796357@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 27 Oct 2022 11:05:52 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , linux-ext4@vger.kernel.org Subject: [RFC][PATCH v2 27/31] timers: ext4: Use del_timer_shutdown() before freeing timer References: <20221027150525.753064657@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747854198172873912?= X-GMAIL-MSGID: =?utf-8?q?1747854198172873912?= From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc :"Theodore Ts'o" Cc :Andreas Dilger Cc: linux-ext4@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 989365b878a6..c8a59e3148e2 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -1225,7 +1225,7 @@ static void ext4_put_super(struct super_block *sb) } ext4_es_unregister_shrinker(sbi); - del_timer_sync(&sbi->s_err_report); + del_timer_shutdown(&sbi->s_err_report); ext4_release_system_zone(sb); ext4_mb_release(sb); ext4_ext_release(sb);