| Message ID | 20221027150929.370900127@goodmis.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp287309wru;
Thu, 27 Oct 2022 08:12:10 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM6hZzxObhgS2Rop+7oon3sjuoHorQYoq7/rOt/MjTfJao9EzK64AxRTSwLy2k4ZAytqxsml
X-Received: by 2002:a17:907:75d0:b0:7ad:8a7a:1a53 with SMTP id
jl16-20020a17090775d000b007ad8a7a1a53mr4319332ejc.47.1666883530636;
Thu, 27 Oct 2022 08:12:10 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666883530; cv=none;
d=google.com; s=arc-20160816;
b=mCKOfBaPPGMyRbSI8WH3saBDQOm+yuild76lXoNyPpHaVlCbpHhpU4CRH6NNGtusyA
CQUphUu2193jXfanjlKovnucQZ8E3xRu3XVbLAnmEiBBhPWSx1AEW/tWCyo/2zoMUjZ9
W2zbESulk84qJNC+vqz52nowXsDRsjOMCLmrsjNjp8HY7odaXJuppmIQvsv/LqvHqTEw
yxFN/+FZqpmnCNkdogvIDpPIg3psDK27nTczXuwYcAdlB9mujFKHLQCghfZMGWZqMcwi
rd7KtYBoVD6oVPfReKGQ7cao6AWv92RnLGKyOpqn6uvasJDo0EjlwRWjQeveqKPXKo7a
tJdg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:references:subject:cc:to:from:date
:user-agent:message-id;
bh=YTpRKrfVjguSQrLrMHNcSNQDiq8JMXCyBd+cVGuxVUg=;
b=DPzIRe18HQf08UPezltVCe6RCNliOoLRvD+5PYbqnGHnXvHKRnb4FgE35fmfXQ68U1
y0U5DTrZi+QPHBVdFjtikUnZhi0hci6abbl3BLqH+sI0AUmj7Tsq+csAXzdfiBIpuDHK
xefweaVlMzL1p62ARnfRAI38up874fHApMUfOPNnFATWB4gwjyPJNiIjE3gk1CFEzbDo
+zX9sHUKPl3NGwq5Jz6+Vl+s6gXf7RuQNGpr5fAvmTLBZnRSI58GHaO0+wpuZABe/fwv
SYPHJVF3MsvMOr+UrHJJq2c2hzW/xnrgboMjkoRPosFMGVzH9fK5wSjh2mr3+fkNBVew
ROJg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
z25-20020a50cd19000000b00459cf784343si1581717edi.176.2022.10.27.08.11.46;
Thu, 27 Oct 2022 08:12:10 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S236452AbiJ0PKs (ORCPT <rfc822;chrisfriedt@gmail.com>
+ 99 others); Thu, 27 Oct 2022 11:10:48 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56756 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S236070AbiJ0PJR (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 27 Oct 2022 11:09:17 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 952F318F90B
for <linux-kernel@vger.kernel.org>;
Thu, 27 Oct 2022 08:09:14 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
(No client certificate requested)
by dfw.source.kernel.org (Postfix) with ESMTPS id 758FA623A3
for <linux-kernel@vger.kernel.org>;
Thu, 27 Oct 2022 15:09:14 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50A2CC4314D;
Thu, 27 Oct 2022 15:09:14 +0000 (UTC)
Received: from rostedt by gandalf.local.home with local (Exim 4.96)
(envelope-from <rostedt@goodmis.org>)
id 1oo4Vd-00Bvdu-1k;
Thu, 27 Oct 2022 11:09:29 -0400
Message-ID: <20221027150929.370900127@goodmis.org>
User-Agent: quilt/0.66
Date: Thu, 27 Oct 2022 11:05:47 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
Guenter Roeck <linux@roeck-us.net>, Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: [RFC][PATCH v2 22/31] timers: workqueue: Use del_timer_shutdown()
before freeing timer
References: <20221027150525.753064657@goodmis.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,
HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747854064708609547?=
X-GMAIL-MSGID: =?utf-8?q?1747854064708609547?=
|
| Series |
timers: Use del_timer_shutdown() before freeing timers
|
|
Commit Message
Steven Rostedt
Oct. 27, 2022, 3:05 p.m. UTC
From: "Steven Rostedt (Google)" <rostedt@goodmis.org> Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Tejun Heo <tj@kernel.org> Cc: Lai Jiangshan <jiangshanlai@gmail.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org> --- kernel/workqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 7cd5f5e7e0a1..47a7124bbea4 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -3608,8 +3608,8 @@ static void put_unbound_pool(struct worker_pool *pool) wait_for_completion(pool->detach_completion); /* shut down the timers */ - del_timer_sync(&pool->idle_timer); - del_timer_sync(&pool->mayday_timer); + del_timer_shutdown(&pool->idle_timer); + del_timer_shutdown(&pool->mayday_timer); /* RCU protected to allow dereferences from get_work_pool() */ call_rcu(&pool->rcu, rcu_free_pool);