From patchwork Thu Oct 27 15:05:28 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11830 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp286745wru; Thu, 27 Oct 2022 08:11:14 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7BqCpjeI3bGev3vA6iYevZtWfn8O1cCg2A5b53sYm3XMXqmQa9Xb0h6PUDi4zvCZIiJ4ZX X-Received: by 2002:a05:6402:1e96:b0:462:89aa:d402 with SMTP id f22-20020a0564021e9600b0046289aad402mr4423300edf.190.1666883474028; Thu, 27 Oct 2022 08:11:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666883474; cv=none; d=google.com; s=arc-20160816; b=E7fQM6NrBhNe8Kah8hvU9HzO/MNyMl+NaBIQRUphyjd8U83vQb++bmu/bZEAgx487z wQm9RQF4LiB/QdtoXmdRVWt+GTPzOzIuWdjHhzFqh5Cm42fryACkTUqV0EpKvMlZswEj oUu1SnzBAhuVNVfOpAbXskoK/ep/WG+RRp+YeP1BdCi1rxlBBwYlkHE1lCVJWDglhTfi mfdt4hBDIrP8yDhXLSeu/7Y6QDSBpd5Ngf9LzUwsf3svF0DOx2FX5UN1P+jKOef36pBx n9SyvlwCY8TXuQ9/QPHCwQ4EeZphcCEKkVgIP/oktEq7Efo9NDAUv1hhi07m+DtIImv/ +4KQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=IHWpHvpG+/xuPTQ5K5O6XRoCSb+Tn+Nw6LyiyfTXnjo=; b=cXtd5rW1Dkllt+kIEvkEkbIikTd4Eg20Lj/k0jT0+T4vyaTH0+8EjQDuRsDO/D61Fd zEEuMilu/45oHqDmDZ4zsQUTFV6Ya4Z6YNSmkCqmLt/8VmQk5UTAY3PUI5LXuNqCEmf4 cqWC2EGUEs6yGDMmNhveYmJmAfBWMbMFkdbmLIF4k5nizI1QLpFbTLWUC1ElKBF2gB9R vDPtDlqoc793m23vXO/alRCgRG2mKL1c4CAI9VUi0zrWxnotzfTurSiQDVYqEpHIGvd8 4csWef2RhIReSYU6p0fVMmzJ155aYE0NcaRRmKYpzlNIVKDZMgA0Eoe4lDMYVXZhMEkw +DQQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l9-20020a170906794900b0079b8cce1170si1670824ejo.950.2022.10.27.08.10.50; Thu, 27 Oct 2022 08:11:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236376AbiJ0PKQ (ORCPT + 99 others); Thu, 27 Oct 2022 11:10:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56788 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236236AbiJ0PJN (ORCPT ); Thu, 27 Oct 2022 11:09:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF58A18F0D8; Thu, 27 Oct 2022 08:09:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45A8762398; Thu, 27 Oct 2022 15:09:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA016C43144; Thu, 27 Oct 2022 15:09:10 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oo4VZ-00BvTD-2a; Thu, 27 Oct 2022 11:09:25 -0400 Message-ID: <20221027150925.638910550@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 27 Oct 2022 11:05:28 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Yoshinori Sato , Rich Felker , linux-sh@vger.kernel.org Subject: [RFC][PATCH v2 03/31] timers: sh: Use del_timer_shutdown() before freeing timer References: <20221027150525.753064657@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747854005575858073?= X-GMAIL-MSGID: =?utf-8?q?1747854005575858073?= From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Yoshinori Sato Cc: Rich Felker Cc: linux-sh@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- arch/sh/drivers/push-switch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/sh/drivers/push-switch.c b/arch/sh/drivers/push-switch.c index 2813140fd92b..2ebdd604f6d0 100644 --- a/arch/sh/drivers/push-switch.c +++ b/arch/sh/drivers/push-switch.c @@ -102,7 +102,7 @@ static int switch_drv_remove(struct platform_device *pdev) platform_set_drvdata(pdev, NULL); flush_work(&psw->work); - del_timer_sync(&psw->debounce); + del_timer_shutdown(&psw->debounce); free_irq(irq, pdev); kfree(psw);