From patchwork Thu Oct 27 15:05:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 11823 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp286384wru; Thu, 27 Oct 2022 08:10:44 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cTqcHVg2L7qJBKN/hjRd/2Fz2jRwUK+hY0EOvvsvu8a9/9AUVjDM3CWaBu4DcsLDKSsJC X-Received: by 2002:a05:6402:27cf:b0:462:75b3:a277 with SMTP id c15-20020a05640227cf00b0046275b3a277mr6779621ede.175.1666883443956; Thu, 27 Oct 2022 08:10:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666883443; cv=none; d=google.com; s=arc-20160816; b=zm/mRgJEguyQ6jZvY1hA87Y/kUAPwuO36jqYzDuIkRRdhfQF/nBPCByyMevS7Gqdga AbfZ0jd/CHvH5ARS9xNF73bYU3H8/x7mQEZJWPFMVOlVYtHrsu1/5zo5VTpyeXWUKF9I qu2fEeRkmxGGU4XCU4/Xr3JUMYjlBm3TfcxxLdzSXYAPA4WTc8kVwBlGkWhi1D1gL47A Osu/mIPS5D/j7IhTCk5YTPPVgOzdIByj8ShY34G53IfyhxhYC2QLfg9bNQo44aqwGsi8 GKUaCKeaOEeD6b10M4QdBXA5J34geo5oDEZAZrcNEdaIKECJNfs+xs63CWNsUn4aN1+R 41TA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=UAzCjtm/QYTuntMuyzQWU4Xdx4DO1uFin2OZwI9Og9U=; b=JEFXa7j/BP1QlUqe9lWAn8/UINo3NE7WYzP4W8nmr0xJNivyi0mQRqfi99tVKTsCB4 z2tcsRelf1qKWnM2VFGjz5bIEb6QhZhavabE5vKk1WXjWFg5t29oK3NaOSJqrQEVC6BP zAw6+PiCXcsvrh4dZAaSSgsOGxQ3+vTzOTpN7rC/HsxFP/Wo0gb1Hv3FabSHBk4O0xyt +Jt2zk+JX5KQDhMfCXEf9Ltz8wLwg4nBsVyF7xt4yxqYKSqptRIzFW+pxPLWr+jcPOs3 t5idbHSY+oLKHrpHdQY4XdGQaufY6T7jcZ3Vc6d5Km6EdZ/+IcFOTdYev1PAj5hl/Kt2 zLjg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd33-20020a17090762a100b0078dc7f7d0ebsi1961038ejc.822.2022.10.27.08.10.20; Thu, 27 Oct 2022 08:10:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236313AbiJ0PJo (ORCPT + 99 others); Thu, 27 Oct 2022 11:09:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236235AbiJ0PJN (ORCPT ); Thu, 27 Oct 2022 11:09:13 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7C32518F0CF; Thu, 27 Oct 2022 08:09:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14CED62395; Thu, 27 Oct 2022 15:09:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74AFEC43470; Thu, 27 Oct 2022 15:09:10 +0000 (UTC) Received: from rostedt by gandalf.local.home with local (Exim 4.96) (envelope-from ) id 1oo4VZ-00BvSf-1y; Thu, 27 Oct 2022 11:09:25 -0400 Message-ID: <20221027150925.435425818@goodmis.org> User-Agent: quilt/0.66 Date: Thu, 27 Oct 2022 11:05:27 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Linus Torvalds , Thomas Gleixner , Stephen Boyd , Guenter Roeck , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , linux-s390@vger.kernel.org Subject: [RFC][PATCH v2 02/31] timers: s390/cmm: Use del_timer_shutdown() before freeing timer References: <20221027150525.753064657@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747853974066356578?= X-GMAIL-MSGID: =?utf-8?q?1747853974066356578?= From: "Steven Rostedt (Google)" Before a timer is freed, del_timer_shutdown() must be called. Link: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home/ Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Alexander Gordeev Cc: Christian Borntraeger Cc: Sven Schnelle Cc: linux-s390@vger.kernel.org Signed-off-by: Steven Rostedt (Google) --- arch/s390/mm/cmm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/s390/mm/cmm.c b/arch/s390/mm/cmm.c index 9141ed4c52e9..6ade449343d2 100644 --- a/arch/s390/mm/cmm.c +++ b/arch/s390/mm/cmm.c @@ -419,7 +419,7 @@ static int __init cmm_init(void) #endif unregister_sysctl_table(cmm_sysctl_header); out_sysctl: - del_timer_sync(&cmm_timer); + del_timer_shutdown(&cmm_timer); return rc; } module_init(cmm_init); @@ -432,7 +432,7 @@ static void __exit cmm_exit(void) #endif unregister_oom_notifier(&cmm_oom_nb); kthread_stop(cmm_thread_ptr); - del_timer_sync(&cmm_timer); + del_timer_shutdown(&cmm_timer); cmm_free_pages(cmm_pages, &cmm_pages, &cmm_page_list); cmm_free_pages(cmm_timed_pages, &cmm_timed_pages, &cmm_timed_page_list); }