[-next] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m
Message ID | 20221027095904.3388959-1-zhengbin13@huawei.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp131347wru; Thu, 27 Oct 2022 02:45:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6qjnQ+01solq6gOWjzoIkBcVvHDosbBe5OE6qM8aqDpghcsc29bXnBTj745AZJop0hqFjl X-Received: by 2002:a05:6402:f24:b0:461:7c77:98c4 with SMTP id i36-20020a0564020f2400b004617c7798c4mr24372107eda.80.1666863950741; Thu, 27 Oct 2022 02:45:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666863950; cv=none; d=google.com; s=arc-20160816; b=n3iRgz9zyCloHffqZc4JJqEfTvYMZcr7z1n4qLTiOltHP75HwLZ0gBNYDDPRuA4X+q yaQb7xycGrx4Y7MGZdcD32vl/Ll1O3fUD7Pt16mJsgrqr/RGqcSBAhoT1gIQiWTkfjsC H1wzR0677n935gQ99ot9YwE71b7JXTQ+IgxHy76fBY+xd8qTLg1KsmapIgh7ZTP1O1mn +fBNoG9XuO11yEoovTkIbzPCuo2KetkUq3cLon6Ew47fHGrrXN0k3GH9o77Cr4XiQyEF uAPKpyuYcEZJ03KzUXCPLXeVZHF+Witsbj1hh9yXSNR9dTZhvSVc3dn3WxuwmmrMEHZH TABg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=JJyVivVme4qZn/Xofv9bK/yCij67c3TrVpjvKmMCZCM=; b=UMy6NpDB0t1mNtX+o3bX/DBRoSujcdrcSkDiwiw97l+dFzKMy+LpuTnEPpYNmc/H/0 II8CHXXpWrlQew5XIG/vH6QLXNK7Mvu+m4TCdqD237+xJnR+nWkOlFeZ5a7W12Z5pW/z +zwk3GVTqqAI+2D6foWYMsx7Ha28zwL8BPuSa6MHHik8qMrP2kC5Z51PQSBjEA35Kyxx khSlI801VulZUTATjT/1zOH1ywy6kwLP6PqSbK5CmmTK3RLNc3gVe+OqJeDRQEZzQyfR CtxDN9AAK2fq0in2k9XkvQl361gie/f/5FfJQFzWPwOyLAHep0V7VS6f2sRjA17QQxju Rr1Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w7-20020a50d787000000b004617c3c9297si1191501edi.252.2022.10.27.02.45.21; Thu, 27 Oct 2022 02:45:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233804AbiJ0JhV (ORCPT <rfc822;chrisfriedt@gmail.com> + 99 others); Thu, 27 Oct 2022 05:37:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233264AbiJ0JhR (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 27 Oct 2022 05:37:17 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B0BF73C0D for <linux-kernel@vger.kernel.org>; Thu, 27 Oct 2022 02:37:16 -0700 (PDT) Received: from kwepemi500015.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4MygV15FsgzpW54; Thu, 27 Oct 2022 17:33:45 +0800 (CST) Received: from huawei.com (10.175.127.227) by kwepemi500015.china.huawei.com (7.221.188.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 27 Oct 2022 17:37:11 +0800 From: Zheng Bin <zhengbin13@huawei.com> To: <srinivas.kandagatla@linaro.org>, <gregkh@linuxfoundation.org>, <krzysztof.kozlowski@linaro.org>, <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org> CC: <zhengbin13@huawei.com> Subject: [PATCH -next] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m Date: Thu, 27 Oct 2022 17:59:04 +0800 Message-ID: <20221027095904.3388959-1-zhengbin13@huawei.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.127.227] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To kwepemi500015.china.huawei.com (7.221.188.92) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747833533953857079?= X-GMAIL-MSGID: =?utf-8?q?1747833533953857079?= |
Series |
[-next] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m
|
|
Commit Message
Zheng Bin
Oct. 27, 2022, 9:59 a.m. UTC
If CONFIG_SLIM_QCOM_NGD_CTRL=y, CONFIG_QCOM_RPROC_COMMON=m, COMPILE_TEST=y,
bulding fails:
drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_ctrl_probe':
qcom-ngd-ctrl.c:(.text+0x330): undefined reference to `qcom_register_ssr_notifier'
qcom-ngd-ctrl.c:(.text+0x5fc): undefined reference to `qcom_unregister_ssr_notifier'
drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_remove':
qcom-ngd-ctrl.c:(.text+0x90c): undefined reference to `qcom_unregister_ssr_notifier'
Make SLIM_QCOM_NGD_CTRL depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) to fix this.
Fixes: e291691c6977 ("slimbus: qcom-ngd-ctrl: allow compile testing without QCOM_RPROC_COMMON")
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/slimbus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.31.1
Comments
On 27/10/2022 05:59, Zheng Bin wrote: > If CONFIG_SLIM_QCOM_NGD_CTRL=y, CONFIG_QCOM_RPROC_COMMON=m, COMPILE_TEST=y, > bulding fails: > > drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_ctrl_probe': > qcom-ngd-ctrl.c:(.text+0x330): undefined reference to `qcom_register_ssr_notifier' > qcom-ngd-ctrl.c:(.text+0x5fc): undefined reference to `qcom_unregister_ssr_notifier' > drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_remove': > qcom-ngd-ctrl.c:(.text+0x90c): undefined reference to `qcom_unregister_ssr_notifier' > > Make SLIM_QCOM_NGD_CTRL depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) to fix this. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 27/10/2022 10:59, Zheng Bin wrote: > If CONFIG_SLIM_QCOM_NGD_CTRL=y, CONFIG_QCOM_RPROC_COMMON=m, COMPILE_TEST=y, > bulding fails: > > drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_ctrl_probe': > qcom-ngd-ctrl.c:(.text+0x330): undefined reference to `qcom_register_ssr_notifier' > qcom-ngd-ctrl.c:(.text+0x5fc): undefined reference to `qcom_unregister_ssr_notifier' > drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_remove': > qcom-ngd-ctrl.c:(.text+0x90c): undefined reference to `qcom_unregister_ssr_notifier' > > Make SLIM_QCOM_NGD_CTRL depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) to fix this. > > Fixes: e291691c6977 ("slimbus: qcom-ngd-ctrl: allow compile testing without QCOM_RPROC_COMMON") > Signed-off-by: Zheng Bin <zhengbin13@huawei.com> > --- Applied thanks, --srini > drivers/slimbus/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig > index 2ed821f75816..a0fdf9d792cb 100644 > --- a/drivers/slimbus/Kconfig > +++ b/drivers/slimbus/Kconfig > @@ -23,7 +23,7 @@ config SLIM_QCOM_CTRL > config SLIM_QCOM_NGD_CTRL > tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" > depends on HAS_IOMEM && DMA_ENGINE && NET > - depends on QCOM_RPROC_COMMON || COMPILE_TEST > + depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) > depends on ARCH_QCOM || COMPILE_TEST > select QCOM_QMI_HELPERS > select QCOM_PDR_HELPERS > -- > 2.31.1 >
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig index 2ed821f75816..a0fdf9d792cb 100644 --- a/drivers/slimbus/Kconfig +++ b/drivers/slimbus/Kconfig @@ -23,7 +23,7 @@ config SLIM_QCOM_CTRL config SLIM_QCOM_NGD_CTRL tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component" depends on HAS_IOMEM && DMA_ENGINE && NET - depends on QCOM_RPROC_COMMON || COMPILE_TEST + depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) depends on ARCH_QCOM || COMPILE_TEST select QCOM_QMI_HELPERS select QCOM_PDR_HELPERS