From patchwork Thu Oct 27 09:10:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 11681 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp119494wru; Thu, 27 Oct 2022 02:12:08 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5jdzbcWOYLnI+hhA/bLmyoikEP1MazmxA4iwNQqt/4q7kml2N7W0UVPir8+pOcwV01ThEe X-Received: by 2002:a17:907:86a2:b0:791:910e:cce4 with SMTP id qa34-20020a17090786a200b00791910ecce4mr41893595ejc.36.1666861928272; Thu, 27 Oct 2022 02:12:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666861928; cv=none; d=google.com; s=arc-20160816; b=cxFbv8yFQOPtDXSqecvdQG2tAnKHtkOaUwYuva+FbCEgOaUWrDfCdZYdnJnjyhA7jU OJGaiXuYOWTa9+g7UZffJ7Bs7qYtleTAzDd9xXUJIyiOWFvVdFI6F4w1QUyyrhW/SL1J GU45cEiImJJ2SbyXIHj56IfcpwIrz0Ya3jbdX2o/oGXFS2ja4BCnXfSGsGcVCxF8U8Y1 A7qFOvr/er+ArHpi4hp6e376be9RdDM5SP7vWuYZNIHKaJmd/VGMNNIg5nSPzr42M+Jj Hp2Aeqze/E47M0pQPSFkYymzClsbT4WCo7qW3xbLgM2s0+py2x2DRfMTzTQiQlZ0fyCT hkMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Z+ZfLQRhteRlGO5hhQ+05hYACPHsGkW3e97obsmk4KM=; b=QeQCb6DcVZP4XaK240xbSY5geHSncOu6xMvs0gRPMHexslnTk8c2hI8Y6zE0BLBjMr FCYzuHxhuBRwaR13AEaVHNJsUStloZLE+w9wvSS1jJR1xJgcok0n1lz3hs1nEC8zLwkD xyIFzP+GPphRcCEDJ4MKHYsk3cGfoNtzrtb3ArAz6ylV/E1prEBtqnto4jy2suD/6ltf +BfyJgNT+bj9A2KqVR2UWHK5/EvucZ6wWul230nmVQCn4879sw1MQIpJc8zarGCK5rwL 6YcbCvhtivdl7ri1z+UefWbj0WWLZ0cRPrAuf6Ds09BYmGSct8WET1NxSVVDG6D2L169 g1Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i7kFKr8y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp14-20020a1709071b0e00b007317ad1f9a4si955089ejc.310.2022.10.27.02.11.41; Thu, 27 Oct 2022 02:12:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=i7kFKr8y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235273AbiJ0JLN (ORCPT + 99 others); Thu, 27 Oct 2022 05:11:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235196AbiJ0JK3 (ORCPT ); Thu, 27 Oct 2022 05:10:29 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1463214005 for ; Thu, 27 Oct 2022 02:10:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9E3A0B8255C for ; Thu, 27 Oct 2022 09:10:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FB84C433D6; Thu, 27 Oct 2022 09:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666861823; bh=Sh+BmeRGZOX5XGeQBr+NcaVn9R2vZH1mrSUpX2DxTCg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=i7kFKr8yqIN8HQUEeg89SJw+uqYK4JRiEOoF8dBqPVF4/ye6zdF7nPWtIGhtwoZdG jssP1Pz/cpz4+jE9l9FT+jQaYOZefLFDofZMU79Qru56sPuMWqcyhsSWo1nK9Jt8Kb 2oLMJJ3PIlAS3FC3aJGBlUkj4PVnVc/0C1/WV1iTWo0eksYu9iexK2tKxGyJZL5EFc UzAUCgm2fiW+Dnf84PeNwHhjlysWDj6Jp6oJPz9qLCqIl4hpEezj/PuUXJ9I0tgzyE HsOX7rkj5LR+4iEGc4YmgbpK/StfKJniTcsNz+xZhn+flN2rfGQME/XFkNEAfKeI2t jRfIuvgmlkRXA== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Tomer Tayar Subject: [PATCH 08/15] habanalabs/gaudi: use graceful hard reset for F/W events Date: Thu, 27 Oct 2022 12:10:00 +0300 Message-Id: <20221027091007.664797-8-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221027091007.664797-1-ogabbay@kernel.org> References: <20221027091007.664797-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747831413312894496?= X-GMAIL-MSGID: =?utf-8?q?1747831413312894496?= From: Tomer Tayar Use graceful hard reset for F/W events on Gaudi device that require a device reset. Signed-off-by: Tomer Tayar Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/gaudi/gaudi.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c b/drivers/misc/habanalabs/gaudi/gaudi.c index 337123f73501..3dfb9ecf7db3 100644 --- a/drivers/misc/habanalabs/gaudi/gaudi.c +++ b/drivers/misc/habanalabs/gaudi/gaudi.c @@ -7942,16 +7942,14 @@ static void gaudi_handle_eqe(struct hl_device *hdev, struct hl_eq_entry *eq_entr reset_required = false; } - /* despite reset doesn't execute. a notification on - * occurred event needs to be sent here - */ - if (event_mask) - hl_notifier_event_send_all(hdev, event_mask); - - if (reset_required) - hl_device_reset(hdev, flags); - else + if (reset_required) { + hl_device_cond_reset(hdev, flags, event_mask); + } else { hl_fw_unmask_irq(hdev, event_type); + /* Notification on occurred event needs to be sent although reset is not executed */ + if (event_mask) + hl_notifier_event_send_all(hdev, event_mask); + } } static void *gaudi_get_events_stat(struct hl_device *hdev, bool aggregate, u32 *size)