From patchwork Thu Oct 27 09:10:06 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oded Gabbay X-Patchwork-Id: 11688 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp120088wru; Thu, 27 Oct 2022 02:13:25 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4o6xL6BMDggp1iWQk4Vfp4g98St4XosEgMeAfm7vAJGIaEI8tLmXW3YZca0aeXPsarJcB/ X-Received: by 2002:a17:906:ee88:b0:78d:1a9a:b2db with SMTP id wt8-20020a170906ee8800b0078d1a9ab2dbmr40957072ejb.225.1666862005509; Thu, 27 Oct 2022 02:13:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666862005; cv=none; d=google.com; s=arc-20160816; b=aFhLkaL8Jk8qWPTtgfIoKztxy/AebgguIZqpO/36bolnqlkglP73L83iBWzSgN4XJz Z2OaHxsSnE+L8QRmjQAiiWoQ5rC/ijXUQM1TxAu2yoqX3cJJ7ZZXxNRrNCNdL1gL39Kc VMpmLQYclOtwUWUsKNeTJr8iNRPYp/+hTymNa5pEvchK4I27rtWh7k7B5uPM9Sut1/hC fg+2p1a10tLXNtQSz07Nfj2G5naXdBfevZvxQGdI5p1AtlD2Njgg5adScuI7DcAQltn+ yNCon0PC0WM8WKls2TV68dHtLGJdQV69kzkpUJieTC/amrUWD57AUIS1tcgFibWRFRSz hHuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=UuQKpEPllZvyYEN2X9IZ3uqTml23AUl59aRf3wp12Po=; b=ymZWTl4wd3VMZ6hLCnqw45tXJOZ4+yJG0fN3xwJTNkvwAbKGfnNfJL5HeodZHTgKQU xYMk5bKKRMqdZbX8dIU6Muu+VnrA6IG2kFu2SuGhafJWhvlIhw0NPM1iX0GsaBw8nUHq axB/q4qScvSe1l9YuxsZziVZ/jb/aULZX2ubXqiPSqf9oL7u+TFtI3GmlGMfezOEWGzb Je1+HBerHBraioVCcfQ1iJ40D7F2cruNFnKoqgblOWH7UrbLLFP25d4nl4wwyw/T8IDR peFcsKnBynwfmvUtxTUrLS4k6cthK4PJMH39Rqn/cVkMbypsGjVqbc1eD4Wc8Kk0PKa1 yMVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PjxkOKjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a50eb42000000b00461606e36dbsi1044635edp.131.2022.10.27.02.13.01; Thu, 27 Oct 2022 02:13:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=PjxkOKjA; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235282AbiJ0JLt (ORCPT + 99 others); Thu, 27 Oct 2022 05:11:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40112 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235236AbiJ0JKf (ORCPT ); Thu, 27 Oct 2022 05:10:35 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B9DCF255BC for ; Thu, 27 Oct 2022 02:10:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 03A7C62240 for ; Thu, 27 Oct 2022 09:10:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9116EC433D7; Thu, 27 Oct 2022 09:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666861831; bh=rIk8jKMhlIFhlHw+rsEUWOL8K4fslKFxTHy3uNVL2tM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PjxkOKjA5XjTMmA9rsknmXP6ASpUDfMeFE4VgVatFfrAI1qAWJitNU/+3bF3ArxOv MRZipNFgM0UtyrRPOcaQ35ZCfNg3kJWhuv9SrBZCUnTD939gc+JlT7Ha6MxlT1QDtR Gux0kogyG0pvWTsLPfSXmWfdA762mazs6klbLG+YxVG6F0Xi6va9rDSOcKkOBaCiaG iMlOW3gV7IcJD46ciJ9iB+hMO4M/9QGb5osyRI6ucfPNSmRAKA3jkFTQSbogFGm2Bx iSKnm2Mt+3avDc5kvfIbDDDumtKUWtQGjyEPIk5KRvAd1HD6HfoOouGIwm/CsDcvIW zGFUh3MLkM8Zg== From: Oded Gabbay To: linux-kernel@vger.kernel.org Cc: Ofir Bitton Subject: [PATCH 14/15] habanalabs: add warning print upon a PCI error Date: Thu, 27 Oct 2022 12:10:06 +0300 Message-Id: <20221027091007.664797-14-ogabbay@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221027091007.664797-1-ogabbay@kernel.org> References: <20221027091007.664797-1-ogabbay@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747831494390461906?= X-GMAIL-MSGID: =?utf-8?q?1747831494390461906?= From: Ofir Bitton In order to know if driver catches PCI errors correctly, we need to print a warning per each error. Signed-off-by: Ofir Bitton Reviewed-by: Oded Gabbay Signed-off-by: Oded Gabbay --- drivers/misc/habanalabs/common/habanalabs_drv.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/misc/habanalabs/common/habanalabs_drv.c b/drivers/misc/habanalabs/common/habanalabs_drv.c index 714994725224..e82af8989700 100644 --- a/drivers/misc/habanalabs/common/habanalabs_drv.c +++ b/drivers/misc/habanalabs/common/habanalabs_drv.c @@ -595,15 +595,16 @@ hl_pci_err_detected(struct pci_dev *pdev, pci_channel_state_t state) switch (state) { case pci_channel_io_normal: + dev_warn(hdev->dev, "PCI normal state error detected\n"); return PCI_ERS_RESULT_CAN_RECOVER; case pci_channel_io_frozen: - dev_warn(hdev->dev, "frozen state error detected\n"); + dev_warn(hdev->dev, "PCI frozen state error detected\n"); result = PCI_ERS_RESULT_NEED_RESET; break; case pci_channel_io_perm_failure: - dev_warn(hdev->dev, "failure state error detected\n"); + dev_warn(hdev->dev, "PCI failure state error detected\n"); result = PCI_ERS_RESULT_DISCONNECT; break; @@ -639,6 +640,10 @@ static void hl_pci_err_resume(struct pci_dev *pdev) */ static pci_ers_result_t hl_pci_err_slot_reset(struct pci_dev *pdev) { + struct hl_device *hdev = pci_get_drvdata(pdev); + + dev_warn(hdev->dev, "PCI slot reset detected\n"); + return PCI_ERS_RESULT_RECOVERED; }