From patchwork Thu Oct 27 08:22:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nicolas Dumazet X-Patchwork-Id: 11643 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp103704wru; Thu, 27 Oct 2022 01:30:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7XVVyUiowinpfw9Zk291TcHx7HUK4zplwchpGY8QqUHpA/OMjDAeBCj1f6pkQvBtEZDfAN X-Received: by 2002:a17:907:9495:b0:78e:1bee:5919 with SMTP id dm21-20020a170907949500b0078e1bee5919mr40639969ejc.701.1666859449223; Thu, 27 Oct 2022 01:30:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666859449; cv=none; d=google.com; s=arc-20160816; b=I3pAfc9fz6iOjqIQp78lhHckX2Mpzhesx2nSuXCR2KZaV2tP/+T7SCmD1NsAWrLnck tpP9h2InMFjXtbTc5YPEoOpSi5iefDD1Cg/6jK9RVUoXs1Yfypj82nojJfBxxJh0oGJy Lur54B8ukXIN/LUiLXEZThArWiyI+0cieQ+dAw3B0BUwBnGvIHmhxFohTAHJHPhWN0m6 oecM6ILI1DggbL/QE0Qeritr5oKjs5TEYrrqF+HtQwV7boMsKDQa0kgNcuNy4HbY9fhw hEIggd4yjezv1+huH9ps5kYcCFypAAa0vBr+z5YCocKTw9YQLABnApoG9Kz8DK+xTW9p ySlw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=ensG1aiR3XdykM/MMnZ7AX9t3z19jrp54YzAQQKGlWM=; b=em2TcZhl1Ip2MDR0b1znJ0m9Hsuls+ywzngCYFvfzIFffu2MqnRoZTdqp7nUTGIPYb cxXWk/g1o/R4gMIMgq02LmjRuEUFfcThZPKcAkDZ/KDLPh9T/pJpvZ6QY27KAN9VZxbX C9Vq9Gf48xkIWa4ajbZeLSquJRgVHL2AkFpSV5gpg3Xpc1RgqeuGkFyvwVEUYoBYh1iV qFo1hPt8mG5w+zodIhk1TOfRjiQkKggP9XI4BCydNHh6RjdJeUrqXzyfvc1vx7a4ad+U AywSm9RBCPWWn7CpkUh9ecRwYfSrM/UhGgNmtXowmX9uVtEhxKLZwftLrLN/X35VuyL6 b/kA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=lnpIL7Vs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l5-20020a1709062a8500b007acef3bec44si302237eje.221.2022.10.27.01.30.24; Thu, 27 Oct 2022 01:30:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=lnpIL7Vs; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234912AbiJ0IWW (ORCPT + 99 others); Thu, 27 Oct 2022 04:22:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234333AbiJ0IWS (ORCPT ); Thu, 27 Oct 2022 04:22:18 -0400 Received: from mail-wr1-x449.google.com (mail-wr1-x449.google.com [IPv6:2a00:1450:4864:20::449]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A9526110A for ; Thu, 27 Oct 2022 01:22:16 -0700 (PDT) Received: by mail-wr1-x449.google.com with SMTP id i14-20020adfa50e000000b0023652707418so140989wrb.20 for ; Thu, 27 Oct 2022 01:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=ensG1aiR3XdykM/MMnZ7AX9t3z19jrp54YzAQQKGlWM=; b=lnpIL7VslzlRJbzuderEmAOsPoRXbiibZv66kEBy6IhZrZnfE4fJZw1iR8b+G0q0jt AN5Td/lm7nMnmKdkFYxxNEQIGYnRAw+CaR1K6iWLCLJ11S9wFfIr48yn39iAA4q0LYPp 61dufNxAmKmCd7RZs6WHICF2YKxtKYF7nMeJfzaynKa7lcj0shP4ywxSTVRlPReQ2ZKX ft6PeNfB/TlQmw5nTgPmiCrBjAdG6uCiiHQOdd62K8Ii/XQGakNz/ego93Vcvl2KPXGh gic4GRNaIDW+Qj70Xt9wRwvBbdmcFn2ulfg5icj+izOpf+lhPTVGsdue8UNsRn+cbLa3 hVbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=ensG1aiR3XdykM/MMnZ7AX9t3z19jrp54YzAQQKGlWM=; b=GmkO8wnOP9lgklXhccjcydZwP4l5/mNkFpHhaG8fdf6atEl+MhYO2M4lr7YTaaijm/ xxuVv8SNLEn/9aj+DtB2ohvHFyqkvAlKXOhAJYRVaNixCupvNdudlqtNTXaamYCVFvFh i5u/FGwxnYkofb4FsEWb2deGPmby0XNvUMiKkvbt9Q9Ud0T3lknXXFPTrplXROHwXIKS s3L9OLvVA/BeAPeux3Uj7x9hI3JIXSXPlKSJTAVIancQh9mEXvr0L8Mmq1YPFW2h1LaQ 8Oaj09F/0DE6cZs0MypEcIPyjrprh1hGph86yuyxFVVU/2qvLyUKj/yiRhFXFEuBnpN8 wUIg== X-Gm-Message-State: ACrzQf10nZU/QihjgOo1GQyX9F2qMZiG6E7T6fYJ1u1c7+18rhssQZCW VRdj2rsFiX1b13jt21gTGlQni9ey+wEbkA== X-Received: from bistanclaque.zrh.corp.google.com ([2a00:79e0:42:204:34aa:3c10:4b35:5e84]) (user=ndumazet job=sendgmr) by 2002:a05:6000:1689:b0:22e:2c03:36e7 with SMTP id y9-20020a056000168900b0022e2c0336e7mr32732679wrd.252.1666858934879; Thu, 27 Oct 2022 01:22:14 -0700 (PDT) Date: Thu, 27 Oct 2022 10:22:08 +0200 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.0.135.g90850a2211-goog Message-ID: <20221027082208.25483-1-ndumazet@google.com> Subject: [PATCH] usb: add NO_LPM quirk for Realforce 87U Keyboard From: Nicolas Dumazet To: Greg Kroah-Hartman , Jean-Francois Le Fillatre Cc: Petar Kostic , Oliver Neukum , Ole Ernst , Hannu Hartikainen , Jimmy Wang , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Nicolas Dumazet , stable@vger.kernel.org X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747828813907991404?= X-GMAIL-MSGID: =?utf-8?q?1747828813907991404?= Before adding this quirk, this (mechanical keyboard) device would not be recognized, logging: new full-speed USB device number 56 using xhci_hcd unable to read config index 0 descriptor/start: -32 chopping to 0 config(s) It would take dozens of plugging/unpuggling cycles for the keyboard to be recognized. Keyboard seems to simply work after applying this quirk. This issue had been reported by users in two places already ([1], [2]) but nobody tried upstreaming a patch yet. After testing I believe their suggested fix (DELAY_INIT + NO_LPM + DEVICE_QUALIFIER) was probably a little overkill. I assume this particular combination was tested because it had been previously suggested in [3], but only NO_LPM seems sufficient for this device. [1]: https://qiita.com/float168/items/fed43d540c8e2201b543 [2]: https://blog.kostic.dev/posts/making-the-realforce-87ub-work-with-usb30-on-Ubuntu/ [3]: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678477 Cc: stable@vger.kernel.org Signed-off-by: Nicolas Dumazet --- drivers/usb/core/quirks.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c index 0722d2131305..e775d1bbea4d 100644 --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -532,6 +532,9 @@ static const struct usb_device_id usb_quirk_list[] = { /* INTEL VALUE SSD */ { USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME }, + /* Realforce 87U Keyboard */ + { USB_DEVICE(0x0853, 0x011b), .driver_info = USB_QUIRK_NO_LPM }, + { } /* terminating entry must be last */ };