From patchwork Wed Oct 26 23:38:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 11505 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp556855wru; Wed, 26 Oct 2022 17:24:58 -0700 (PDT) X-Google-Smtp-Source: AMsMyM66JkF3RXiy53nOwuifdZO1KxLYOFStlUVoaWi8FhcZrpTbWmojYZO59RN42VEAY65OE/py X-Received: by 2002:a05:6402:2073:b0:461:5462:9dc9 with SMTP id bd19-20020a056402207300b0046154629dc9mr28107180edb.52.1666830298065; Wed, 26 Oct 2022 17:24:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666830298; cv=none; d=google.com; s=arc-20160816; b=SkseIXKlScEWzf2cV03Qmu4BJtpbz+sEYgsxSqI+32m8zpG7DNj3zT4E4JFejbI6Sl O4fguLUwlIG9U6slcBm+7Ndl3n9/7XEF7ga8wqndY25gedPlZ05j5zdtOC/k+iyhWVxk vT53M0E68BR8wQl2SbWBCDoHd0kqAXcXTWx3f8qIeUFUPT5Bu/xpTG9UjLJchNnKfvdj J5Bj6laKMngO5piAD8rRkRr405EwilBQRXSjiUCif5f5iII0i9iNLpPsmtFuTdBgQ/La icl5/2a/uBDyDZw/O71r0oTtC7iRUnjMyLRYthx47EUPB1iW+f9s/9V2Mng4rXKeHpAE Csvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:from:subject:message-id:mime-version:date :dkim-signature; bh=xbDuJLys2yCi1gCNZsEM3kXsnvS1QRPzKET8yVSK5oo=; b=MCrQUIgbRBkeyd9v0lvxO8OC8O516LuFw9gRuF1XFl2IZR5g4R2RBz7p+xeFlSz05O ugAvrmfO4b9zbEnQNKklxmLb7MCdXx6OfCOvLUJM9AipRzJbbTE0NygAZE95L5nNNEHZ SymitdNnK7B6zte89jJIRuh0ajEpppTxnhoxUCUNrI5VO5/oRNmT6XLK5aBSx81GEE9Q teIwl1ziDUQcqRPMg7Q2rURJSHt5ANBiIJXO5cE1CrROvhz2UCoaDF08fT/HNYvTL68C 7kTNndeQV5dxF76foPulA4/BV+mWhv2NVBEclrqGOUzCGvXhZGtE8ZfMmb2aYy9xWkqb qzVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=jfsBRYA0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v22-20020a056402349600b004488842d88esi76817edc.13.2022.10.26.17.24.34; Wed, 26 Oct 2022 17:24:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20210112 header.b=jfsBRYA0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233699AbiJZXis (ORCPT + 99 others); Wed, 26 Oct 2022 19:38:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46370 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233386AbiJZXiq (ORCPT ); Wed, 26 Oct 2022 19:38:46 -0400 Received: from mail-yw1-x1149.google.com (mail-yw1-x1149.google.com [IPv6:2607:f8b0:4864:20::1149]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B8577B97BC for ; Wed, 26 Oct 2022 16:38:44 -0700 (PDT) Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-348608c1cd3so162683067b3.10 for ; Wed, 26 Oct 2022 16:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=xbDuJLys2yCi1gCNZsEM3kXsnvS1QRPzKET8yVSK5oo=; b=jfsBRYA0AZl2Prsyq/Gl+tDno3JY9JI8umprVKzM6NnAnBX1l1X12S6HNB3lWbz5Ob JT6frKQrzq7aI0sL+vK+9QviH03IGkWZqB1jdYR9ijiRzq+Y/R0gK6AZUogD4+j2C5V6 mE6oiF3urVx2hb0ldj2ylu8aF5ggPkIDkTchaCSIX2LaWM5wkrGLtUEl0UcDjVWUejdI OmWpKoO1y77KFodQDWW9Aq1HzKFGvC6gC0VV4CJj8CUHn6NFVAAnYDHO35ZJJgcv7x3l mkkqdrjGED0nRWqHRzHHzC3VvJjBI22QH0rsk7Ck/2wvRMVLUUYDskMyFBEwCrf5ATxP 1wBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=xbDuJLys2yCi1gCNZsEM3kXsnvS1QRPzKET8yVSK5oo=; b=TgiO2CUhy835vZJXRadMDBdGBAqD3ETK9aawy3GgJpzmciYG5PlIgilPBixSO7vSKA 3fUULxDMTDnG/7gN/O3asES1X4Gle1ED8M/ZN/3KsVXvhv3u6sYtPda/qFbV247Ssywr 5PH2fqr+yyEo0BI/hEL+F5AIim9NFA2YtnnIxSuEYOQS/dpNnIM7ucMbp/UzrmzfqQdu zui6C7MvQz9MmCRHHVvT5X2iAHIw5r5fH92y1hbE9GjwFNqFUuzR6x5iSJzK1pstwS5+ BOjNzw74wRAJ8zg6AMpRNxQ1CEOk8uTrR3nnpfw7iXboZz6jCkYU16CgAdtUB8eyb0rI 5pgg== X-Gm-Message-State: ACrzQf2i68+htyLZ02e03Vp3WTr7/OchkQoiFs6u/ROXkG9s6h/1N+8S Swl1HfzlaHKlqBnmJA7ebseCM1s2Vzs= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:2c3c:7552:4741:9b60]) (user=surenb job=sendgmr) by 2002:a25:410:0:b0:6cb:a8a9:1d18 with SMTP id 16-20020a250410000000b006cba8a91d18mr4540543ybe.274.1666827524037; Wed, 26 Oct 2022 16:38:44 -0700 (PDT) Date: Wed, 26 Oct 2022 16:38:39 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog Message-ID: <20221026233839.1934419-1-surenb@google.com> Subject: [PATCH v5 1/1] psi: stop relying on timer_pending for poll_work rescheduling From: Suren Baghdasaryan To: peterz@infradead.org Cc: hannes@cmpxchg.org, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, matthias.bgg@gmail.com, minchan@google.com, yt.chang@mediatek.com, wenju.xu@mediatek.com, jonathan.jmchen@mediatek.com, show-hong.chen@mediatek.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel-team@android.com, surenb@google.com X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747797725103738810?= X-GMAIL-MSGID: =?utf-8?q?1747798246185627362?= Psi polling mechanism is trying to minimize the number of wakeups to run psi_poll_work and is currently relying on timer_pending() to detect when this work is already scheduled. This provides a window of opportunity for psi_group_change to schedule an immediate psi_poll_work after poll_timer_fn got called but before psi_poll_work could reschedule itself. Below is the depiction of this entire window: poll_timer_fn wake_up_interruptible(&group->poll_wait); psi_poll_worker wait_event_interruptible(group->poll_wait, ...) psi_poll_work psi_schedule_poll_work if (timer_pending(&group->poll_timer)) return; ... mod_timer(&group->poll_timer, jiffies + delay); Prior to 461daba06bdc we used to rely on poll_scheduled atomic which was reset and set back inside psi_poll_work and therefore this race window was much smaller. The larger window causes increased number of wakeups and our partners report visible power regression of ~10mA after applying 461daba06bdc. Bring back the poll_scheduled atomic and make this race window even narrower by resetting poll_scheduled only when we reach polling expiration time. This does not completely eliminate the possibility of extra wakeups caused by a race with psi_group_change however it will limit it to the worst case scenario of one extra wakeup per every tracking window (0.5s in the worst case). This patch also ensures correct ordering between clearing poll_scheduled flag and obtaining changed_states using memory barrier. Correct ordering between updating changed_states and setting poll_scheduled is ensured by atomic_xchg operation. By tracing the number of immediate rescheduling attempts performed by psi_group_change and the number of these attempts being blocked due to psi monitor being already active, we can assess the effects of this change: Before the patch: Run#1 Run#2 Run#3 Immediate reschedules attempted: 684365 1385156 1261240 Immediate reschedules blocked: 682846 1381654 1258682 Immediate reschedules (delta): 1519 3502 2558 Immediate reschedules (% of attempted): 0.22% 0.25% 0.20% After the patch: Run#1 Run#2 Run#3 Immediate reschedules attempted: 882244 770298 426218 Immediate reschedules blocked: 881996 769796 426074 Immediate reschedules (delta): 248 502 144 Immediate reschedules (% of attempted): 0.03% 0.07% 0.03% The number of non-blocked immediate reschedules dropped from 0.22-0.25% to 0.03-0.07%. The drop is attributed to the decrease in the race window size and the fact that we allow this race only when psi monitors reach polling window expiration time. Fixes: 461daba06bdc ("psi: eliminate kthread_worker from psi trigger scheduling mechanism") Reported-by: Kathleen Chang Reported-by: Wenju Xu Reported-by: Jonathan Chen Signed-off-by: Suren Baghdasaryan Tested-by: SH Chen Acked-by: Johannes Weiner --- Changes since v4 posted at https://lore.kernel.org/all/20221010225744.101629-1-surenb@google.com/ - Added missing parameter in psi_schedule_poll_work() call used only when CONFIG_IRQ_TIME_ACCOUNTING is enabled, reported by kernel test robot. include/linux/psi_types.h | 1 + kernel/sched/psi.c | 62 ++++++++++++++++++++++++++++++++------- 2 files changed, 53 insertions(+), 10 deletions(-) diff --git a/include/linux/psi_types.h b/include/linux/psi_types.h index 6e4372735068..14a1ebb74e11 100644 --- a/include/linux/psi_types.h +++ b/include/linux/psi_types.h @@ -177,6 +177,7 @@ struct psi_group { struct timer_list poll_timer; wait_queue_head_t poll_wait; atomic_t poll_wakeup; + atomic_t poll_scheduled; /* Protects data used by the monitor */ struct mutex trigger_lock; diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c index dbaeac915895..19d05b5c8a55 100644 --- a/kernel/sched/psi.c +++ b/kernel/sched/psi.c @@ -189,6 +189,7 @@ static void group_init(struct psi_group *group) INIT_DELAYED_WORK(&group->avgs_work, psi_avgs_work); mutex_init(&group->avgs_lock); /* Init trigger-related members */ + atomic_set(&group->poll_scheduled, 0); mutex_init(&group->trigger_lock); INIT_LIST_HEAD(&group->triggers); group->poll_min_period = U32_MAX; @@ -580,18 +581,17 @@ static u64 update_triggers(struct psi_group *group, u64 now) return now + group->poll_min_period; } -/* Schedule polling if it's not already scheduled. */ -static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay) +/* Schedule polling if it's not already scheduled or forced. */ +static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay, + bool force) { struct task_struct *task; /* - * Do not reschedule if already scheduled. - * Possible race with a timer scheduled after this check but before - * mod_timer below can be tolerated because group->polling_next_update - * will keep updates on schedule. + * atomic_xchg should be called even when !force to provide a + * full memory barrier (see the comment inside psi_poll_work). */ - if (timer_pending(&group->poll_timer)) + if (atomic_xchg(&group->poll_scheduled, 1) && !force) return; rcu_read_lock(); @@ -603,12 +603,15 @@ static void psi_schedule_poll_work(struct psi_group *group, unsigned long delay) */ if (likely(task)) mod_timer(&group->poll_timer, jiffies + delay); + else + atomic_set(&group->poll_scheduled, 0); rcu_read_unlock(); } static void psi_poll_work(struct psi_group *group) { + bool force_reschedule = false; u32 changed_states; u64 now; @@ -616,6 +619,43 @@ static void psi_poll_work(struct psi_group *group) now = sched_clock(); + if (now > group->polling_until) { + /* + * We are either about to start or might stop polling if no + * state change was recorded. Resetting poll_scheduled leaves + * a small window for psi_group_change to sneak in and schedule + * an immegiate poll_work before we get to rescheduling. One + * potential extra wakeup at the end of the polling window + * should be negligible and polling_next_update still keeps + * updates correctly on schedule. + */ + atomic_set(&group->poll_scheduled, 0); + /* + * A task change can race with the poll worker that is supposed to + * report on it. To avoid missing events, ensure ordering between + * poll_scheduled and the task state accesses, such that if the poll + * worker misses the state update, the task change is guaranteed to + * reschedule the poll worker: + * + * poll worker: + * atomic_set(poll_scheduled, 0) + * smp_mb() + * LOAD states + * + * task change: + * STORE states + * if atomic_xchg(poll_scheduled, 1) == 0: + * schedule poll worker + * + * The atomic_xchg() implies a full barrier. + */ + smp_mb(); + } else { + /* Polling window is not over, keep rescheduling */ + force_reschedule = true; + } + + collect_percpu_times(group, PSI_POLL, &changed_states); if (changed_states & group->poll_states) { @@ -641,7 +681,8 @@ static void psi_poll_work(struct psi_group *group) group->polling_next_update = update_triggers(group, now); psi_schedule_poll_work(group, - nsecs_to_jiffies(group->polling_next_update - now) + 1); + nsecs_to_jiffies(group->polling_next_update - now) + 1, + force_reschedule); out: mutex_unlock(&group->trigger_lock); @@ -802,7 +843,7 @@ static void psi_group_change(struct psi_group *group, int cpu, write_seqcount_end(&groupc->seq); if (state_mask & group->poll_states) - psi_schedule_poll_work(group, 1); + psi_schedule_poll_work(group, 1, false); if (wake_clock && !delayed_work_pending(&group->avgs_work)) schedule_delayed_work(&group->avgs_work, PSI_FREQ); @@ -956,7 +997,7 @@ void psi_account_irqtime(struct task_struct *task, u32 delta) write_seqcount_end(&groupc->seq); if (group->poll_states & (1 << PSI_IRQ_FULL)) - psi_schedule_poll_work(group, 1); + psi_schedule_poll_work(group, 1, false); } while ((group = group->parent)); } #endif @@ -1342,6 +1383,7 @@ void psi_trigger_destroy(struct psi_trigger *t) * can no longer be found through group->poll_task. */ kthread_stop(task_to_destroy); + atomic_set(&group->poll_scheduled, 0); } kfree(t); }