diff mbox series

[v3,2/5] dt-bindings: power: rpmpd: Add QDU1000/QRU1000 to rpmpd binding

Message ID 20221026190549.4005703-3-quic_molvera@quicinc.com
State New
Headers
Series Add misc support for QDU1000/QRU1000 SoCs |

Commit Message

Melody Olvera Oct. 26, 2022, 7:05 p.m. UTC 
  Add compatible and constants for the power domains exposed by the RPMH
in the Qualcomm QDU1000 and QRU1000 platforms.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
 include/dt-bindings/power/qcom-rpmpd.h                  | 6 ++++++
 2 files changed, 7 insertions(+)

Comments

Krzysztof Kozlowski Oct. 27, 2022, 3:25 p.m. UTC | #1 
On 26/10/2022 15:05, Melody Olvera wrote:
> Add compatible and constants for the power domains exposed by the RPMH
> in the Qualcomm QDU1000 and QRU1000 platforms.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>

Looks good, but you did not Cc maintainers and  they must see this patch.

Who do you think will review and pick up this patch?


Best regards,
Krzysztof
Bjorn Andersson Nov. 7, 2022, 5:48 p.m. UTC | #2 
On Thu, Oct 27, 2022 at 11:25:42AM -0400, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:05, Melody Olvera wrote:
> > Add compatible and constants for the power domains exposed by the RPMH
> > in the Qualcomm QDU1000 and QRU1000 platforms.
> > 
> > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> 
> Looks good, but you did not Cc maintainers and  they must see this patch.
> 

$ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/power/qcom,rpmpd.yaml include/dt-bindings/power/qcom-rpmpd.h
Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT)
Bjorn Andersson <andersson@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT,in file)
Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)

So you're right; Melody did miss Konrad in the recipients list. But he's
typically doing a very good job of keeping an eye on the list - and both
you and I got the patch.


Why didn't you add your R-b if you think it looks good?

> Who do you think will review and pick up this patch?
> 

Per the maintainers file that would be me, and as you don't seem to
object to the content of the patch I'm queueing this now.

Thanks,
Bjorn
Krzysztof Kozlowski Nov. 7, 2022, 6:18 p.m. UTC | #3 
On 07/11/2022 18:48, Bjorn Andersson wrote:
> On Thu, Oct 27, 2022 at 11:25:42AM -0400, Krzysztof Kozlowski wrote:
>> On 26/10/2022 15:05, Melody Olvera wrote:
>>> Add compatible and constants for the power domains exposed by the RPMH
>>> in the Qualcomm QDU1000 and QRU1000 platforms.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>
>> Looks good, but you did not Cc maintainers and  they must see this patch.
>>
> 
> $ ./scripts/get_maintainer.pl -f Documentation/devicetree/bindings/power/qcom,rpmpd.yaml include/dt-bindings/power/qcom-rpmpd.h
> Andy Gross <agross@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT)
> Bjorn Andersson <andersson@kernel.org> (maintainer:ARM/QUALCOMM SUPPORT,in file)
> Konrad Dybcio <konrad.dybcio@somainline.org> (reviewer:ARM/QUALCOMM SUPPORT)
> Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-arm-msm@vger.kernel.org (open list:ARM/QUALCOMM SUPPORT)
> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-kernel@vger.kernel.org (open list)
> 
> So you're right; Melody did miss Konrad in the recipients list. But he's
> typically doing a very good job of keeping an eye on the list - and both
> you and I got the patch.
> 
> 
> Why didn't you add your R-b if you think it looks good?

Because then you would pick it up and that I did not want. It shall be
resent so all maintainers get it. I did not check though how many of
people were missing.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index 2ca98bad2d35..c0bee4e8a9db 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -28,6 +28,7 @@  properties:
       - qcom,msm8998-rpmpd
       - qcom,qcm2290-rpmpd
       - qcom,qcs404-rpmpd
+      - qcom,qdu1000-rpmhpd
       - qcom,sa8540p-rpmhpd
       - qcom,sdm660-rpmpd
       - qcom,sc7180-rpmhpd
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 578e060890dd..7b2e4b66419a 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -113,6 +113,12 @@ 
 #define SM8450_MXC_AO	11
 #define SM8450_MSS	12
 
+/* QDU1000/QRU1000 Power Domain Indexes */
+#define QDU1000_EBI	0
+#define QDU1000_MSS	1
+#define QDU1000_CX	2
+#define QDU1000_MX	3
+
 /* SC7180 Power Domain Indexes */
 #define SC7180_CX	0
 #define SC7180_CX_AO	1