| Message ID | 20221026190549.4005703-2-quic_molvera@quicinc.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp440194wru;
Wed, 26 Oct 2022 12:10:56 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM4DoDxAmA40aBh7gpulsL27pL7ifjZEIEN6MQmBrnQ/84AX8wIFWQsxGClpPcVv6CgCaK4Z
X-Received: by 2002:a05:6402:f0e:b0:461:aaa3:a11c with SMTP id
i14-20020a0564020f0e00b00461aaa3a11cmr18336601eda.53.1666811456501;
Wed, 26 Oct 2022 12:10:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666811456; cv=none;
d=google.com; s=arc-20160816;
b=0nkU0X1OxWRCThdnkOE2nGkUlWZVq3Hx77aY1z5NgoQ/vIEfCNSKyfcf0a1I74caBg
l0myErjlhTCkcU31hEkt15mVZCNSKsYVMKTlz/Orc/pVZEEPAsonbM+PbdNvjljdmXh9
Lo6v//QLl/3EuqNuslLUCiqxib5hMijT7Tdb0PqS+Qz+L+fUMfw8o+bj55WW/23RyoOn
q3P7epPdxAI+ktYUoDm0lPKQmQ3VFBGsRNM+hRVwn2kwck3oPIVBRuXz9krozvFyOiEV
CX1EVqDuVdMcUBvoZAzWbdKlYC8ZaMmVUwcAxH+vXJi6LemwLdAPuGj9Jroz5TeZlEA4
QaoA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=yvBLHefS2umnQUfDyzABpZHu2ghyKss90AgaZIhXL4o=;
b=pWYUJFXxG1KiWcFJXSxQYtrmPbUOsq1jBwiVZsghJZOy3yZqTyBRni9UjUC6zgzeKP
TrD49TesQ6/UKHP3dszV/6fCD/CITAIUgxQwsTN9DcyAXzxFAooduqzCdQZCu1CjCT3p
8zmAvseppofX2vJmFEbx9b1Fizgwm550fYDIfD2anTv4II6DFftDhOJ/Y2TNrl8Ot5nU
x7MWUrPRqjSwDqYh9lJBM4kr30QSHkgqikAHJFapD343ww+q5OSvArNmMNfPPOJcRdKq
O1t/Ynr3J6RxspQjMJBsIyZZvaXt2nQTH+8hOArcevvvIw114UAmNPAd/xccS04o5j6B
z1og==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="jMwlpZW/";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
l21-20020a170906795500b0073db353cb25si6921545ejo.869.2022.10.26.12.10.31;
Wed, 26 Oct 2022 12:10:56 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b="jMwlpZW/";
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S234936AbiJZTKB (ORCPT <rfc822;pwkd43@gmail.com> + 99 others);
Wed, 26 Oct 2022 15:10:01 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55586 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234883AbiJZTIJ (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 26 Oct 2022 15:08:09 -0400
Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com
[205.220.168.131])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E140E0DB;
Wed, 26 Oct 2022 12:06:05 -0700 (PDT)
Received: from pps.filterd (m0279867.ppops.net [127.0.0.1])
by mx0a-0031df01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id
29QIoxr7021002;
Wed, 26 Oct 2022 19:06:03 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com;
h=from : to : cc :
subject : date : message-id : in-reply-to : references : mime-version :
content-transfer-encoding : content-type; s=qcppdkim1;
bh=yvBLHefS2umnQUfDyzABpZHu2ghyKss90AgaZIhXL4o=;
b=jMwlpZW//hIilnbFcvoNqjoEdhAKqFY83V52i5Qx5E6b6IyMU6Sgv6X9dF2DqWW3l+VZ
oEdVr7qKaBsn8zwDJzkiStzM+1gT/9Z5IiRNr+Wsz4z0WaBPxajdUcPqUcByJrKzlYAB
nyz+0PY8cdvSazkK81JdS8l0Pao37Fc4ITDZLVd5PDI74cBKAWh0hFCGQjSPYB51SjkO
iSpAQKcfQ6e2CJDFDSRtp06zShAf0SgdxIfff6S0mFHP4uWVpQDB+igklJxmisdwy0hh
xz71YjxrWBnCxD1s4dhT7833s6UexxbIXB7neIE5l8TT4O774sD7qxfiP+GtjGIJodEa yA==
Received: from nasanppmta03.qualcomm.com (i-global254.qualcomm.com
[199.106.103.254])
by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3kfah501yc-1
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 26 Oct 2022 19:06:02 +0000
Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com
[10.46.141.250])
by NASANPPMTA03.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id
29QJ62ZM015176
(version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256
verify=NOT);
Wed, 26 Oct 2022 19:06:02 GMT
Received: from hu-eberman-lv.qualcomm.com (10.49.16.6) by
nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.986.29; Wed, 26 Oct 2022 12:06:01 -0700
From: Melody Olvera <quic_molvera@quicinc.com>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
CC: Robert Marko <robimarko@gmail.com>,
Guru Das Srinagesh <quic_gurus@quicinc.com>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Melody Olvera <quic_molvera@quicinc.com>
Subject: [PATCH v3 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000
compatibles
Date: Wed, 26 Oct 2022 12:05:45 -0700
Message-ID: <20221026190549.4005703-2-quic_molvera@quicinc.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20221026190549.4005703-1-quic_molvera@quicinc.com>
References: <20221026190549.4005703-1-quic_molvera@quicinc.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
X-Originating-IP: [10.49.16.6]
X-ClientProxiedBy: nalasex01a.na.qualcomm.com (10.47.209.196) To
nasanex01b.na.qualcomm.com (10.46.141.250)
X-QCInternal: smtphost
X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800
signatures=585085
X-Proofpoint-GUID: fwNUYKh9luje36_ek2eHC_HYkK6VS0Sx
X-Proofpoint-ORIG-GUID: fwNUYKh9luje36_ek2eHC_HYkK6VS0Sx
X-Proofpoint-Virus-Version: vendor=baseguard
engine=ICAP:2.0.205,Aquarius:18.0.895,Hydra:6.0.545,FMLib:17.11.122.1
definitions=2022-10-26_07,2022-10-26_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
phishscore=0 adultscore=0
mlxscore=0 bulkscore=0 lowpriorityscore=0 malwarescore=0 suspectscore=0
spamscore=0 mlxlogscore=999 clxscore=1015 priorityscore=1501
impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1
engine=8.12.0-2210170000 definitions=main-2210260107
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747778489544839107?=
X-GMAIL-MSGID: =?utf-8?q?1747778489544839107?=
|
| Series |
Add misc support for QDU1000/QRU1000 SoCs
|
|
Commit Message
Melody Olvera
Oct. 26, 2022, 7:05 p.m. UTC
Add compatibles for scm driver for QDU1000 and QRU1000 platforms.
Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
.../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++
1 file changed, 15 insertions(+)
Comments
On 26/10/2022 15:05, Melody Olvera wrote: > Add compatibles for scm driver for QDU1000 and QRU1000 platforms. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index be1b5746eddb..5352181aa393 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -38,6 +38,7 @@ properties: > - qcom,scm-msm8994 > - qcom,scm-msm8996 > - qcom,scm-msm8998 > + - qcom,scm-qdu1000 > - qcom,scm-sc7180 > - qcom,scm-sc7280 > - qcom,scm-sc8280xp > @@ -81,6 +82,20 @@ properties: > description: TCSR hardware block > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scm-qdu1000 > + then: > + properties: > + '#reset-cells': > + maxItems: 1 This is wrong... how can you have here more items? > + clocks: false > + clock-names: false > + > + required: > + - '#reset-cells' Missing blank line. > - if: > properties: > compatible: Best regards, Krzysztof
On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote: > Add compatibles for scm driver for QDU1000 and QRU1000 platforms. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index be1b5746eddb..5352181aa393 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -38,6 +38,7 @@ properties: > - qcom,scm-msm8994 > - qcom,scm-msm8996 > - qcom,scm-msm8998 > + - qcom,scm-qdu1000 > - qcom,scm-sc7180 > - qcom,scm-sc7280 > - qcom,scm-sc8280xp > @@ -81,6 +82,20 @@ properties: > description: TCSR hardware block > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scm-qdu1000 > + then: > + properties: > + '#reset-cells': > + maxItems: 1 > + clocks: false > + clock-names: false > + > + required: > + - '#reset-cells' Please document what this reset is expected to be wired to, and write a sentence or two in the commit message how the QDU differs from existing platforms supported by the binding. Thanks, Bjorn > - if: > properties: > compatible: > -- > 2.25.1 >
On 11/7/2022 9:38 AM, Bjorn Andersson wrote: > On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote: >> Add compatibles for scm driver for QDU1000 and QRU1000 platforms. >> >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index be1b5746eddb..5352181aa393 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -38,6 +38,7 @@ properties: >> - qcom,scm-msm8994 >> - qcom,scm-msm8996 >> - qcom,scm-msm8998 >> + - qcom,scm-qdu1000 >> - qcom,scm-sc7180 >> - qcom,scm-sc7280 >> - qcom,scm-sc8280xp >> @@ -81,6 +82,20 @@ properties: >> description: TCSR hardware block >> >> allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,scm-qdu1000 >> + then: >> + properties: >> + '#reset-cells': >> + maxItems: 1 >> + clocks: false >> + clock-names: false >> + >> + required: >> + - '#reset-cells' > Please document what this reset is expected to be wired to, and write a > sentence or two in the commit message how the QDU differs from existing > platforms supported by the binding. > Honestly, I can't remember what this is here for. Will remove from here and DT. Will also add a quick blurb about not needing clocks. Thanks, Melody > >> - if: >> properties: >> compatible: >> -- >> 2.25.1 >>
On 10/27/2022 8:24 AM, Krzysztof Kozlowski wrote: > On 26/10/2022 15:05, Melody Olvera wrote: >> Add compatibles for scm driver for QDU1000 and QRU1000 platforms. >> >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index be1b5746eddb..5352181aa393 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -38,6 +38,7 @@ properties: >> - qcom,scm-msm8994 >> - qcom,scm-msm8996 >> - qcom,scm-msm8998 >> + - qcom,scm-qdu1000 >> - qcom,scm-sc7180 >> - qcom,scm-sc7280 >> - qcom,scm-sc8280xp >> @@ -81,6 +82,20 @@ properties: >> description: TCSR hardware block >> >> allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,scm-qdu1000 >> + then: >> + properties: >> + '#reset-cells': >> + maxItems: 1 > This is wrong... how can you have here more items? Being removed anyways. > >> + clocks: false >> + clock-names: false >> + >> + required: >> + - '#reset-cells' > Missing blank line. Ack. Thanks, Melody > >> - if: >> properties: >> compatible: > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index be1b5746eddb..5352181aa393 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -38,6 +38,7 @@ properties: - qcom,scm-msm8994 - qcom,scm-msm8996 - qcom,scm-msm8998 + - qcom,scm-qdu1000 - qcom,scm-sc7180 - qcom,scm-sc7280 - qcom,scm-sc8280xp @@ -81,6 +82,20 @@ properties: description: TCSR hardware block allOf: + - if: + properties: + compatible: + contains: + const: qcom,scm-qdu1000 + then: + properties: + '#reset-cells': + maxItems: 1 + clocks: false + clock-names: false + + required: + - '#reset-cells' - if: properties: compatible: