diff mbox series

[v3,2/5] dt-bindings: clock: Add RPMHCC bindings for QDU1000 and QRU1000

Message ID 20221026190441.4002212-3-quic_molvera@quicinc.com
State New
Headers
Series clk: qcom: Add clocks for the QDU1000 and QRU1000 SoCs |

Commit Message

Melody Olvera Oct. 26, 2022, 7:04 p.m. UTC 
  Add compatible strings for RPMHCC for QDU1000 and QRU1000.

Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
---
 Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Oct. 27, 2022, 3:57 p.m. UTC | #1 
On 26/10/2022 15:04, Melody Olvera wrote:
> Add compatible strings for RPMHCC for QDU1000 and QRU1000.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
> ---

This looks correct except:
1. redundant bindings in subject
2. not cc-ing all maintainers

so still not tag.

Best regards,
Krzysztof
Melody Olvera Oct. 28, 2022, 1:04 a.m. UTC | #2 
On 10/27/2022 8:57 AM, Krzysztof Kozlowski wrote:
> On 26/10/2022 15:04, Melody Olvera wrote:
>> Add compatible strings for RPMHCC for QDU1000 and QRU1000.
>>
>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>> ---
> This looks correct except:
> 1. redundant bindings in subject
> 2. not cc-ing all maintainers
>
> so still not tag.
>
>
Not sure what you mean by redundant bindings; should I remove
"QRU1000"? "Compatible strings"? Please advise.

Also, I got maintainers from running get_maintainers.pl on
linux-next/master; is this wrong? Not sure what I'm missing here.

Thanks,
Melody
Krzysztof Kozlowski Oct. 28, 2022, 1:09 a.m. UTC | #3 
On 27/10/2022 21:04, Melody Olvera wrote:
> 
> 
> On 10/27/2022 8:57 AM, Krzysztof Kozlowski wrote:
>> On 26/10/2022 15:04, Melody Olvera wrote:
>>> Add compatible strings for RPMHCC for QDU1000 and QRU1000.
>>>
>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>> ---
>> This looks correct except:
>> 1. redundant bindings in subject
>> 2. not cc-ing all maintainers
>>
>> so still not tag.
>>
>>
> Not sure what you mean by redundant bindings; should I remove
> "QRU1000"? "Compatible strings"? Please advise.

In the subject please drop second 'bindings' word, because it is
redundant so:

dt-bindings: clock: Add RPMHCC for QDU1000 and QRU1000
or
dt-bindings: clock: Add QDU1000/QRU1000 RPMHCC

> 
> Also, I got maintainers from running get_maintainers.pl on
> linux-next/master; is this wrong? Not sure what I'm missing here.

You miss some of Qualcomm maintainers. Maybe more, I did not check every
possible output for every patchset. I just spotted missing Konrad,
because it sticks out. If you copy the output of some commands, be sure
you copy everything. Otherwise, just automate it so there will be no
chances for mistakes.

Best regards,
Krzysztof
Melody Olvera Oct. 28, 2022, 4:54 p.m. UTC | #4 
On 10/27/2022 6:09 PM, Krzysztof Kozlowski wrote:
> On 27/10/2022 21:04, Melody Olvera wrote:
>>
>> On 10/27/2022 8:57 AM, Krzysztof Kozlowski wrote:
>>> On 26/10/2022 15:04, Melody Olvera wrote:
>>>> Add compatible strings for RPMHCC for QDU1000 and QRU1000.
>>>>
>>>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>
>>>> ---
>>> This looks correct except:
>>> 1. redundant bindings in subject
>>> 2. not cc-ing all maintainers
>>>
>>> so still not tag.
>>>
>>>
>> Not sure what you mean by redundant bindings; should I remove
>> "QRU1000"? "Compatible strings"? Please advise.
> In the subject please drop second 'bindings' word, because it is
> redundant so:
>
> dt-bindings: clock: Add RPMHCC for QDU1000 and QRU1000
> or
> dt-bindings: clock: Add QDU1000/QRU1000 RPMHCC
Oh ok that makes sense. Sorry about the confusion.
>
>> Also, I got maintainers from running get_maintainers.pl on
>> linux-next/master; is this wrong? Not sure what I'm missing here.
> You miss some of Qualcomm maintainers. Maybe more, I did not check every
> possible output for every patchset. I just spotted missing Konrad,
> because it sticks out. If you copy the output of some commands, be sure
> you copy everything. Otherwise, just automate it so there will be no
> chances for mistakes.
Ah ok no worries. Will make sure my copy-paste is thorough.

Thanks,
Melody
Bjorn Andersson Nov. 7, 2022, 5:36 p.m. UTC | #5 
On Wed, Oct 26, 2022 at 12:04:38PM -0700, Melody Olvera wrote:
> Add compatible strings for RPMHCC for QDU1000 and QRU1000.
> 
> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com>

This is independent of the GCC binding/driver, so I fixed up the
$subject per Krzysztof's feedback and picked the two patches.

But like the PDC, it's better to post independent things separately.

Thanks,
Bjorn

> ---
>  Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
> index 437a34b930e3..fccb91e78e49 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
> @@ -17,6 +17,7 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - qcom,qdu1000-rpmh-clk
>        - qcom,sc7180-rpmh-clk
>        - qcom,sc7280-rpmh-clk
>        - qcom,sc8180x-rpmh-clk
> -- 
> 2.25.1
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
index 437a34b930e3..fccb91e78e49 100644
--- a/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,rpmhcc.yaml
@@ -17,6 +17,7 @@  description: |
 properties:
   compatible:
     enum:
+      - qcom,qdu1000-rpmh-clk
       - qcom,sc7180-rpmh-clk
       - qcom,sc7280-rpmh-clk
       - qcom,sc8180x-rpmh-clk