diff mbox series

[2/2] ARM: dts: bcm2835-rpi: Use firmware clocks for display

Message ID 20221026-rpi-display-fw-clk-v1-2-5c29b7a3d8b0@cerno.tech
State New
Headers
Series ARM: dts: bcm283x: Switch to firmware clocks for Pi0-3 |

Commit Message

Maxime Ripard Oct. 26, 2022, 1:17 p.m. UTC 
  We've experienced a number of issues around the cohabitation between the
"real" clock driver in Linux and the one backed by the firmware.

One solution around this is to follow what the RaspberryPi foundation
in its downstream clock, which is also what we've been doing on the
RaspberryPi4: to use the clocks exposed by the firmware.

Link: https://lore.kernel.org/linux-clk/20221021140505.kjmw5x4s6qhnrfif@houat/
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
---
 arch/arm/boot/dts/bcm2835-rpi-common.dtsi | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Florian Fainelli Nov. 9, 2022, 6:24 p.m. UTC | #1 
On Wed, 26 Oct 2022 15:17:39 +0200, maxime@cerno.tech wrote:
> We've experienced a number of issues around the cohabitation between the
> "real" clock driver in Linux and the one backed by the firmware.
> 
> One solution around this is to follow what the RaspberryPi foundation
> in its downstream clock, which is also what we've been doing on the
> RaspberryPi4: to use the clocks exposed by the firmware.
> 
> Link: https://lore.kernel.org/linux-clk/20221021140505.kjmw5x4s6qhnrfif@houat/
> Signed-off-by: Maxime Ripard <maxime@cerno.tech>
> ---

Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2835-rpi-common.dtsi b/arch/arm/boot/dts/bcm2835-rpi-common.dtsi
index 8a55b6cded59..4e7b4a592da7 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-common.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi-common.dtsi
@@ -7,6 +7,23 @@ 
 
 #include <dt-bindings/power/raspberrypi-power.h>
 
+&firmware {
+	firmware_clocks: clocks {
+		compatible = "raspberrypi,firmware-clocks";
+		#clock-cells = <1>;
+	};
+};
+
+&hdmi {
+	clocks = <&firmware_clocks 9>,
+		 <&firmware_clocks 13>;
+	clock-names = "pixel", "hdmi";
+};
+
 &v3d {
 	power-domains = <&power RPI_POWER_DOMAIN_V3D>;
 };
+
+&vec {
+	clocks = <&firmware_clocks 15>;
+};