From patchwork Tue Oct 25 19:35:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bjorn Helgaas X-Patchwork-Id: 10958 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1187356wru; Tue, 25 Oct 2022 12:52:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6aybmDlri5hbrv4JZHioWP0L6xnW9rxIybtKUWnkgGzWhM7gZv2MxoqgZB4YpEUG9E3HIg X-Received: by 2002:a17:902:e892:b0:186:ce8c:e606 with SMTP id w18-20020a170902e89200b00186ce8ce606mr2649692plg.160.1666727548199; Tue, 25 Oct 2022 12:52:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666727548; cv=none; d=google.com; s=arc-20160816; b=09MPICpvkOzgn0Qn/nArd2Y3iNBCagd2R/1tSrRumLY95lyhLIxjdrIrSMFjJ89WQu OfhPbXWdeSWeBq8EIWpHw+Os6yVEUhe5j/Kl0jGxkyqjtIV8WgwtzDtc29jqdQosSYcv 5TAy0pAQXk+32I+BCwSEY+CQm+iP0+ArviMLC6ZcCAG7Jl+bySM6UEeNICFUk7nipSg+ 2UU7FD4iAtUtPh2+Py+4UibGefdNLXxjF/l8ZV1iaUERZWSFNOSlE1FiboL3BCf5xCZ6 vtiRSxuPVwh85E6wwceu9ZHHP83wdbLYq6IkLLwAXMrnvTtOoGuXjYoWdObCtUvowrvh fCpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=N4lvo06b82bNlkPjDw1cLUqHcd+d+1mpkbHN5+aZ0xo=; b=hJSrZjrb4tDBlOiYR0cfQAEnN/F0gaN8vUdGvoOZyu4xMDAR2o+I5OjTgScscmTZ4n 5OKI6OCdC3gcmuct0v2KnS/XGNpycBjtSD+r6Pviwp/NdZffzfqLOJ1qTlvIdY/X1+vE p1axhZgobyTDzegIFWaWKxyRspA+5uNF7mqSUVu9QQzUswCKCoHnqKTM5jVKf6sy4QZY UQuXtS1wtLxslbE+ifx9K2bHqA5yCD8p5H0ioYZ0aNh6Y2NVGDfdfCrbOAz0JnFGBiwa uhWTHdOIHW/4DaiBhaZlEAIxOLYb3WxMqMTf5uQR1sIEJ5LEzbFoQ2Aj8lfgZT+W2dYR hibg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cc/XXN8c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i11-20020a63584b000000b0045f9f5763c4si4338155pgm.437.2022.10.25.12.52.15; Tue, 25 Oct 2022 12:52:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="cc/XXN8c"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231429AbiJYTfK (ORCPT + 99 others); Tue, 25 Oct 2022 15:35:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41802 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbiJYTfI (ORCPT ); Tue, 25 Oct 2022 15:35:08 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D381DD73D2; Tue, 25 Oct 2022 12:35:06 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7A6DF61B09; Tue, 25 Oct 2022 19:35:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9270EC433C1; Tue, 25 Oct 2022 19:35:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666726505; bh=CEcnd/MJyW10U1N9vmD9eLkgZa9XY0JfKKcSiavtBOw=; h=From:To:Cc:Subject:Date:From; b=cc/XXN8cZHxhoRAr6MyUEioF6EuzxrTwlIf17uXH4OjgQTzF3XIMH7BTeS1f5b15q HeMxw3O4i3GGduw3RpPsT/U1z3Cyb0Wim8wv8GTbqYQH7cMKox9M4CybXWPY1/h4w3 zcsZjqZuOZgIYqjjRhhbs8bW7TcTIJzuCXuw39gLFLAD11E9yEPpY1tcFcKgcf1W8+ TNq0KYx1yPyyjj9a1IGBSfmFbs7ozapOdoFIQH19EsI98uo0nTwEwQbqkRthwFXkFW c6hO32Y7yzvJVllf/1EndiiGL5toXjfDNnaZXDgBgLPZmCHEqbULxcSQJaDddKpoOO NiMD8zMRiEkAg== From: Bjorn Helgaas To: linux-pci@vger.kernel.org Cc: =?utf-8?q?Krzysztof_Wilczy=C5=84ski?= , "Rafael J . Wysocki" , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Bjorn Helgaas Subject: [PATCH] PCI/PM: Remove unused 'state' parameter to pci_legacy_suspend_late() Date: Tue, 25 Oct 2022 14:35:02 -0500 Message-Id: <20221025193502.669091-1-helgaas@kernel.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747690505287369007?= X-GMAIL-MSGID: =?utf-8?q?1747690505287369007?= From: Bjorn Helgaas 1a1daf097e21 ("PCI/PM: Remove unused pci_driver.suspend_late() hook") removed the legacy .suspend_late() hook, which was the only user of the "state" parameter to pci_legacy_suspend_late(), but it neglected to remove the parameter. Remove the unused "state" parameter to pci_legacy_suspend_late(). Signed-off-by: Bjorn Helgaas Acked-by: Rafael J. Wysocki --- drivers/pci/pci-driver.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/pci-driver.c b/drivers/pci/pci-driver.c index 107d77f3c846..a2ceeacc33eb 100644 --- a/drivers/pci/pci-driver.c +++ b/drivers/pci/pci-driver.c @@ -646,7 +646,7 @@ static int pci_legacy_suspend(struct device *dev, pm_message_t state) return 0; } -static int pci_legacy_suspend_late(struct device *dev, pm_message_t state) +static int pci_legacy_suspend_late(struct device *dev) { struct pci_dev *pci_dev = to_pci_dev(dev); @@ -848,7 +848,7 @@ static int pci_pm_suspend_noirq(struct device *dev) return 0; if (pci_has_legacy_pm_support(pci_dev)) - return pci_legacy_suspend_late(dev, PMSG_SUSPEND); + return pci_legacy_suspend_late(dev); if (!pm) { pci_save_state(pci_dev); @@ -1060,7 +1060,7 @@ static int pci_pm_freeze_noirq(struct device *dev) const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL; if (pci_has_legacy_pm_support(pci_dev)) - return pci_legacy_suspend_late(dev, PMSG_FREEZE); + return pci_legacy_suspend_late(dev); if (pm && pm->freeze_noirq) { int error; @@ -1179,7 +1179,7 @@ static int pci_pm_poweroff_noirq(struct device *dev) return 0; if (pci_has_legacy_pm_support(pci_dev)) - return pci_legacy_suspend_late(dev, PMSG_HIBERNATE); + return pci_legacy_suspend_late(dev); if (!pm) { pci_fixup_device(pci_fixup_suspend_late, pci_dev);