From patchwork Tue Oct 25 14:50:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manivannan Sadhasivam X-Patchwork-Id: 10856 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1059203wru; Tue, 25 Oct 2022 08:09:56 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7LBnG/h7YAOhK44yWBSQ2gOdzVmTbBX6+DFi03wGVvRMeJ2M+taG6OD3XmyRcGr1D8KMRP X-Received: by 2002:a05:6402:2707:b0:45c:d8a3:6cfc with SMTP id y7-20020a056402270700b0045cd8a36cfcmr36526030edd.269.1666710596599; Tue, 25 Oct 2022 08:09:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666710596; cv=none; d=google.com; s=arc-20160816; b=Pyjd2X4SL9n7HjIoc1ld3PQRoLmcu+qCFbdv0oBUWC9ocboG8WIx9A1Jn7cOnDtXWO l176UANYwXGjt3I2Ul6tkubRHz41wuUVQua9jJmBXGi7vVW95/cZW0dyZrKSs1mdP0uS x19IU7gABtxqfOMfAfpTVXgdM253kyk0JUTXdwN7ZFCc5zCO8zAlSp0usPz96qNPP4ce Zk4Bn2KZ8kM5Ca/4vjdndqz0APrdlsd2nWicsKhSSHQ5CwVUOG2THvw5tpSivUcibsY+ /DEc4i+8CRWeBvLwXh/yy2817Y835W/awcjoJnxI6Xc767I3eQk4OR5BF6+y+fidG/Jj OrYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=1hyDFi6BwQQxvnWgZlqZn5l8SdU7JiBSKsGQ5Uy8Nc4=; b=aYfwnIjkrB2PKiQ+rZQJeCXThn6yUsHzDghVFzL1L3WlKcDtTWRtk9bnbbem1u+rTw PCx9HHbZTiroiI11tty0bdfMPdnlqu8DvXJNmc9RPeV1hFCtiyy5X7ghjTymuRTxL3rx pqws90fHC16wxc228wqkTdZY41BjM4Cp7tJb/Bwg2WGc0ZS1HJnf+vZQEjZonCIuQ7no 16QWp9xi93tBUBAuU0BXuJC0PM1nnpgFHpU+JKDRZHt/v3PyUsCm/ON2rTJiJjPUJKNW ArN1AkgPaK1Mii8GreL2z9RejYHmfdntPLlsXZaldlJtyyhJUecClG4Z73GGgEgmi+LR zg3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B+Ho+V5z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nb3-20020a1709071c8300b007919d2f6517si3445629ejc.737.2022.10.25.08.09.26; Tue, 25 Oct 2022 08:09:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=B+Ho+V5z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232877AbiJYOv0 (ORCPT + 99 others); Tue, 25 Oct 2022 10:51:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232806AbiJYOvU (ORCPT ); Tue, 25 Oct 2022 10:51:20 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D0DE19DDA5 for ; Tue, 25 Oct 2022 07:51:19 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id s22-20020a17090a075600b002130d2ad62aso5426996pje.2 for ; Tue, 25 Oct 2022 07:51:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1hyDFi6BwQQxvnWgZlqZn5l8SdU7JiBSKsGQ5Uy8Nc4=; b=B+Ho+V5zB8khfJJf/JNSmJRTSBXzjK3/x2iH3IUW+3k8ukGumO3PIT4Oqu0Ueygspo Vax2mYHRn2gpHjoLFcFFmWflLnvWKnMY9lYch7r2RvnYa9NaxwNLlKdOHv6NxwoPqHKb E2Ft8mkq25TGJCuJ2K7Wn0a77Rua6pyNJ0UHG6tAGUFmEiVT3pnuTayxVJVMJslVe3ZO 41Ddwg65oinyJTz77lx+aN0zPcydn/SJnS45njc2YRDeuIIJ7sx6rn1iFvMKCb6g3gd7 2c3NrnvBmGQhyfYPpMlquqS4Q8pfJhArF6UC494/fU/JNumwwESFGCrhQlCl0ZQ403vg gO/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1hyDFi6BwQQxvnWgZlqZn5l8SdU7JiBSKsGQ5Uy8Nc4=; b=Ses4bC9Tar7jNVTeLfimNrGOCt2brSUfe5TBRqtPTVWgOJe1b9IQ5Vo380aNoLiydr v4BfD+jaGotKZKD0WJ1LcRu+cAVYgzP/RALS6Zf5/G2ZDAaqJYUFD19TdCymSY4UZs6v vnQbj97WpyfFt7hBBd3QvOILD5qnPvuH6N2vNSQhAvUx+mRyuAelFL9GDtRcu56WJKQX LyyDZAkbdlwxwyjXPGfQ/iVlbqs4pTLdlhhTo7S9bTMwEiyYejw6ufzSwkuboTSYZniC +/U52ZWuUL5cplvEvwiGM7UnFzpcF18CmD9JdYvLmZk4wFO+nl9DuYKmMiaBYdHjffJK T3TQ== X-Gm-Message-State: ACrzQf31mUQrWV/9gWvTpJiDxgzloWhZY9dT7Bo5YL5I+yh57/DBh28C JBQDQbe/QWfbBmsUON36uaIXv6jeGsNkNATUOA== X-Received: by 2002:a17:90b:1c82:b0:1ee:eb41:b141 with SMTP id oo2-20020a17090b1c8200b001eeeb41b141mr46560042pjb.143.1666709478981; Tue, 25 Oct 2022 07:51:18 -0700 (PDT) Received: from localhost.localdomain ([117.193.208.236]) by smtp.gmail.com with ESMTPSA id n14-20020a170903110e00b00180cf894b67sm1318765plh.130.2022.10.25.07.51.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Oct 2022 07:51:18 -0700 (PDT) From: Manivannan Sadhasivam To: kishon@kernel.org, lpieralisi@kernel.org, bhelgaas@google.com Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kw@linux.com, robh@kernel.org, vidyas@nvidia.com, vigneshr@ti.com, Manivannan Sadhasivam , Kishon Vijay Abraham I Subject: [PATCH v4 1/5] PCI: dra7xx: Use threaded IRQ handler for "dra7xx-pcie-main" IRQ Date: Tue, 25 Oct 2022 20:20:57 +0530 Message-Id: <20221025145101.116393-2-manivannan.sadhasivam@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20221025145101.116393-1-manivannan.sadhasivam@linaro.org> References: <20221025145101.116393-1-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747672730252474433?= X-GMAIL-MSGID: =?utf-8?q?1747672730252474433?= The "dra7xx-pcie-main" hard IRQ handler is just printing the IRQ status and calling the dw_pcie_ep_linkup() API if LINK_UP status is set. But the execution of dw_pcie_ep_linkup() depends on the EPF driver and may take more time depending on the EPF implementation. In general, hard IRQ handlers are supposed to return quickly and not block for so long. Moreover, there is no real need of the current IRQ handler to be a hard IRQ handler. So switch to the threaded IRQ handler for the "dra7xx-pcie-main" IRQ. Acked-by: Kishon Vijay Abraham I Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c index 38462ed11d07..4ae807e7cf79 100644 --- a/drivers/pci/controller/dwc/pci-dra7xx.c +++ b/drivers/pci/controller/dwc/pci-dra7xx.c @@ -840,7 +840,7 @@ static int dra7xx_pcie_probe(struct platform_device *pdev) } dra7xx->mode = mode; - ret = devm_request_irq(dev, irq, dra7xx_pcie_irq_handler, + ret = devm_request_threaded_irq(dev, irq, NULL, dra7xx_pcie_irq_handler, IRQF_SHARED, "dra7xx-pcie-main", dra7xx); if (ret) { dev_err(dev, "failed to request irq\n");