From patchwork Tue Oct 25 02:52:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Jason A. Donenfeld" X-Patchwork-Id: 10473 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp777568wru; Mon, 24 Oct 2022 20:13:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM42bfD5CJw5Q63EsfopFRMzbrVnvh1ggbcYEd6Sjp10NK3yZ4sFbxXj4U0QMMZYYzRwXA0f X-Received: by 2002:a17:907:3e0f:b0:791:9529:3674 with SMTP id hp15-20020a1709073e0f00b0079195293674mr30290238ejc.503.1666667618492; Mon, 24 Oct 2022 20:13:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666667618; cv=none; d=google.com; s=arc-20160816; b=ysIIWBiB0XXbKv66NYh3mxX23Yb/6epqcgmSzGOmpz3UAb1naaDcU7LCokxtbh305b I+r6pa4U94G3NazKsT6GxTGB72bFyEapIcaMaFfvf05oB/O9nVCIELaKj2P7tiUMtfMP qkRNLgR0QxW5jqW12hZRGc09wroGsLh3VEg/bGECeC+w2bi7i7153vh2nwp+jYkK7tJn xoaqbx/WEVOZlEmcyDcQleBzMuv/wOz5qfoP/n6PdNFvxtkK797BPKXNJX+6ZTOa6iCL N9aIi4VN/ttm/t1xOJum5YaKGtzqr1WUKkyxjbXl5GEKp+91AYy9E0XlbvEts6lq33iN pgew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=HrdB2bN3/cKuQJWOGVoqcQKRyLSwD5qF7A+kWTyhak4=; b=rjcvbp3FE/idZunMszr3jPiAXJOqLJSl4mYj+VHMjkXSXGeiMVHLBipds4UK3W6znH +NRTQhsfw/cCgK3ZTaPU+VIlFUUaHWn9sqGdTWyM1LuEM7kVuJB5u4IJcNghFNvL0JyM bVZOEe2X5vDSD2jntCVMJbWkUV3+H0mJgfsBZ/TZLy91IbKnUWUzGkFmezDcLHI9XHlY z7mW5xF2lj4Xu8CWCl+2NusrgiEtJa9rY6UMjchyGi7HwCl97HklYyWgeixHRIMpI5xt SorXWu4I+1HASrqkMvE8S2eqyt7E3sE2HKAeGW4MoYRvDvIjLEPgMxSNNM3M5dpJuS+K C3Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=Z0Y3sEQL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sb6-20020a1709076d8600b0077a19529760si1576999ejc.65.2022.10.24.20.13.14; Mon, 24 Oct 2022 20:13:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@zx2c4.com header.s=20210105 header.b=Z0Y3sEQL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=zx2c4.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230271AbiJYCwr (ORCPT + 99 others); Mon, 24 Oct 2022 22:52:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229800AbiJYCwq (ORCPT ); Mon, 24 Oct 2022 22:52:46 -0400 Received: from sin.source.kernel.org (sin.source.kernel.org [IPv6:2604:1380:40e1:4800::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C6FA5BC24 for ; Mon, 24 Oct 2022 19:52:45 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 688A2CE1AEF for ; Tue, 25 Oct 2022 02:52:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DF40EC433D7; Tue, 25 Oct 2022 02:52:40 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="Z0Y3sEQL" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1666666358; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HrdB2bN3/cKuQJWOGVoqcQKRyLSwD5qF7A+kWTyhak4=; b=Z0Y3sEQLNCXFcm+PNzfvF8E19WRgf6YE+BWP9l5KHuEM8a4P57Bk3AjfRlD+R79/uma1zh ySMp6gI/isQvfUPgjlM/R93eJQwLjJlaZAI434l4tLt0uy5CYeUqfq2YmQolqkRRIcJuRj CrOhzindVi72c7YMj1Rhc3qZTTtjRUI= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 3b2fc07e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Tue, 25 Oct 2022 02:52:38 +0000 (UTC) From: "Jason A. Donenfeld" To: linux-kernel@vger.kernel.org Cc: "Jason A. Donenfeld" , Dimitri Sivanich , Arnd Bergmann , Greg Kroah-Hartman Subject: [PATCH v2] misc: sgi-gru: use explicitly signed char Date: Tue, 25 Oct 2022 04:52:23 +0200 Message-Id: <20221025025223.573543-1-Jason@zx2c4.com> In-Reply-To: <202210251026.dfeqb1M2-lkp@intel.com> References: <202210251026.dfeqb1M2-lkp@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747598074345561557?= X-GMAIL-MSGID: =?utf-8?q?1747627664754054421?= With char becoming unsigned by default, and with `char` alone being ambiguous and based on architecture, signed chars need to be marked explicitly as such. This fixes warnings like: drivers/misc/sgi-gru/grumain.c:711 gru_check_chiplet_assignment() warn: 'gts->ts_user_chiplet_id' is unsigned Cc: Dimitri Sivanich Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Signed-off-by: Jason A. Donenfeld --- drivers/misc/sgi-gru/grumain.c | 6 +++--- drivers/misc/sgi-gru/grutables.h | 14 +++++++------- 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/misc/sgi-gru/grumain.c b/drivers/misc/sgi-gru/grumain.c index 9afda47efbf2..6706ef3c5977 100644 --- a/drivers/misc/sgi-gru/grumain.c +++ b/drivers/misc/sgi-gru/grumain.c @@ -152,7 +152,7 @@ static int gru_assign_asid(struct gru_state *gru) * Optionally, build an array of chars that contain the bit numbers allocated. */ static unsigned long reserve_resources(unsigned long *p, int n, int mmax, - char *idx) + signed char *idx) { unsigned long bits = 0; int i; @@ -170,14 +170,14 @@ static unsigned long reserve_resources(unsigned long *p, int n, int mmax, } unsigned long gru_reserve_cb_resources(struct gru_state *gru, int cbr_au_count, - char *cbmap) + signed char *cbmap) { return reserve_resources(&gru->gs_cbr_map, cbr_au_count, GRU_CBR_AU, cbmap); } unsigned long gru_reserve_ds_resources(struct gru_state *gru, int dsr_au_count, - char *dsmap) + signed char *dsmap) { return reserve_resources(&gru->gs_dsr_map, dsr_au_count, GRU_DSR_AU, dsmap); diff --git a/drivers/misc/sgi-gru/grutables.h b/drivers/misc/sgi-gru/grutables.h index 5efc869fe59a..8c52776db234 100644 --- a/drivers/misc/sgi-gru/grutables.h +++ b/drivers/misc/sgi-gru/grutables.h @@ -351,7 +351,7 @@ struct gru_thread_state { pid_t ts_tgid_owner; /* task that is using the context - for migration */ short ts_user_blade_id;/* user selected blade */ - char ts_user_chiplet_id;/* user selected chiplet */ + signed char ts_user_chiplet_id;/* user selected chiplet */ unsigned short ts_sizeavail; /* Pagesizes in use */ int ts_tsid; /* thread that owns the structure */ @@ -364,11 +364,11 @@ struct gru_thread_state { required for contest */ unsigned char ts_cbr_au_count;/* Number of CBR resources required for contest */ - char ts_cch_req_slice;/* CCH packet slice */ - char ts_blade; /* If >= 0, migrate context if + signed char ts_cch_req_slice;/* CCH packet slice */ + signed char ts_blade; /* If >= 0, migrate context if ref from different blade */ - char ts_force_cch_reload; - char ts_cbr_idx[GRU_CBR_AU];/* CBR numbers of each + signed char ts_force_cch_reload; + signed char ts_cbr_idx[GRU_CBR_AU];/* CBR numbers of each allocated CB */ int ts_data_valid; /* Indicates if ts_gdata has valid data */ @@ -643,9 +643,9 @@ extern struct gru_thread_state *gru_alloc_gts(struct vm_area_struct *vma, int cbr_au_count, int dsr_au_count, unsigned char tlb_preload_count, int options, int tsid); extern unsigned long gru_reserve_cb_resources(struct gru_state *gru, - int cbr_au_count, char *cbmap); + int cbr_au_count, signed char *cbmap); extern unsigned long gru_reserve_ds_resources(struct gru_state *gru, - int dsr_au_count, char *dsmap); + int dsr_au_count, signed char *dsmap); extern vm_fault_t gru_fault(struct vm_fault *vmf); extern struct gru_mm_struct *gru_register_mmu_notifier(void); extern void gru_drop_mmu_notifier(struct gru_mm_struct *gms);