From patchwork Tue Oct 25 01:03:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pedro Guilherme Siqueira Moreira X-Patchwork-Id: 10463 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp762964wru; Mon, 24 Oct 2022 19:30:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5KfZv/lOJsIQJa9+L6dBvxq34VGQUjhRpTr4PxsuQJJCMPjyRPGSthdyhYRmR9q9fPYfGM X-Received: by 2002:aa7:8895:0:b0:566:35c:8d4 with SMTP id z21-20020aa78895000000b00566035c08d4mr36464843pfe.19.1666665038200; Mon, 24 Oct 2022 19:30:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666665038; cv=none; d=google.com; s=arc-20160816; b=SfAXdLHQ0KbdX4Zf0ik9NViXYXVH4w+ctupXLrL6KLOMyLQvMyUP719qqbwUnZ1reO z7YpBe3H30ZnUphtWN3KFpD+OAIizqY6gAKvgE8XGmpeRxMAReocO8kN23JhQ5FSHv4x UIdMi6VrNwKrNw/zb2DXX364VmKf7YRHh0WesYPKYZpzbuBvZIrqBAlw+lfLNmMO9O9o dpT7KYkuCVagApV3ze36W6LEmAh90e88wSRLRvWgkTNIjBKDfh/zi5WL42HiydETjPZ0 Vm2dVKjqwwfvYfl8XAhK90kEuHy/uIOat2V0lroLrjjxoDQKxlMKH8z/BOFmXm+s1MR0 W5HQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Fb6+Bu0CDk9Li2g/4CPrvafMoIefqwm8ZPHOykhhMbs=; b=PWxwvCEOywkLGTj4mF7wfIxKczFgNBF7kBh8zwwnWWTwYSsZIhouL2bStGZzrK8U4O XIXRDro5tpovJPBhJ6M73vW6L7O9vBEbzR8lBuROEl3Owd2fM9iLalauAmaV8VCs0AMI I2r7mnfTVDKXXTK9keBvIC4dBJTn4HmPynonnhpRS0kE4NJ2fodaMVvy3N3v/aYNe7V5 lPGZlJU9RrTZUYuE4+MpRbFejaqeh6UpVLR0+763k9CwglnbLsIbNt9wRSSlRfK5ztTn 352D8lwv6aVxZ17NF+v/wSV1xfwJMkc1l6zRlwHl6meDJCc0Bv49B5BT1XBGOirX8/w3 t8Xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d37-20020a630e25000000b00462fbd5b46bsi1519529pgl.35.2022.10.24.19.30.07; Mon, 24 Oct 2022 19:30:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231594AbiJYBwY (ORCPT + 99 others); Mon, 24 Oct 2022 21:52:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229993AbiJYBwM (ORCPT ); Mon, 24 Oct 2022 21:52:12 -0400 X-Greylist: delayed 1499 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 24 Oct 2022 18:52:10 PDT Received: from gateway20.websitewelcome.com (gateway20.websitewelcome.com [192.185.63.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B14FE100 for ; Mon, 24 Oct 2022 18:52:09 -0700 (PDT) Received: from atl1wswcm03.websitewelcome.com (unknown [50.6.129.164]) by atl1wswob01.websitewelcome.com (Postfix) with ESMTP id 0F68F40130A5C for ; Tue, 25 Oct 2022 01:04:11 +0000 (UTC) Received: from br984.hostgator.com.br ([162.241.203.37]) by cmsmtp with ESMTP id n8MUoU5oVPUI8n8MUodCQ4; Tue, 25 Oct 2022 01:04:10 +0000 X-Authority-Reason: nr=8 Received: from [177.194.67.221] (port=43054 helo=arch-avell.meuintelbras.local) by br984.hostgator.com.br with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1on8MU-001BYl-6W; Mon, 24 Oct 2022 22:04:10 -0300 From: Pedro Guilherme Siqueira Moreira To: laurent.pinchart@ideasonboard.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Pedro Guilherme Siqueira Moreira Subject: [PATCH 2/3] media: uvc_driver: fix assignments inside if statements Date: Mon, 24 Oct 2022 22:03:02 -0300 Message-Id: <20221025010303.570815-2-pedro.guilherme@espectro.eng.br> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221025010303.570815-1-pedro.guilherme@espectro.eng.br> References: <20221025010303.570815-1-pedro.guilherme@espectro.eng.br> MIME-Version: 1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - br984.hostgator.com.br X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - espectro.eng.br X-BWhitelist: no X-Source-IP: 177.194.67.221 X-Source-L: No X-Exim-ID: 1on8MU-001BYl-6W X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: (arch-avell.meuintelbras.local) [177.194.67.221]:43054 X-Source-Auth: pedro.guilherme@espectro.eng.br X-Email-Count: 5 X-Source-Cap: ZXNwZWN0ODU7ZXNwZWN0ODU7YnI5ODQuaG9zdGdhdG9yLmNvbS5icg== X-Local-Domain: yes X-CMAE-Envelope: MS4xfH2c4wsLicNgms0II66j0m6IQ7EDzho0yMYqa/sd9jPz6Ba3B9FxSisJtB2qAbEzwT4XSOlix0jA0MHvAryO9AhHXmoVIucqnDQBl6DRcMlXz/rASQra ACeTHbpHYM5297mcw8/xlChdpFhf09VzY7+bD46kgTaLd/L34Qw1V+9yUG0MNHrbHJ1e0AP3I3PPYA3cDr46I4Hd3ogMLTHBCXMt1rqUd7hx/7Acrzinhm2c X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747624958965492117?= X-GMAIL-MSGID: =?utf-8?q?1747624958965492117?= Signed-off-by: Pedro Guilherme Siqueira Moreira --- drivers/media/usb/uvc/uvc_driver.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c index b591ad823c66..7b6c97ad3a41 100644 --- a/drivers/media/usb/uvc/uvc_driver.c +++ b/drivers/media/usb/uvc/uvc_driver.c @@ -1174,7 +1174,8 @@ static int uvc_parse_control(struct uvc_device *dev) buffer[1] != USB_DT_CS_INTERFACE) goto next_descriptor; - if ((ret = uvc_parse_standard_control(dev, buffer, buflen)) < 0) + ret = uvc_parse_standard_control(dev, buffer, buflen); + if (ret < 0) return ret; next_descriptor: @@ -2213,7 +2214,8 @@ static int uvc_probe(struct usb_interface *intf, usb_set_intfdata(intf, dev); /* Initialize the interrupt URB. */ - if ((ret = uvc_status_init(dev)) < 0) { + ret = uvc_status_init(dev); + if (ret < 0) { dev_info(&dev->udev->dev, "Unable to initialize the status endpoint (%d), status interrupt will not be supported.\n", ret);