From patchwork Mon Oct 24 21:03:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caleb Connolly X-Patchwork-Id: 10368 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp686636wru; Mon, 24 Oct 2022 15:44:07 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5U133ysRze7Yl5kjQ4ojQGLfqtr6AWmEC3VRBOpvYO/foMfNwBg/s9K+yNp7HqRAcWZWJ8 X-Received: by 2002:a05:6402:510c:b0:45d:50f:f65 with SMTP id m12-20020a056402510c00b0045d050f0f65mr31978063edd.313.1666651447687; Mon, 24 Oct 2022 15:44:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666651447; cv=none; d=google.com; s=arc-20160816; b=Nzw5B4SY6R+YcnFiW4X8aloOCEqUuNTkKhNeZBSWHY58tZKBdiwHPeK61nD7dwxmnq vwczc+CLfO5CeZggAAAtlgsg73YIpMPoZJIT7B3qmmDsRQmqzrT+m5fQaW3YFZCLD5y0 yoqv+g9mExJqV3gjHYJKK20GmXtVVXzrDWd6JrWcTVfD/UzzzToly3V9RWCFN5VSIxdU bq3DOu9p6NQq3FRNJE0JL8w72mDH2k1jWWrbaGDLcdLzu+0srFLXTF9062gOBtbkBFfB pWwtrNPjiy5LJcMWjQFdtUbKqgLaeHIzeVha01exdPxjjBnVrqh3n3n/oC0qucv7QFiU toxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gMy8fNjmNzlGvq0/9Re1VqvlS3AEt0sKadKDb4szu5Q=; b=HoIHhI69nw3/xcW1daxtUF8ENEYTtn6WotJs2PvU9Pv3PJAGl5REA5/kVoBhQgKMm9 Vn7fIWS0aP/1B5/L2p/h/a800QwgctOdnv6+8zqcDPYAA1r28ggpOAL3ZXWrL/GBkp57 ZjGdKolWsVb0tqo19aw6D8NGYf36qr8O1xbUjlk4GmeoYI0vM9EZCRRNiWlxpaQLLkDS eIlrv56FFXy8AJXROOvc5SzYbS/8FhR1ko8HV0gCgw3q9gAtDSPuIXFUk+sR9VrcZvZU 28u4rn47k7FsHoUep+mbzp8IPtv+oefMWIC0WYkrtDUunDgjohmKczg0WbiTTd1Yphew eR+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="shGu8u/X"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u19-20020a056402065300b00461d3757956si904247edx.326.2022.10.24.15.43.44; Mon, 24 Oct 2022 15:44:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="shGu8u/X"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231235AbiJXWm5 (ORCPT + 99 others); Mon, 24 Oct 2022 18:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231217AbiJXWmb (ORCPT ); Mon, 24 Oct 2022 18:42:31 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B224C253EF5 for ; Mon, 24 Oct 2022 14:05:28 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id v1so17974946wrt.11 for ; Mon, 24 Oct 2022 14:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=gMy8fNjmNzlGvq0/9Re1VqvlS3AEt0sKadKDb4szu5Q=; b=shGu8u/X7rau+Qjr01j/O/+w/o4okP+Q6G0rU6XQkrdZARkbCGqY46PYugDR8YsEuK 7eIxQ0lQiV7eD8UWws9Joj+Iy8DhqFw4dwl6lt2bVqI9dnzZ1qIAOglvK3FNsh+AHF5A Gg/+g4oB3HS4+QqWWHSbirSy22P06pvxiOU1MPKBkT4CF75o6HlqJvgx1KPVlsQX7g2r 1yyHUlbDD8kk1kjHomL05FAmSH7/vBfHfKa9mfRbmFtGymbByznnV6Z5tLH3VZGETmqo +GNyqzU962M+CuaGKE7P7Bk62Oh/sPV/oq93WY+c/Z6pXm7ua2xvNu4QfbIgHoV0zsB5 qrEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gMy8fNjmNzlGvq0/9Re1VqvlS3AEt0sKadKDb4szu5Q=; b=etQEk+dXizofGZvCCEtmSlTDoKsRgAGdNpGDdOWyb5pq69qx5vVc5j7FIWYKubbDPn iclrQwk8+frm8DbR/UWz9hFFq+08RQ51QdplV87hkQdmafKQ9Z0JjS0sXLM1Q8+9ibvy DADRpN7M0FJUZjktN7w5E2UCOEw5wrCzytgxl5ovzQJg7GhcFjg0YFhSpH2PBvAkN5mq TtxZeMaA8ZTGBB/Dtb6rdN05Jgj727I1ggOWdVjnhsIvAjTBJRpgk44EFTj1NV/GSsrn DNCJubVoloCpfe25pTFMVKrZTZkKiUZbg4DezBIXQiP3xt8d5w2p+UkUndjitPkspV24 fISQ== X-Gm-Message-State: ACrzQf1wDM5gfUfUXso23duKLV66CzvHcMsxs+sch2Y/rSyBgNXDyf82 36BbCY/ofEzg/9a5OuENqhhRGQ== X-Received: by 2002:a5d:5a86:0:b0:22e:57ef:ce3c with SMTP id bp6-20020a5d5a86000000b0022e57efce3cmr23167776wrb.433.1666645433041; Mon, 24 Oct 2022 14:03:53 -0700 (PDT) Received: from localhost.localdomain (cpc76482-cwma10-2-0-cust629.7-3.cable.virginm.net. [86.14.22.118]) by smtp.gmail.com with ESMTPSA id i17-20020adfded1000000b002364835caacsm602371wrn.112.2022.10.24.14.03.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Oct 2022 14:03:52 -0700 (PDT) From: Caleb Connolly To: Alex Elder , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jami Kettunen Cc: Caleb Connolly , Alex Elder , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH v2 1/2] net: ipa: fix v3.5.1 resource limit max values Date: Mon, 24 Oct 2022 22:03:31 +0100 Message-Id: <20221024210336.4014983-1-caleb.connolly@linaro.org> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747610708002293487?= X-GMAIL-MSGID: =?utf-8?q?1747610708002293487?= Some resource limits on IPA v3.5.1 have their max values set to 255, this causes a few splats in ipa_reg_encode and prevents the IPA from booting properly. The limits are all 6 bits wide so adjust the max values to 63. Fixes: 1c418c4a929c ("net: ipa: define resource group/type IPA register fields") Signed-off-by: Caleb Connolly Reviewed-by: Alex Elder --- V1: https://lore.kernel.org/netdev/20221024165636.3979249-1-caleb.connolly@linaro.org/ Changes since v1: * Apply the correct fix for v3.1 which has the opposite issue where the masks are wrong rather than the values. * Split into two patches --- drivers/net/ipa/data/ipa_data-v3.5.1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ipa/data/ipa_data-v3.5.1.c b/drivers/net/ipa/data/ipa_data-v3.5.1.c index 383ef1890065..42f2c88a92d4 100644 --- a/drivers/net/ipa/data/ipa_data-v3.5.1.c +++ b/drivers/net/ipa/data/ipa_data-v3.5.1.c @@ -179,10 +179,10 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { static const struct ipa_resource ipa_resource_src[] = { [IPA_RESOURCE_TYPE_SRC_PKT_CONTEXTS] = { .limits[IPA_RSRC_GROUP_SRC_LWA_DL] = { - .min = 1, .max = 255, + .min = 1, .max = 63, }, .limits[IPA_RSRC_GROUP_SRC_UL_DL] = { - .min = 1, .max = 255, + .min = 1, .max = 63, }, .limits[IPA_RSRC_GROUP_SRC_UC_RX_Q] = { .min = 1, .max = 63,