diff mbox series

[01/11] media: cedrus: remove superfluous call

Message ID	20221024201515.34129-2-jernej.skrabec@gmail.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Jernej Skrabec <jernej.skrabec@gmail.com> To: mripard@kernel.org, paul.kocialkowski@bootlin.com Cc: mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, samuel@sholland.org, hverkuil-cisco@xs4all.nl, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Jernej Skrabec <jernej.skrabec@gmail.com> Subject: [PATCH 01/11] media: cedrus: remove superfluous call Date: Mon, 24 Oct 2022 22:15:05 +0200 Message-Id: <20221024201515.34129-2-jernej.skrabec@gmail.com> In-Reply-To: <20221024201515.34129-1-jernej.skrabec@gmail.com> References: <20221024201515.34129-1-jernej.skrabec@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	media: cedrus: Format handling improvements and 10-bit HEVC support \| [00/11] media: cedrus: Format handling improvements and 10-bit HEVC support [01/11] media: cedrus: remove superfluous call [02/11] media: cedrus: Add format reset helpers [03/11] media: cedrus: use helper to set default formats [04/11] media: cedrus: Add helper for checking capabilities [05/11] media: cedrus: Filter controls based on capability [06/11] media: cedrus: set codec ops immediately [07/11] media: cedrus: Remove cedrus_codec enum [08/11] media: cedrus: prefer untiled capture format [09/11] media: cedrus: initialize controls a bit later [10/11] media: cedrus: Adjust buffer size based on control values [11/11] media: cedrus: h265: Support decoding 10-bit frames

Commit Message

Jernej Škrabec Oct. 24, 2022, 8:15 p.m. UTC

  cedrus_try_fmt_vid_out() is called two times inside
cedrus_s_fmt_vid_out(), but nothing changes between calls which would
influence output format. Remove first call, which was added later.

Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
---
 drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Paul Kocialkowski Oct. 25, 2022, 3:08 p.m. UTC | #1

Hi Jernej,

On Mon 24 Oct 22, 22:15, Jernej Skrabec wrote:
> cedrus_try_fmt_vid_out() is called two times inside
> cedrus_s_fmt_vid_out(), but nothing changes between calls which would
> influence output format. Remove first call, which was added later.

Thanks for the cleanup!

Acked-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

Cheers,

Paul

> Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
> ---
>  drivers/staging/media/sunxi/cedrus/cedrus_video.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> index 33726175d980..1c3c1d080d31 100644
> --- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> +++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
> @@ -309,10 +309,6 @@ static int cedrus_s_fmt_vid_out(struct file *file, void *priv,
>  	struct vb2_queue *peer_vq;
>  	int ret;
>  
> -	ret = cedrus_try_fmt_vid_out(file, priv, f);
> -	if (ret)
> -		return ret;
> -
>  	vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
>  	/*
>  	 * In order to support dynamic resolution change,
> -- 
> 2.38.1
>

diff mbox series

Patch

diff --git a/drivers/staging/media/sunxi/cedrus/cedrus_video.c b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
index 33726175d980..1c3c1d080d31 100644
--- a/drivers/staging/media/sunxi/cedrus/cedrus_video.c
+++ b/drivers/staging/media/sunxi/cedrus/cedrus_video.c
@@ -309,10 +309,6 @@  static int cedrus_s_fmt_vid_out(struct file *file, void *priv,
 	struct vb2_queue *peer_vq;
 	int ret;
 
-	ret = cedrus_try_fmt_vid_out(file, priv, f);
-	if (ret)
-		return ret;
-
 	vq = v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type);
 	/*
 	 * In order to support dynamic resolution change,