diff mbox series

amba: Drop redundant assignments of the system PM callbacks

Message ID 20221024121601.156514-1-ulf.hansson@linaro.org
State New
Headers
Series amba: Drop redundant assignments of the system PM callbacks |

Commit Message

Ulf Hansson Oct. 24, 2022, 12:16 p.m. UTC 
  If the system PM callbacks haven't been assigned, the PM core falls back to
invoke the corresponding the pm_generic_* helpers for the device. Let's
rely on this behaviour and drop the redundant assignments.

Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/amba/bus.c | 6 ------
 1 file changed, 6 deletions(-)

Comments

Linus Walleij Oct. 31, 2022, 8:34 p.m. UTC | #1 
On Mon, Oct 24, 2022 at 2:16 PM Ulf Hansson <ulf.hansson@linaro.org> wrote:

> If the system PM callbacks haven't been assigned, the PM core falls back to
> invoke the corresponding the pm_generic_* helpers for the device. Let's
> rely on this behaviour and drop the redundant assignments.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

I think the AMBA patches normally go in through Russell's
patch tracker.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index 110a535648d2..ff7454a38058 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -421,12 +421,6 @@  static int amba_pm_runtime_resume(struct device *dev)
 #endif /* CONFIG_PM */
 
 static const struct dev_pm_ops amba_pm = {
-	.suspend	= pm_generic_suspend,
-	.resume		= pm_generic_resume,
-	.freeze		= pm_generic_freeze,
-	.thaw		= pm_generic_thaw,
-	.poweroff	= pm_generic_poweroff,
-	.restore	= pm_generic_restore,
 	SET_RUNTIME_PM_OPS(
 		amba_pm_runtime_suspend,
 		amba_pm_runtime_resume,