From patchwork Mon Oct 24 11:34:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9814 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp555026wru; Mon, 24 Oct 2022 09:58:47 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4oR82/FSVwYiC3TXxSFoN+VYolBD6npYubG5sDmRN9WKJ83IBTo+BHCBzWv4i3HWjpUsvp X-Received: by 2002:a17:902:e28b:b0:186:ada2:8173 with SMTP id o11-20020a170902e28b00b00186ada28173mr4897148plc.138.1666630727349; Mon, 24 Oct 2022 09:58:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666630727; cv=none; d=google.com; s=arc-20160816; b=pdNQklI6BxWCBCpRE5Ne66Qmk3WM4l3TEgvJHYHnZHPhPOV5zrvKi+6jJbz+ygLcOI CPS52PmyZhfrc2aAMQ6/f1TG0TA0ILApa64MrV+YDvtVk00ZtJl6mtDGdwNaj/aQaPzl Y+ZDTF4Hm1kctMoNI3qjJ4nIsqsnwrAxNKrivlV+aK+vC8xCKXaCeLmH0PDGbPJn+x7e lKSvwimN5C3DOOq5QDSznNVzEb1JPopWw09sl06BOyLrLAbig0syg3MhmGqE4Nz2Gsrt /gl1RpfW75Mt7scWLobU3q6pSN6Z19il2yxy9wFf03Way3hok2zCx/ZBnb3rhCT81J56 la3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bE7pJzwuSbmIW2rROGGiRIhnFuFiC1cJ6Yzg4Ybsm2w=; b=wNCIZfG28z0m+mEkKeQnCA7OFb1xwvUOvQFleaDbzlqB6XM1tPp9/uO5RFC+T64dWL 8hFliTPGj2/dIigBr6A6ugeaG7yUvLdaEO25iR/5r/zOzLZQ0S7Um8S4cJDHA8T9COAw AE2rAYCdBqOA//LNy/hIET7Bhs/7RqAquAsk6AB/kLfEqq6Nd2ImIEVq/9NzAAnFgVTY O6T+85ssGjPfgmtbl4wHY7XB40pqMTk0klj9ZDPp++cEnUFRDH0I37ppfi27uQabvl4B kzF5bBp0DIoa2gsgqDzx1z3Ql6XauuRPgAIUeJXA/y7LtKZZbvqQYFA2nLHAJhI+Dcc/ YbOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=URpWaG1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y8-20020a1709029b8800b00178b5e035fcsi31363628plp.496.2022.10.24.09.58.31; Mon, 24 Oct 2022 09:58:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=URpWaG1Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232776AbiJXQwa (ORCPT + 99 others); Mon, 24 Oct 2022 12:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235214AbiJXQtO (ORCPT ); Mon, 24 Oct 2022 12:49:14 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E63FB23BCF; Mon, 24 Oct 2022 08:32:20 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9840BB819C2; Mon, 24 Oct 2022 12:55:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4DB2C433D7; Mon, 24 Oct 2022 12:55:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666616117; bh=R3OOxD0b/lzsey6csCpZswCCEPbCxK1njo5BTZ39HCw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=URpWaG1QnC94GM0ivcMEPbBqB2dt3ws4XPaQSwAfjc/cC0UIKzY12Alyo4/kkTZkq xGO33Lw7cTYeHzFSU+eqFnG4SmC3MweTblJjxLfY2LtLCvLBTIf5SwD2Vwgjg0ehP4 EJ0W9SHF+HWJ5CnSqcwFdCQz/uuwghdKYRxun45g= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Maxime Ripard , Stefan Wahren , Stephen Boyd , Sasha Levin Subject: [PATCH 5.15 508/530] clk: bcm2835: Make peripheral PLLC critical Date: Mon, 24 Oct 2022 13:34:12 +0200 Message-Id: <20221024113108.027652789@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747588981734423096?= X-GMAIL-MSGID: =?utf-8?q?1747588981734423096?= From: Maxime Ripard [ Upstream commit 6c5422851d8be8c7451e968fd2e6da41b6109e17 ] When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system. It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled. It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash. Reported-by: Noralf Trønnes Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech Reviewed-by: Stefan Wahren Acked-by: Noralf Trønnes Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index 2200305a722d..f17b65d546e9 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1785,7 +1785,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLC_LOADPER, .hold_mask = CM_PLLC_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), /* * PLLD is the display PLL, used to drive DSI display panels.