From patchwork Mon Oct 24 11:33:05 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9470 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp480414wru; Mon, 24 Oct 2022 07:20:57 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7inubvNFPRS2t1QqzH0Sn/1imof7SKt8A/1x3JeK+rrkGXzkW6WdasNd99yWXWwUZ1jglF X-Received: by 2002:a17:907:a042:b0:7a0:3323:2883 with SMTP id gz2-20020a170907a04200b007a033232883mr11638704ejc.37.1666621257108; Mon, 24 Oct 2022 07:20:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666621257; cv=none; d=google.com; s=arc-20160816; b=Cr06icIXkgjYJ1Avw+dWZoFyJwDqAO8/FD6erm6s6/SStrrSmL0DNMgZfwZC4YBxAG duaCwnkeIAsz5MqGwOQ9T6WAEvYyw5cVxCOMk3ruDUaleRiOItUISR/KtNDPvVSr9Hdz U1Va5PDAlmx+KZhpnNr+9+JaVGu23sMuBtfYxrcyHBiQ4LyBaO3vrVSPMurimB5+xIDy zzgsGE9ciSimzgA9zoOkwWAudxn11Cg+aN1OjtI73BTqbZUFmJ0vKgs4/JvoUjLQxErD DnW7UHDRzmM7fy2jz+HWmrwk1P3GNZRMsUhZFJl12mp6FUG8o6cLSd1GziKRFDGobqbV W6DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=W6RtlWT8x0pmICpaDTsW6LskFeMbxp+eisDi9MMYD90=; b=DJkCUG0IQyNTOTpPGfJxp2RMEjycBNIj69Dteo8Vhgj7zu6Da0iI3uxJcQ45QYpxc4 IzImLh66r5lfqaKwbWxgBhOhFRJl1QbH2VwJx4zP8kyjgxAboGFCjru5DMyAuj/kFSQT /UxWpG1IlUV36mNq77aEf/6QMueXDuGq+cb44ti7V/bga6eGlecf9N5oYZnvKNC198ck mjNgdLEgLUjnAAWJevxS1E3I+YcribW5sJgJT/z76aP5D7rphx2+BgeNDhxUy3QnGjxI rZGyFh+L9FmWJb75dGu8kYsViW4D+NP+dhc1myOrsKRqCYrBgAcV43yXUV6Gn8Z8ZMJC tStQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GtQOYc9b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i20-20020a05640242d400b0045c93142111si35737741edc.70.2022.10.24.07.20.29; Mon, 24 Oct 2022 07:20:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GtQOYc9b; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235566AbiJXOTF (ORCPT + 99 others); Mon, 24 Oct 2022 10:19:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234503AbiJXOOC (ORCPT ); Mon, 24 Oct 2022 10:14:02 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E35DECAE74; Mon, 24 Oct 2022 05:54:03 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E8CC3612C9; Mon, 24 Oct 2022 12:52:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 090CDC433D6; Mon, 24 Oct 2022 12:52:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615939; bh=uZwYTbK6c6lRKIRXzBwGFW3FOhNrXvNl0/chneSWtEo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GtQOYc9bZzlC8LLQaEMDzAw3Dpb9VtoPt8eHNWlflN0JQX5TXtUYhka48LiLX++tO Aq05wYWLFHWIUggP1uelVCtzIiJfxCsY/WGo/9oHXCSORaW+yxWIgUKFQ6+pNcNdi6 EXLJ9Rn/XaxHHeqhtECM8GY94ARG1X0XVOPlNGyY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Luiz Augusto von Dentz , Sungwoo Kim , Sasha Levin Subject: [PATCH 5.15 441/530] Bluetooth: L2CAP: Fix user-after-free Date: Mon, 24 Oct 2022 13:33:05 +0200 Message-Id: <20221024113105.024736583@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747579050897270628?= X-GMAIL-MSGID: =?utf-8?q?1747579050897270628?= From: Luiz Augusto von Dentz [ Upstream commit 35fcbc4243aad7e7d020b7c1dfb14bb888b20a4f ] This uses l2cap_chan_hold_unless_zero() after calling __l2cap_get_chan_blah() to prevent the following trace: Bluetooth: l2cap_core.c:static void l2cap_chan_destroy(struct kref *kref) Bluetooth: chan 0000000023c4974d Bluetooth: parent 00000000ae861c08 ================================================================== BUG: KASAN: use-after-free in __mutex_waiter_is_first kernel/locking/mutex.c:191 [inline] BUG: KASAN: use-after-free in __mutex_lock_common kernel/locking/mutex.c:671 [inline] BUG: KASAN: use-after-free in __mutex_lock+0x278/0x400 kernel/locking/mutex.c:729 Read of size 8 at addr ffff888006a49b08 by task kworker/u3:2/389 Link: https://lore.kernel.org/lkml/20220622082716.478486-1-lee.jones@linaro.org Signed-off-by: Luiz Augusto von Dentz Signed-off-by: Sungwoo Kim Signed-off-by: Sasha Levin --- net/bluetooth/l2cap_core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c index 4e7dd41a8314..8f1a95b9d320 100644 --- a/net/bluetooth/l2cap_core.c +++ b/net/bluetooth/l2cap_core.c @@ -4309,6 +4309,12 @@ static int l2cap_connect_create_rsp(struct l2cap_conn *conn, } } + chan = l2cap_chan_hold_unless_zero(chan); + if (!chan) { + err = -EBADSLT; + goto unlock; + } + err = 0; l2cap_chan_lock(chan); @@ -4338,6 +4344,7 @@ static int l2cap_connect_create_rsp(struct l2cap_conn *conn, } l2cap_chan_unlock(chan); + l2cap_chan_put(chan); unlock: mutex_unlock(&conn->chan_lock);