From patchwork Mon Oct 24 11:32:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9581 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp528003wru; Mon, 24 Oct 2022 09:01:37 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7HdPkz56D3Gb+Ez82S16IuFaiNdb79vF01I4O6lVHZx7/L+017K0P8DXLkdZnIUiVCzZqL X-Received: by 2002:a17:907:78a:b0:782:2223:a7cd with SMTP id xd10-20020a170907078a00b007822223a7cdmr27594769ejb.532.1666627297044; Mon, 24 Oct 2022 09:01:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666627297; cv=none; d=google.com; s=arc-20160816; b=rM85ODbLZeQmlzWKYBfHfGTbBgm//DAnoO9cGab7yKZr0H/nn1HX+YmpTk0ohHLuc8 2vVi9c+8DPbVJS1FbBkFlpvkbrRhD4L7MBQRyifkGx/mZwYLC0ePezL5a+vMpf+yweJH 1F0JMaqdEjzpN+zp1eDDaAYKvL2wrhChPGy4X3XfqkRIVz/a+OWyJdY8UQ0gSrUisN7m qZqL/kjHNL6nmLuzz9/hw22grQSmakodsUNE7Yu8DErfEr7XZc4WgolAKKOaiWZvjW7O lJ2tBdOrzHYjTj++wMyQtRHa6n5LDYaQ+w1rRDT54CbaptuZBYA75SYQRZfO2h1pjNsb r0dA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=feCAVzKSRR+Ery0m+LbYNxHF3S63UzOxYrzL8RONMrU=; b=X2WzvWmOiJrhKAcnTsbkSjGOj4gfRFPeJMHllLl0ZDyuFqYtEC7HaZBV8ZYSzM4pRo XFy7CwlWH+AVC6UF45108ZQYTxk6T/yPmSNRgEQVaNY1QsJR98WZHQ4brHjQxUm+LPOz qwxeN2mr46UsBziBftqQOXFWHs+Y0IcTWI9fVJJK++Qq7anagFzOUa8PsB3/JKcJ6YNz irohlHjtRskdciAUHSf3/1e/w4KDOdQpfdP3A9qZ0EWlK6KX6viSEgS8PmTaeE3gCzNv nkdqTOy+QTJfVe7BPBvE44OIWEY707phyu6HOfoqZSoqvair2yJvyKiLCaZNlteEjeAb Ebyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Vot93DP5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qa9-20020a170907868900b007ab1b8b71a6si178244ejc.40.2022.10.24.09.01.11; Mon, 24 Oct 2022 09:01:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Vot93DP5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231508AbiJXP7b (ORCPT + 99 others); Mon, 24 Oct 2022 11:59:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229952AbiJXP6N (ORCPT ); Mon, 24 Oct 2022 11:58:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C66AA3E9; Mon, 24 Oct 2022 07:53:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B108BB819FC; Mon, 24 Oct 2022 12:50:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D7674C433C1; Mon, 24 Oct 2022 12:50:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615835; bh=HfJh30DdhUe2kdQVdZhS5+2PUjyfa70Ky08wy1J+XWY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Vot93DP5DnvUmvlA8/hmjbGx9yYO0vexhREst9sIazbCYQo5F2dLTCCBMkB83p8po VVbCprfar7EhxTYMH8YfLsQMQWNsGDdX26EL30KNRXMtZ4KrqI4D4UeRE17jkVFfhD vqVnef62MXYB1TaxRh1FkZv1z8qgiIp8j2Q98rPs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Uladzislau Rezki (Sony)" , "Paul E. McKenney" , Frederic Weisbecker , Neeraj Upadhyay , Josh Triplett , Steven Rostedt , Mathieu Desnoyers , Lai Jiangshan , Joel Fernandes , Michal Hocko , Sasha Levin Subject: [PATCH 5.15 402/530] rcu: Back off upon fill_page_cache_func() allocation failure Date: Mon, 24 Oct 2022 13:32:26 +0200 Message-Id: <20221024113103.267372098@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747585384689856541?= X-GMAIL-MSGID: =?utf-8?q?1747585384689856541?= From: Michal Hocko [ Upstream commit 093590c16b447f53e66771c8579ae66c96f6ef61 ] The fill_page_cache_func() function allocates couple of pages to store kvfree_rcu_bulk_data structures. This is a lightweight (GFP_NORETRY) allocation which can fail under memory pressure. The function will, however keep retrying even when the previous attempt has failed. This retrying is in theory correct, but in practice the allocation is invoked from workqueue context, which means that if the memory reclaim gets stuck, these retries can hog the worker for quite some time. Although the workqueues subsystem automatically adjusts concurrency, such adjustment is not guaranteed to happen until the worker context sleeps. And the fill_page_cache_func() function's retry loop is not guaranteed to sleep (see the should_reclaim_retry() function). And we have seen this function cause workqueue lockups: kernel: BUG: workqueue lockup - pool cpus=93 node=1 flags=0x1 nice=0 stuck for 32s! [...] kernel: pool 74: cpus=37 node=0 flags=0x1 nice=0 hung=32s workers=2 manager: 2146 kernel: pwq 498: cpus=249 node=1 flags=0x1 nice=0 active=4/256 refcnt=5 kernel: in-flight: 1917:fill_page_cache_func kernel: pending: dbs_work_handler, free_work, kfree_rcu_monitor Originally, we thought that the root cause of this lockup was several retries with direct reclaim, but this is not yet confirmed. Furthermore, we have seen similar lockups without any heavy memory pressure. This suggests that there are other factors contributing to these lockups. However, it is not really clear that endless retries are desireable. So let's make the fill_page_cache_func() function back off after allocation failure. Cc: Uladzislau Rezki (Sony) Cc: "Paul E. McKenney" Cc: Frederic Weisbecker Cc: Neeraj Upadhyay Cc: Josh Triplett Cc: Steven Rostedt Cc: Mathieu Desnoyers Cc: Lai Jiangshan Cc: Joel Fernandes Signed-off-by: Michal Hocko Reviewed-by: Uladzislau Rezki (Sony) Signed-off-by: Paul E. McKenney Signed-off-by: Sasha Levin --- kernel/rcu/tree.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index a4a9d68b1fdc..63f7ce228cc3 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -3419,15 +3419,16 @@ static void fill_page_cache_func(struct work_struct *work) bnode = (struct kvfree_rcu_bulk_data *) __get_free_page(GFP_KERNEL | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN); - if (bnode) { - raw_spin_lock_irqsave(&krcp->lock, flags); - pushed = put_cached_bnode(krcp, bnode); - raw_spin_unlock_irqrestore(&krcp->lock, flags); + if (!bnode) + break; - if (!pushed) { - free_page((unsigned long) bnode); - break; - } + raw_spin_lock_irqsave(&krcp->lock, flags); + pushed = put_cached_bnode(krcp, bnode); + raw_spin_unlock_irqrestore(&krcp->lock, flags); + + if (!pushed) { + free_page((unsigned long) bnode); + break; } }