From patchwork Mon Oct 24 11:30:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9416 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp478629wru; Mon, 24 Oct 2022 07:17:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM451QEpSP7STAyzkHOGOFC/weZ8fiRhMI7XojAS49NzGTJGgvJHXZzVbTEXsfjpnVIgbtRJ X-Received: by 2002:a17:906:db0c:b0:77b:7d7d:5805 with SMTP id xj12-20020a170906db0c00b0077b7d7d5805mr28724587ejb.726.1666621060305; Mon, 24 Oct 2022 07:17:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666621060; cv=none; d=google.com; s=arc-20160816; b=j1tMv5wUs1ZoDNBO16TcNWGZc3B31hl7tR99z0z1d+kSUnIjVoaDBrj/7W/bw4Mgi2 kxBCMHJyBjX7JfbI9HYol9H9VIqFblO2GIxO8SvORNfaIEA/A0/9tnPaCC1phNDJSZyC PKsAR5YY1IItwlQNJvv8FVSMlNRfHM08hdVMf7kKp1kqFcAzaR/nHPJjNbb9NbXmSNY6 kM3ug0jEMBBswIRcIxVzmOr43EubVFNq5mupKsb/6HmEY7jvYk2ppybMTVAUAXT4NpO+ wULk2jz09YsUP95eNAZDDQByoT+hkzQaOSVVDbAddMipDjE9ThXQT6tdqupPRkZ5fegx RVrw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=WjoXa8Zt14lxad46j760H2XqKZUIdxZYDgFPK+9gOJ0=; b=BpeD3QcRVV6h5wUE/rQ7QI7mJxVEN0cqzF3Uw5U3rMSJ0c+UiHZmfI8J8KgZhWJJw8 83/2W3KYvh2zhcd5NPCxdqKtsmusclZadqLcwGyjNDEJa7zicAaAmpBSHD46XRbmwpQZ DoYl4kjILwLmdGG8qSGCdH4lhyp0oyN6nhbKbu3Ymsqj7wgf7aihDXQo6Cc1GtTPo0v6 cvaq/s9X+m+4tRrA1pVNARkFGtg+ld7yla3T2vDeX1FKi4/l5Cg20CGJdPVol9EGqDhF QWMa7JWlHHi42DCTthXmANP0zfDn8WqywArkj099cH17BxHXSWBRQAughlaU2uBW6rTU ICIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WdDiX1+C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sd42-20020a1709076e2a00b0078dcdbb3e87si28365704ejc.530.2022.10.24.07.17.13; Mon, 24 Oct 2022 07:17:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=WdDiX1+C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234618AbiJXOAU (ORCPT + 99 others); Mon, 24 Oct 2022 10:00:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40362 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236984AbiJXN7E (ORCPT ); Mon, 24 Oct 2022 09:59:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3DC2638DD; Mon, 24 Oct 2022 05:46:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5BED4612DD; Mon, 24 Oct 2022 12:46:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67A4CC433D6; Mon, 24 Oct 2022 12:46:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615570; bh=d4xHh/EUCkCOVmUiHgDNQoi2lFnlAt1QKWLdSYAR6Ls=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WdDiX1+CFBdAOQDvrZGHbfyp0kZTPQq4jhdo+pdhw5olwABlJ+18VtkR6x3/lV2RU oBOQjL19o/SclBJnMuTJoFcWLLszXpq8usR4ntc86nXZ3J6Ei06bO4pRLrtaBDKphg WYMZs6vdFaYTvKKVFN1lLflXDHMrpLSp39MBeB2c= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hacash Robot , William Dean , Miquel Raynal , Sasha Levin Subject: [PATCH 5.15 302/530] mtd: devices: docg3: check the return value of devm_ioremap() in the probe Date: Mon, 24 Oct 2022 13:30:46 +0200 Message-Id: <20221024113058.737968780@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747578844757937202?= X-GMAIL-MSGID: =?utf-8?q?1747578844757937202?= From: William Dean [ Upstream commit 26e784433e6c65735cd6d93a8db52531970d9a60 ] The function devm_ioremap() in docg3_probe() can fail, so its return value should be checked. Fixes: 82402aeb8c81e ("mtd: docg3: Use devm_*() functions") Reported-by: Hacash Robot Signed-off-by: William Dean Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20220722091644.2937953-1-williamsukatube@163.com Signed-off-by: Sasha Levin --- drivers/mtd/devices/docg3.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c index 5b0ae5ddad74..27c08f22dec8 100644 --- a/drivers/mtd/devices/docg3.c +++ b/drivers/mtd/devices/docg3.c @@ -1974,9 +1974,14 @@ static int __init docg3_probe(struct platform_device *pdev) dev_err(dev, "No I/O memory resource defined\n"); return ret; } - base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); ret = -ENOMEM; + base = devm_ioremap(dev, ress->start, DOC_IOSPACE_SIZE); + if (!base) { + dev_err(dev, "devm_ioremap dev failed\n"); + return ret; + } + cascade = devm_kcalloc(dev, DOC_MAX_NBFLOORS, sizeof(*cascade), GFP_KERNEL); if (!cascade)