From patchwork Mon Oct 24 11:30:19 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9926 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp595575wru; Mon, 24 Oct 2022 11:34:27 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6siav2gjLq/R1oF/kbCxVZZf2wldMH3rA5XVXsz6FTgbX380PyIq0T5FMqKv2Jifu+B1Lb X-Received: by 2002:a63:211a:0:b0:451:f444:3b55 with SMTP id h26-20020a63211a000000b00451f4443b55mr28396404pgh.60.1666636467675; Mon, 24 Oct 2022 11:34:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666636467; cv=none; d=google.com; s=arc-20160816; b=y+M6zq/z0XJ8Yzw0KFMiESaPFhGMUa1n2Aco7HTXLU3mi82WFkA03sGJT+WePhlLJ3 KtSrc5EQM5bGTMMbBPP5OmkG3tlrWpl1DTO4ls1AVd62CWb+7MfXrsf85D9yaWwScFlw APGU105Ed4VoIk06FJpcDHGMUAQlobGb8Usdva7EjqSFz6D6RqUnQ/tqTAlYlkuk8ffy KLoZZOiIqe1vWBJtA/xIPEBBpPi+wziEtVW6xveWSkoCgVFqIOT+X57Y37SFpdv7qiY6 QNXChzrEQTdcMAB2pNLBjJBeUxb6FUHBUp20+pknudcKCBKvLo2umz15DKzkKVOjPa6W NfqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=P7he3boLJjoDyg4JyksFE1FjKdheQ/OWPJaEtn3/zDQ=; b=Ziou0PNI8qvO2jpQj6f9QYjJsRSZ68cxdos601yqwKk1F64v8kqPY7N0lCelcssLlj xjds5MhHBU+sW1N29X0lAdVp6ujyqBsHZWGYYoCsTqP6AyUGx5W1Un4P8map4YghRZy2 0wmK2RGmqMk9lzU+2yB4nstuh6Vv1jPyKJW+JQVreZvfLlouuhaR/6V+OfPc8Apvvxe1 /c+6ATCYmMB37EY3wK1F9MkkqOMBi/Mfa5yxSUJZE/kCviKdHZ+eo2LyKhq8nu6Kme1g 93vhfkpyZGF2jqFDcrlMDML2ihQTdeOf9LKIdH6fEX9jvBpXHO2DUxmcjYSbqKMRXDBd 0a8g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VroJbDnu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h2-20020a056a00218200b0053ef8a89c71si431403pfi.194.2022.10.24.11.34.13; Mon, 24 Oct 2022 11:34:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=VroJbDnu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbiJXSYr (ORCPT + 99 others); Mon, 24 Oct 2022 14:24:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232120AbiJXSY0 (ORCPT ); Mon, 24 Oct 2022 14:24:26 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20E7520F5C; Mon, 24 Oct 2022 10:05:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 094BC612B1; Mon, 24 Oct 2022 12:45:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9490C433D6; Mon, 24 Oct 2022 12:44:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615499; bh=X38VWH2et6l8j7ErF92H2f0hZx1DchmzPhdw98JHFCs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=VroJbDnu6tpBQKoof3DD5+frb3CYeY2AcTV/8ylrMG7blE62h+Qmh63wJgLAQFl+P hF7sV9P4bagNmmnB3viw0QcVTPFmqWFhCAilrahmP2xuyZRHfnMrcms9eVnyDhpk/1 tY3wH/Wcq8wlCSi6U8aUmq90Y5J4ylAujUcO/Pf0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Stephen Boyd , Sasha Levin Subject: [PATCH 5.15 275/530] clk: oxnas: Hold reference returned by of_get_parent() Date: Mon, 24 Oct 2022 13:30:19 +0200 Message-Id: <20221024113057.523545189@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747595000465545501?= X-GMAIL-MSGID: =?utf-8?q?1747595000465545501?= From: Liang He [ Upstream commit 1d6aa08c54cd0e005210ab8e3b1e92ede70f8a4f ] In oxnas_stdclk_probe(), we need to hold the reference returned by of_get_parent() and use it to call of_node_put() for refcount balance. Fixes: 0bbd72b4c64f ("clk: Add Oxford Semiconductor OXNAS Standard Clocks") Signed-off-by: Liang He Link: https://lore.kernel.org/r/20220628143155.170550-1-windhl@126.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/clk-oxnas.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk-oxnas.c b/drivers/clk/clk-oxnas.c index 78d5ea669fea..2fe36f579ac5 100644 --- a/drivers/clk/clk-oxnas.c +++ b/drivers/clk/clk-oxnas.c @@ -207,7 +207,7 @@ static const struct of_device_id oxnas_stdclk_dt_ids[] = { static int oxnas_stdclk_probe(struct platform_device *pdev) { - struct device_node *np = pdev->dev.of_node; + struct device_node *np = pdev->dev.of_node, *parent_np; const struct oxnas_stdclk_data *data; const struct of_device_id *id; struct regmap *regmap; @@ -219,7 +219,9 @@ static int oxnas_stdclk_probe(struct platform_device *pdev) return -ENODEV; data = id->data; - regmap = syscon_node_to_regmap(of_get_parent(np)); + parent_np = of_get_parent(np); + regmap = syscon_node_to_regmap(parent_np); + of_node_put(parent_np); if (IS_ERR(regmap)) { dev_err(&pdev->dev, "failed to have parent regmap\n"); return PTR_ERR(regmap);