From patchwork Mon Oct 24 11:29:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9359 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp476106wru; Mon, 24 Oct 2022 07:13:15 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7B4sJfY/cOrdXaLHeoFU/P2xYJtB8+xG0o7BbBzdm9QFh1dSVqdt6OdErfv0gs1IS/t9ZH X-Received: by 2002:a17:906:6a1a:b0:7a1:a9e5:7869 with SMTP id qw26-20020a1709066a1a00b007a1a9e57869mr9922824ejc.708.1666620795032; Mon, 24 Oct 2022 07:13:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666620795; cv=none; d=google.com; s=arc-20160816; b=L2wdj8PZcAEB42w/yIWBz+sX8tRFXOI8+6GRGKt73oOrbvv3A9QtzQM4jw/xK77yC/ dxm5XJxnQSKIJzOK3RmBAypgCmt5LZCOuVHxPBjfFzPc/Gndzcgspl1GB4VyIb39PZiO cYGzikV2UIFGhCY5nHUVOLoMVQKOFKY7mNQyQTGmbrkewmoHmg9KzYbkdz1VQRPnhSU8 IXGTVC178phdcrUv5zZFEWWKRrR1gpGxPsYwN7mMdPC1M8DZEJjCSWxykKTRMvmv7iUU ad8i5j+PrXzHuRttGcmyz2IJTbhZhihyeTBsAUuE0lsASVCY3K2uJOvFw1b5zQOJhAqF eq6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/4n7HZjbFgZDgQTf2QXX5TYweo94YCwGyMrBy/uDx0s=; b=DPlQzmsF6IwhiEoXQ3rA3TEuEyRQ0AMJZrzI2FgTBF4OWDloSLnUKoaanX/5bxhcHx rwVAVwwodIPLBgbKjr54PITeqRMXgqkj9TJucifFMJxsgiDo+FxtNNghKszCyOgr825d LQcLFMtaAr4lEPBamqnjVEgcy7FkfwX0ItAVOrh9mWjLGaknrvUIE/Ys7xb9uUl9I65T R7Ud2WulLaHw8lUM+rp2qfzhnehTcLE0BfMnxlovtR8Ny6h04bxkpAAkAvs0PETWhAx4 cyiMu+A9t3E72za/+Z7GnOV7k20E1oLEJ954eB8eUk2KpksUONyCJO+0UirJw6dG9B9d Z7Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cV4wlzEX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id wu13-20020a170906eecd00b0078db3556bddsi30754708ejb.804.2022.10.24.07.12.50; Mon, 24 Oct 2022 07:13:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=cV4wlzEX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236855AbiJXN4n (ORCPT + 99 others); Mon, 24 Oct 2022 09:56:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236902AbiJXNy3 (ORCPT ); Mon, 24 Oct 2022 09:54:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 127C3BD068; Mon, 24 Oct 2022 05:43:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 52A26612A1; Mon, 24 Oct 2022 12:43:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 64852C433C1; Mon, 24 Oct 2022 12:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615431; bh=ImaiAK7jHhbV8YcUYAVGJfAjkWTkK3o5h2uJ0SiwaWk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cV4wlzEXgtm3ySn7sF5mMx11GydR3LDllgSRKuwf7Z4Iapc/muF7cXIi1RHnB/+Ok 63o5fOtRT+BitZd1xUwFaVb9zhmVpUbHKB2MtLAghEUS2MliToWkAaL1s0xwLSckJ0 GCspZKGfUQ58Zar05711qzk4DxQ0VZw7PWLCLqBs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Liang He , Krzysztof Kozlowski , Sasha Levin Subject: [PATCH 5.15 248/530] memory: of: Fix refcount leak bug in of_lpddr3_get_ddr_timings() Date: Mon, 24 Oct 2022 13:29:52 +0200 Message-Id: <20221024113056.340926529@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747578566822479418?= X-GMAIL-MSGID: =?utf-8?q?1747578566822479418?= From: Liang He [ Upstream commit 48af14fb0eaa63d9aa68f59fb0b205ec55a95636 ] We should add the of_node_put() when breaking out of for_each_child_of_node() as it will automatically increase and decrease the refcount. Fixes: 976897dd96db ("memory: Extend of_memory with LPDDR3 support") Signed-off-by: Liang He Signed-off-by: Krzysztof Kozlowski Link: https://lore.kernel.org/r/20220719085640.1210583-2-windhl@126.com Signed-off-by: Sasha Levin --- drivers/memory/of_memory.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/memory/of_memory.c b/drivers/memory/of_memory.c index d0a80aefdea8..1791614f324b 100644 --- a/drivers/memory/of_memory.c +++ b/drivers/memory/of_memory.c @@ -283,6 +283,7 @@ const struct lpddr3_timings if (of_device_is_compatible(np_tim, tim_compat)) { if (of_lpddr3_do_get_timings(np_tim, &timings[i])) { devm_kfree(dev, timings); + of_node_put(np_tim); goto default_timings; } i++;