From patchwork Mon Oct 24 11:28:36 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9776 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp554064wru; Mon, 24 Oct 2022 09:56:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM61Xh1Dm5j+80tGyDUJZ79hsrT8nLKVm1/HnY7YNV3gsA+28l27k0JgginnoBzGF8PbU8mv X-Received: by 2002:a63:231a:0:b0:46b:208f:1e57 with SMTP id j26-20020a63231a000000b0046b208f1e57mr29700203pgj.57.1666630572567; Mon, 24 Oct 2022 09:56:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666630572; cv=none; d=google.com; s=arc-20160816; b=sdPV+Y3jmwpdMpHXkCUtlEQTRUQ4zQe2mkB4Tjx0jKrOsrUjNfb2el+HIns90gS30H UXn1o1UP819nJ4TZMNZO8pA0YQHI0nzAWs4g0bYb3dxwndGlsEosz8BGfRH57A7QcXIZ vBmP32Q1VscT/v92vAxdsblq4BBHQ289sy8goYHAIEmcghZNyV1obRjsDC/6v/nbsYAg /TpAb3uif9SL92rwdDmGiXsI0XtXNOe13FNwqQffwywlEZMqoQ9KpkFTrxiOdG57Rtw6 IcR5WbQY0QpPaHRQqXEllHPBzqS+28ZPyLf+ftelqTLTm3Q9TMc3LWtok+UgmrAK7sDA NmyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9loi+RJXGJKkAOf52vAUBZEUHC4iV9bH0JbjLrBdpdE=; b=Aho/lOdXi0Ku7qBzOJDs2NS9WzSG6FS/6MLJRPeSq07P60r5b84vm54EmJgHocV47o /MWZVySVPBVpS951di1wQAjMwTyVvu/wnG7tIMEXx+zovgqOp2hekqcEyDJN5iN0b6/l o7aIwAhGruqHygphmiEBZO+WQ6jykezNpSc5TkUlgg0NtM1QAIGL6eqiBoH2bcakMwN5 ODi/l8Obr9Siw95MuRUb6ch2kUfM5+tAFAtNSM62ok0GIpJ58REE0vBBWpDOr+BoE6F7 lmxmTxRtXpQCqMt6ikwIq9Q3PSAKWVHwq4acwi+2JqvM+a09lhab6d4QPPb+TRZa6uNA e2iQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hPd5O8YT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c17-20020a170903235100b00186a43ad5d0si5228125plh.604.2022.10.24.09.55.58; Mon, 24 Oct 2022 09:56:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hPd5O8YT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235047AbiJXQrC (ORCPT + 99 others); Mon, 24 Oct 2022 12:47:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42996 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234911AbiJXQpf (ORCPT ); Mon, 24 Oct 2022 12:45:35 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4858919609A; Mon, 24 Oct 2022 08:31:05 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 38B6FB81916; Mon, 24 Oct 2022 12:40:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 87B09C4314B; Mon, 24 Oct 2022 12:40:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615229; bh=EYIqJscOmZjxGOv8e3LQX5jCVCOB3o69li2tCiav0a4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hPd5O8YTJAw7A0nxLsQBuGqzuXjeeKIUkLbw6SiCeDz3SsRimsgUPn/qPS87yxzYy 1P24dymrYBDDFBkBI7vFL/r03Gnbi5fn0Xzv6TQ0nPJdaokHYRBa/xMc+QPfXS3bb7 3/ePJDmLZ4jmKUIpi8gxMrrrmpog+E3pxdNyEs3k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 5.15 172/530] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Mon, 24 Oct 2022 13:28:36 +0200 Message-Id: <20221024113052.805878329@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747588819375633498?= X-GMAIL-MSGID: =?utf-8?q?1747588819375633498?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index 395c31060950..a74ded84c2ac 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2925,12 +2925,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];