From patchwork Mon Oct 24 11:27:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9294 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp463587wru; Mon, 24 Oct 2022 06:48:17 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7YGaOXnFRVFduU0rdAZbQkTcZZY4TNWwKLnPohbPV+8MTueMiQwN6eTMHPNIB3ScUw5BYG X-Received: by 2002:a17:906:d54d:b0:78e:2fbf:ca2a with SMTP id cr13-20020a170906d54d00b0078e2fbfca2amr28318953ejc.488.1666619297608; Mon, 24 Oct 2022 06:48:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666619297; cv=none; d=google.com; s=arc-20160816; b=wucN+F7jt2boJL3V/4++NtCiVqJukFfh+Bzdd/EsZDHdz3wpFW7zSY7zLudWIocCqH CWmFgeVFGs1VD3FZrt8k8jpd5qdQSptMsOQX7L2PSFw9mhq3QlvoOLx1ai/Jc1W5oMXC ZIldvorgTJLSUbdR/C5E2+el+1pPVFio41qtfU/tAU/8zYRrb7/2Ua2ZMqnYgVZAkP9C vg6x4vUeLOEinFI0H0+/+2C3n8DPtRj3cQJkYxQ/onmSdv6M7IopjqO1D+uiYgESakyN e/oeK20etL7kZDqKZDaX0UHRxLBi/ao90eFVjbxWTtvi41I8MZMp2P5e5Ff/X1HU+Nw6 bL3Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=K/uOf0SUzijjEeSOOrVTXr5R6N7cfa3tA6My4fiILe0=; b=tMWfRYCgmNI8gcwZ47arFT8Rs6pTJ6HarcvyDeUN83TuT+Mg0DyorckeM2bQkUfjpi i9QTM3P0E0cTQOvhI1QWNrf1X5LZe35J8BP3SYyVTPIYnsGHs48u7l4QeI4zoxUEBMQe SX6sVndeow2vAV9DjylICCpZnjXtlMdVUwJQ3SetMTMIxVnLELuBm8KrGwrGav+ka2Jn B6mkcz0RoqQMx6O2IzKvWuijyRoVkRaryMn1WBFipFpEWJrMhDhvVzX6duLhhvvx4IhZ gzNG/bLO05qLAr2LzdZbNW32h9HsKXVoUQ5iMAU1Wc3oYHLEoOMUKN91r6Z0qPZCdF+o yyrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HZcamFQh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qb26-20020a1709077e9a00b0077f4a46a179si30659807ejc.454.2022.10.24.06.47.53; Mon, 24 Oct 2022 06:48:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=HZcamFQh; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236392AbiJXNq3 (ORCPT + 99 others); Mon, 24 Oct 2022 09:46:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236556AbiJXNoZ (ORCPT ); Mon, 24 Oct 2022 09:44:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 230F536BC7; Mon, 24 Oct 2022 05:40:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E131B61333; Mon, 24 Oct 2022 12:38:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F350FC433B5; Mon, 24 Oct 2022 12:38:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666615117; bh=yMjsvMrwdteaqkm298N96x25owWkPZMp9jiYpvA0zcQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HZcamFQhyPoJSOKNE2NoZfwXm7w7m9MSO5gLjK/lFP06YyP0xA9wvTAMIadK9jUN8 ytf8+gdWhOBbup/lHLuc+zlhDiWZtotC3A6CBfrK4bem+jq+KB/kXHHIbIC3fNXCuK 0bHIsidMdRn0E+9mHofwuBujuV1WlGj9OblPBN8Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Alex Elder , stable Subject: [PATCH 5.15 127/530] staging: greybus: audio_helper: remove unused and wrong debugfs usage Date: Mon, 24 Oct 2022 13:27:51 +0200 Message-Id: <20221024113050.819048627@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576996632455338?= X-GMAIL-MSGID: =?utf-8?q?1747576996632455338?= From: Greg Kroah-Hartman commit d517cdeb904ddc0cbebcc959d43596426cac40b0 upstream. In the greybus audio_helper code, the debugfs file for the dapm has the potential to be removed and memory will be leaked. There is also the very real potential for this code to remove ALL debugfs entries from the system, and it seems like this is what will really happen if this code ever runs. This all is very wrong as the greybus audio driver did not create this debugfs file, the sound core did and controls the lifespan of it. So remove all of the debugfs logic from the audio_helper code as there's no way it could be correct. If this really is needed, it can come back with a fixup for the incorrect usage of the debugfs_lookup() call which is what caused this to be noticed at all. Cc: Johan Hovold Cc: Alex Elder Cc: Greg Kroah-Hartman Cc: stable Link: https://lore.kernel.org/r/20220902143715.320500-1-gregkh@linuxfoundation.org Signed-off-by: Greg Kroah-Hartman --- drivers/staging/greybus/audio_helper.c | 11 ----------- 1 file changed, 11 deletions(-) --- a/drivers/staging/greybus/audio_helper.c +++ b/drivers/staging/greybus/audio_helper.c @@ -3,7 +3,6 @@ * Greybus Audio Sound SoC helper APIs */ -#include #include #include #include @@ -116,10 +115,6 @@ int gbaudio_dapm_free_controls(struct sn { int i; struct snd_soc_dapm_widget *w, *next_w; -#ifdef CONFIG_DEBUG_FS - struct dentry *parent = dapm->debugfs_dapm; - struct dentry *debugfs_w = NULL; -#endif mutex_lock(&dapm->card->dapm_mutex); for (i = 0; i < num; i++) { @@ -139,12 +134,6 @@ int gbaudio_dapm_free_controls(struct sn continue; } widget++; -#ifdef CONFIG_DEBUG_FS - if (!parent) - debugfs_w = debugfs_lookup(w->name, parent); - debugfs_remove(debugfs_w); - debugfs_w = NULL; -#endif gbaudio_dapm_free_widget(w); } mutex_unlock(&dapm->card->dapm_mutex);