From patchwork Mon Oct 24 11:25:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9228 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp460885wru; Mon, 24 Oct 2022 06:42:39 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6RrGW9EKdmddLi0LS9PDFubK2v9A9+o2LOZYgCSPvFgmJIHF5Cw1P2chVYpLfUuSfp/Q54 X-Received: by 2002:a17:907:2c74:b0:7a1:d333:f214 with SMTP id ib20-20020a1709072c7400b007a1d333f214mr9590072ejc.14.1666618959624; Mon, 24 Oct 2022 06:42:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618959; cv=none; d=google.com; s=arc-20160816; b=e+MXU5SS0fyzuGo/FW+7gperLP4ZpQJnN+nmFfA8MVpBgmAu6xsALW0veh/2uV5DzA 5lzL8K67DfOgbluAuT/87BxoMiaYmilSNJqvTbf5SWw82uf43x87f6BwX0yn7z0kXSj9 One7Py8JQTR0RFMmhVlnmPr6ZuanUGF43iu01+QhvgGvxKbh7TrZjNyaUeI8E9+Yn499 jVNrT4yS16orhsXW5ZqlSx1qNVG0Z3ugvemVr7NoaUFxC8M6j+a77erWSC/w8a72d2JI qA9V06HBRSHH+SLdxotsEZBflCbu8ujlFPs2WejfH12EFtKm5+9lCpKFv2kOcAgkgYdM HQSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=S6GbZhxpBauDT3+juuAju/7MX1o+kn+jonzLbUmJghU=; b=HMZFEAO6w44yp/8tfvWZhSkmxL/2IhQuaTLUZD46k6CPMYHTSY3i6oAoZdTX4a91I7 Yh/dw3i3A7vCrsRaMNEaDMLTzrFKd3JOpBStXRaZk/f/dvaDLtAxynqhPNSbJiPQVDG6 Gv+sm8RcK5UhkhPV9L5Hx6T7iL3kh1ZTvxUnHiKScv6Ynq9zKbpI/cDPH/ZSNoD23ms0 3hG5nyT0F4v1AwjbCty/AudV/PzkXDI0stxBCHGjQ5y2SrgkZSa4Ww3+YIDfpf3BE3n6 k/UQ6D1iypKyjMMyw59ltpXdW6IE5/Mt7Z4CGUnklDPAi1rxly7hNZ25VT6VnGCMAZq5 hr7w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GA4xddy5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y16-20020a056402359000b0045d15f39bf4si31394394edc.479.2022.10.24.06.42.08; Mon, 24 Oct 2022 06:42:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=GA4xddy5; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235546AbiJXNgv (ORCPT + 99 others); Mon, 24 Oct 2022 09:36:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43312 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230351AbiJXNbQ (ORCPT ); Mon, 24 Oct 2022 09:31:16 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0948114012; Mon, 24 Oct 2022 05:34:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BEC2B612CC; Mon, 24 Oct 2022 12:34:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE5C3C433D6; Mon, 24 Oct 2022 12:34:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614867; bh=IvwASr8RTNKgyZy3lEju6d9fkApkwhWOGq2Q3YmZ8Dc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GA4xddy5GvfFAijrJLXkisuQzyTcwrDydHRIN3y4PIRAAvqJzCpgLvEKRl4xc6cqL f+RAEeXwRSUjMJ+C27HFiJ8mBRvWOM6nezOHuX0Vx6Qr+bZ0IqJGEOleN/Rqi5G8cf etbU1mywt0imM+db622R+AqFrkkWqYYl1w5eD3KE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Callum Osmotherly , Takashi Iwai Subject: [PATCH 5.15 006/530] ALSA: hda/realtek: remove ALC289_FIXUP_DUAL_SPK for Dell 5530 Date: Mon, 24 Oct 2022 13:25:50 +0200 Message-Id: <20221024113045.280379224@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113044.976326639@linuxfoundation.org> References: <20221024113044.976326639@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576642387553305?= X-GMAIL-MSGID: =?utf-8?q?1747576642387553305?= From: Callum Osmotherly commit 417b9c51f59734d852e47252476fadc293ad994a upstream. After some feedback from users with Dell Precision 5530 machines, this patch reverts the previous change to add ALC289_FIXUP_DUAL_SPK. While it improved the speaker output quality, it caused the headphone jack to have an audible "pop" sound when power saving was toggled. Fixes: 1885ff13d4c4 ("ALSA: hda/realtek: Enable 4-speaker output Dell Precision 5530 laptop") Signed-off-by: Callum Osmotherly Cc: Link: https://lore.kernel.org/r/Yz0uyN1zwZhnyRD6@piranha Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/patch_realtek.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/patch_realtek.c +++ b/sound/pci/hda/patch_realtek.c @@ -8847,7 +8847,6 @@ static const struct snd_pci_quirk alc269 SND_PCI_QUIRK(0x1028, 0x0871, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0872, "Dell Precision 3630", ALC255_FIXUP_DELL_HEADSET_MIC), SND_PCI_QUIRK(0x1028, 0x0873, "Dell Precision 3930", ALC255_FIXUP_DUMMY_LINEOUT_VERB), - SND_PCI_QUIRK(0x1028, 0x087d, "Dell Precision 5530", ALC289_FIXUP_DUAL_SPK), SND_PCI_QUIRK(0x1028, 0x08ad, "Dell WYSE AIO", ALC225_FIXUP_DELL_WYSE_AIO_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x08ae, "Dell WYSE NB", ALC225_FIXUP_DELL1_MIC_NO_PRESENCE), SND_PCI_QUIRK(0x1028, 0x0935, "Dell", ALC274_FIXUP_DELL_AIO_LINEOUT_VERB),