From patchwork Mon Oct 24 11:33:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9216 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp459307wru; Mon, 24 Oct 2022 06:39:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45Yc+xX7ygkinV1R0PkW1+uV3Bty59Kg5Dl2U9NdcsbiiBi11ccymW+Ov+c6QVpLpn0edM X-Received: by 2002:a17:906:2699:b0:781:a473:9791 with SMTP id t25-20020a170906269900b00781a4739791mr27851820ejc.644.1666618745934; Mon, 24 Oct 2022 06:39:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618745; cv=none; d=google.com; s=arc-20160816; b=KYaVDXR9yNJTx88ZtL2Fqb41fVK5zxEcPVj8772+djLSrOmcG+NPOsxuEiD2gzqlk/ CBErJ/5QHkdKOZi7Zlhr7JFg7++mgePXDl7a3VE7/9B+4K9JvDGCYfmyPeMFrdhOc1Bk 9V0kDbEVS/dDGF9co9FmwlHakU2MXqE5t072PlVrzb3M4hdEgsoG69rxZQ7NNCnhB358 Is1SXisc7Awm48msgxEyNbBGthpUN/+7zyc1LRVTDk566MeVwIROTxqz4M2IdXhjW/6c 3M7Kim2T1K5DXr9TrEU9Ge9rbbDcGml1o5KNVL9cV1E9pUTH3CO3KaohzqSS1ZZi6zWV 0l0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=u5PtEDXFOiXhs3A2XlO1TlyuCpjSbEaazdjWk3Zg3M0=; b=zDMAB8IYdt9s5J+z/lAYWqSJglA6uWRtdIaHPs5zT15Klus0yPIFKUl5RNTwfojOfE 88k9xqZpyVwSDTjG7PfntPHRCVui8Kba+p4Z98NZD+udHscmUdPW6CHhSUioLPWivqZf igA3BAePK6rjcImdQO8We0zQUwCSL0oe15n/zBCBB3BQBdM5lR3PkOP7QzzOrjiHuJeK FnRElDW4GMEELc0Y5H62YIoN9xv1+aaRFPW25iMqfllu/V7vZZrIplFbgxVSsRLa4A7W 6bgSn2BRRWzif2fpcyvBIg8IzfgshyP4C//u8KEm7cvEITQ1HkbpbqnAQo3y51uuFSu3 QP4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="0tp/xru1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hv12-20020a17090760cc00b0078c4a772ea7si31643150ejc.11.2022.10.24.06.38.41; Mon, 24 Oct 2022 06:39:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="0tp/xru1"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231589AbiJXNfb (ORCPT + 99 others); Mon, 24 Oct 2022 09:35:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236328AbiJXNat (ORCPT ); Mon, 24 Oct 2022 09:30:49 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 55263ACF6A; Mon, 24 Oct 2022 05:33:42 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 88C4E612EA; Mon, 24 Oct 2022 12:32:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 993D7C433C1; Mon, 24 Oct 2022 12:32:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614778; bh=prPm0ATSNYkvAd08Z+HiA2aBLpQEIm265Ft6Sna0oPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=0tp/xru1ebgVDh0Tix0um9yZweiWsF7OA4bECs0Q9Pe8xamIm60YK/6jyePZzxnw1 aMlEhaCRUZCy2fYdJSoyEcrh1MbK3LV0QJNx9aTfEZGYRhHOZwtjsGDkyS7ugHf9FP gqrQ1ejgKeqfUq66/j7XHFl9M7m9HMh+Ozegem70= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot , Tetsuo Handa , Alexander Aring , Stefan Schmidt , Sasha Levin Subject: [PATCH 5.10 383/390] net/ieee802154: dont warn zero-sized raw_sendmsg() Date: Mon, 24 Oct 2022 13:33:00 +0200 Message-Id: <20221024113039.294009918@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576418412179494?= X-GMAIL-MSGID: =?utf-8?q?1747576418412179494?= From: Tetsuo Handa [ Upstream commit b12e924a2f5b960373459c8f8a514f887adf5cac ] syzbot is hitting skb_assert_len() warning at __dev_queue_xmit() [1], for PF_IEEE802154 socket's zero-sized raw_sendmsg() request is hitting __dev_queue_xmit() with skb->len == 0. Since PF_IEEE802154 socket's zero-sized raw_sendmsg() request was able to return 0, don't call __dev_queue_xmit() if packet length is 0. ---------- #include #include int main(int argc, char *argv[]) { struct sockaddr_in addr = { .sin_family = AF_INET, .sin_addr.s_addr = htonl(INADDR_LOOPBACK) }; struct iovec iov = { }; struct msghdr hdr = { .msg_name = &addr, .msg_namelen = sizeof(addr), .msg_iov = &iov, .msg_iovlen = 1 }; sendmsg(socket(PF_IEEE802154, SOCK_RAW, 0), &hdr, 0); return 0; } ---------- Note that this might be a sign that commit fd1894224407c484 ("bpf: Don't redirect packets with invalid pkt_len") should be reverted, for skb->len == 0 was acceptable for at least PF_IEEE802154 socket. Link: https://syzkaller.appspot.com/bug?extid=5ea725c25d06fb9114c4 [1] Reported-by: syzbot Fixes: fd1894224407c484 ("bpf: Don't redirect packets with invalid pkt_len") Signed-off-by: Tetsuo Handa Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20221005014750.3685555-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt Signed-off-by: Sasha Levin --- net/ieee802154/socket.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/net/ieee802154/socket.c b/net/ieee802154/socket.c index 7edec210780a..ecc0d5fbde04 100644 --- a/net/ieee802154/socket.c +++ b/net/ieee802154/socket.c @@ -273,6 +273,10 @@ static int raw_sendmsg(struct sock *sk, struct msghdr *msg, size_t size) err = -EMSGSIZE; goto out_dev; } + if (!size) { + err = 0; + goto out_dev; + } hlen = LL_RESERVED_SPACE(dev); tlen = dev->needed_tailroom;