From patchwork Mon Oct 24 11:32:52 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9184 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp458413wru; Mon, 24 Oct 2022 06:37:33 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5cj22e1twY3GrhTmnjEnz2I+ivtlgDB+8lHVAlmLUvbl9neaCH6DWZj7/MipQWMDQ109DE X-Received: by 2002:a17:906:15ca:b0:78d:b7b3:2afa with SMTP id l10-20020a17090615ca00b0078db7b32afamr27716720ejd.69.1666618653554; Mon, 24 Oct 2022 06:37:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618653; cv=none; d=google.com; s=arc-20160816; b=LFQZT6AIeWjqujjNhnpNaYf/8rGHdgZtBSLKjdi0LJdwipc7B6Wf6w6OLe/uHP82RF onOppPttuaIHjRb8no9BXItdLOPi02Fwb8cqRdLhthIrQpFV/Nvpk6ZQLlJIgZ/TZa+N RAa7l58GTUnW5QqKWCF0M6mA5fWWkgpeHIta4yc90Exi00aAobBi/dTBrcK9ZE6bLeNl h14lLVucqc0HrH/VLzd2w3ytIsbcMi5foipB8IYDtpbb9XeABCNDLntb0JfISBJmSc+W 5O3tkByb1VyIkN1MKlliSsttpTp42LENsd9IPBdKGuq9vAk9hCGBHro22uKww9atcnVu Ib1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=8NyhdaZ3LuVBoF9vL+vt4dIc1FNcstlKRIHhoHJyq0Q=; b=gUVLFlv0PHn6JboHdpR7jsmG6E5EQ7Xv0Clqcsrn1P41fj9gFmKCrgg1xbtwL5IVDv KfS0Rxcgi6Z+MzPxycngbsEHYVdzQ70jy1F4dJfkQCmogWSs+o9qFZcp9zU5ThKGiEGt ddBPtHCqjB7Jnq20pIGxTAnoPRLspfsGhdYBPy63Pi84odn4mBYwpwtibY5iVXk0Y7xj Hwo6cRuMpB8JfLFPIo6kdZRoMSFU6rOHZXp8YF3fmejisu40On+75hksA47bVRjMKisJ 5EwNbBIZ9mO3qjxysw6iNK4WpG9gLFccykKa6Tkk6dC1mLsSYunglkFLfsQw+tsCc/Ys YNHw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W+2+Mm9s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c20-20020a05640227d400b0045d27c0ba90si29425950ede.577.2022.10.24.06.37.01; Mon, 24 Oct 2022 06:37:33 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=W+2+Mm9s; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229967AbiJXNcs (ORCPT + 99 others); Mon, 24 Oct 2022 09:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36954 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236013AbiJXN3X (ORCPT ); Mon, 24 Oct 2022 09:29:23 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F214AABF08; Mon, 24 Oct 2022 05:32:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2520E61338; Mon, 24 Oct 2022 12:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38CC0C433D6; Mon, 24 Oct 2022 12:32:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614738; bh=1zSzDiAVmfYGGXOfDWhFwcYMeLXritnbgm9Z9d7MIdU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W+2+Mm9sTJpvYn6SE42DOEEd1xQNVNvRrCpYgGFSzeExK639C7gIUZ1KTNkxRJxGB S+HaZr2lVhbiYrlmSCjLlV7i6OJJD970//ln14QleLLH6U7pPE7T4rG8+ivaUZdNAi jm+YW6qBoDDMOY77W+0cR9r7K6rlgycRRz2pQwso= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?q?Noralf_Tr=C3=B8nnes?= , Maxime Ripard , Stefan Wahren , Stephen Boyd , Sasha Levin Subject: [PATCH 5.10 375/390] clk: bcm2835: Make peripheral PLLC critical Date: Mon, 24 Oct 2022 13:32:52 +0200 Message-Id: <20221024113038.975228832@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576321181779241?= X-GMAIL-MSGID: =?utf-8?q?1747576321181779241?= From: Maxime Ripard [ Upstream commit 6c5422851d8be8c7451e968fd2e6da41b6109e17 ] When testing for a series affecting the VEC, it was discovered that turning off and on the VEC clock is crashing the system. It turns out that, when disabling the VEC clock, it's the only child of the PLLC-per clock which will also get disabled. The source of the crash is PLLC-per being disabled. It's likely that some other device might not take a clock reference that it actually needs, but it's unclear which at this point. Let's make PLLC-per critical so that we don't have that crash. Reported-by: Noralf Trønnes Signed-off-by: Maxime Ripard Link: https://lore.kernel.org/r/20220926084509.12233-1-maxime@cerno.tech Reviewed-by: Stefan Wahren Acked-by: Noralf Trønnes Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/bcm/clk-bcm2835.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c index f306b959297d..b7f89873fcf5 100644 --- a/drivers/clk/bcm/clk-bcm2835.c +++ b/drivers/clk/bcm/clk-bcm2835.c @@ -1786,7 +1786,7 @@ static const struct bcm2835_clk_desc clk_desc_array[] = { .load_mask = CM_PLLC_LOADPER, .hold_mask = CM_PLLC_HOLDPER, .fixed_divider = 1, - .flags = CLK_SET_RATE_PARENT), + .flags = CLK_IS_CRITICAL | CLK_SET_RATE_PARENT), /* * PLLD is the display PLL, used to drive DSI display panels.