From patchwork Mon Oct 24 11:32:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9573 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp527455wru; Mon, 24 Oct 2022 09:00:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6t1/YVPRI8VfVgDC9n+Zt/GcyL6+n90S7gNSQAj5xprPvuo8NHD5xgsOKHJOY8uMvcqqle X-Received: by 2002:a17:906:2699:b0:781:a473:9791 with SMTP id t25-20020a170906269900b00781a4739791mr28479834ejc.644.1666627242308; Mon, 24 Oct 2022 09:00:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666627242; cv=none; d=google.com; s=arc-20160816; b=YTkPyAEelKlx2H77QpDmCfLsYRaMiikujL9vqIwzepHTDGjOdvNBF8n7PGlSjWx1Bp Dtu3+6VxfXE8xjemfPJjLw2noy6tzFTUwHhfVyK97xmFCzxkYLBGGbT97qcT/F2+NCV8 bz6FvG8GzKLtb7jx6eNZIXe7ayLKUXj+QpboZWel2PB9KjQHKXWdCuoUuyDl17Tl9kX1 uIzSPLdXyPeajTOYcc++pV9gH+/t46xS++DQ3COnwhyrapYgbfM/1FqLHVgwRFyxQ5w5 5W6nLl1RQJ4zrd32tDFvZKxIg+iPuEYlWYfNCgXAkJHhr3QBK/mmCR2piEqFfhpiARuw QXpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=xJQEd/tw+5bihUtS8xNDx4uOCFTFc7l87/IjfaVZf1w=; b=fakOYXHxgr5N5ogv2okUAuTF7vgwmaZiHhJrJrrpf6CrAargTOJHk6LIsm0X6eJ7z0 tmbrQz/YJmj91zTECQGJQzlDyRHlbOfHtzs4st2mSwu7YWUxSv/4tt/AODU6JpLEH6I7 ZA0g9ECeUEZR9ch2RI9LDrI2nguriU7x5N4F/sRlhfYrsjkGGltVkYC/XlO8H+2/kRrp PgcPPPcIhk4lN/MVY1MvDmc+5HZT2JGYCFbIf6igUDSPdIzN+/vAdklGnDgVvdZEPXB2 ydhBZ33GFLlyB0tba7p3EEkjiWqXY5vmdnH8h507CG9FVix4uJ+m40SjzoTJenw3mGkg 2Z8A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aJYHcBHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ht16-20020a170907609000b00741a18d4a5asi69572ejc.994.2022.10.24.09.00.08; Mon, 24 Oct 2022 09:00:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=aJYHcBHi; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231929AbiJXP4u (ORCPT + 99 others); Mon, 24 Oct 2022 11:56:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231919AbiJXP4P (ORCPT ); Mon, 24 Oct 2022 11:56:15 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68FE9B0B0B; Mon, 24 Oct 2022 07:51:25 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id BB3ACB81716; Mon, 24 Oct 2022 12:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24F6CC433C1; Mon, 24 Oct 2022 12:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614725; bh=6vbKmmz0ryFxKZLGyy2yrARzgTOezGzvxGBhsplRrh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aJYHcBHibyD3QEHoyI/0lpc2sYNIKGhxqXoFl0/ewfMYG4B52RHazGE2jl+YNEZ4z DYQjhXVhJNnNtca63a2P3mjGF0MQbQGpAcnUE9v0KdW53/R/1eZXJZXDCnw9sXjfFx smrvg/Hl30S22bvvEkXLwIO9g0W55NvViliYQbNM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, sunghwan jung , Sasha Levin Subject: [PATCH 5.10 370/390] Revert "usb: storage: Add quirk for Samsung Fit flash" Date: Mon, 24 Oct 2022 13:32:47 +0200 Message-Id: <20221024113038.769124036@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747585327303929759?= X-GMAIL-MSGID: =?utf-8?q?1747585327303929759?= From: sunghwan jung [ Upstream commit ad5dbfc123e6ffbbde194e2a4603323e09f741ee ] This reverts commit 86d92f5465958752481269348d474414dccb1552, which fix the timeout issue for "Samsung Fit Flash". But the commit affects not only "Samsung Fit Flash" but also other usb storages that use the same controller and causes severe performance regression. # hdparm -t /dev/sda (without the quirk) Timing buffered disk reads: 622 MB in 3.01 seconds = 206.66 MB/sec # hdparm -t /dev/sda (with the quirk) Timing buffered disk reads: 220 MB in 3.00 seconds = 73.32 MB/sec The commit author mentioned that "Issue was reproduced after device has bad block", so this quirk should be applied when we have the timeout issue with a device that has bad blocks. We revert the commit so that we apply this quirk by adding kernel paramters using a bootloader or other ways when we really need it, without the performance regression with devices that don't have the issue. Signed-off-by: sunghwan jung Link: https://lore.kernel.org/r/20220913114913.3073-1-onenowy@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/storage/unusual_devs.h | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/usb/storage/unusual_devs.h b/drivers/usb/storage/unusual_devs.h index 4993227ab293..20dcbccb290b 100644 --- a/drivers/usb/storage/unusual_devs.h +++ b/drivers/usb/storage/unusual_devs.h @@ -1275,12 +1275,6 @@ UNUSUAL_DEV( 0x090a, 0x1200, 0x0000, 0x9999, USB_SC_RBC, USB_PR_BULK, NULL, 0 ), -UNUSUAL_DEV(0x090c, 0x1000, 0x1100, 0x1100, - "Samsung", - "Flash Drive FIT", - USB_SC_DEVICE, USB_PR_DEVICE, NULL, - US_FL_MAX_SECTORS_64), - /* aeb */ UNUSUAL_DEV( 0x090c, 0x1132, 0x0000, 0xffff, "Feiya",