From patchwork Mon Oct 24 11:31:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9197 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp458924wru; Mon, 24 Oct 2022 06:38:32 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7cu/IzNuB45I6NgF4z19lUpYcWY2j6/ICzBrmfIcw1cZd1nISVjmXWUGKmsFo+NLbJf/1o X-Received: by 2002:a05:6402:3645:b0:45f:e918:9f35 with SMTP id em5-20020a056402364500b0045fe9189f35mr21765048edb.118.1666618711935; Mon, 24 Oct 2022 06:38:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618711; cv=none; d=google.com; s=arc-20160816; b=z2W8Rso+1r2THCi8ZFPD0uFE+bkStggjY9FxyfhHiHkhAfX51H5zZosKaD1C8SDaIv VTaOZe0BLLCKrzC/uBOnIwbLlWcZgDwutamXDiAIP+hhmzj3rPX5feNwQdKTIfnVBrNY oRQD+d+Pa7JKF8drEt6MuyGkRn1arH6BxhNikqIiNVJaUivEAGO2sCunbH+7dx7i+dyT NH+ubK9dI5FDX/MuLJWgygwb02hPP74e5viuy4yAuEVCeqQaOTYgQ22ynqGl9sfTWb5y MquXo8h0psvfs57cTkp+tWP/RuK1TdKYAhy1HZbcMa+bgdl/zDeag5sf9LZZf/KG6O3s ur2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=ykvVFnRRm1cLAR1KbjAheT2ulbhsVVh1kZjf4ld2xAY=; b=gbarInvRJe9xfMge9GctEAHgCal26KouZXWRMIl86D6JljZgnZxeUO2xFCyjJAxYcJ cpdqrWqMMDHOsPvjH1umz9CSefFNMboHD6IeHx5DcnDYfu0iPVyds+G9O03hVFFQ7sXm aB2uFLS/2jKHtvoiMVoB4m1wbA4O/DBO72yNevKWLNp0apUt7S6Bl7MXcSmceVKss50x fbcaA71ttRYF3LJLOMCOI7pBT7PuwLK//Dl0GBDVbWiV3bxBE7YXN3Bg341ChkoDVkQ5 yCzeV3PyRCkhBDtr9zEr664XlAtt84VdM2w1/F+x3FKyBnftCusHiAFqGrVTTTBPqW5Y gKJw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KQS5Pd5l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z19-20020a056402275300b00461d8ee1316si2339503edd.21.2022.10.24.06.37.50; Mon, 24 Oct 2022 06:38:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KQS5Pd5l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232907AbiJXN0d (ORCPT + 99 others); Mon, 24 Oct 2022 09:26:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235897AbiJXNX5 (ORCPT ); Mon, 24 Oct 2022 09:23:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC0EA53001; Mon, 24 Oct 2022 05:30:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1B134612E7; Mon, 24 Oct 2022 12:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 30544C433D6; Mon, 24 Oct 2022 12:28:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614528; bh=oSqopbRO77nvGov1G/esShYNUZjCZlTROPXoWvX/7Ic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KQS5Pd5lTAO8Ztw1Y3n8L2HH0vhbQ2KKUFPJVrOFEKOG2q8cvFdRvgsfpmUAP/cgJ ZyqSoLlDvCOfb17+jhchUPz+x8qZZ082ZALwErZ3cjE2xc1uxioIMdvrNJsmLTn0+V 5z10uEl1Hlwbm1MJaE55WxnrH8r6TApNPF5dC698= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Zqiang , "Paul E. McKenney" , Sasha Levin Subject: [PATCH 5.10 296/390] rcu-tasks: Convert RCU_LOCKDEP_WARN() to WARN_ONCE() Date: Mon, 24 Oct 2022 13:31:33 +0200 Message-Id: <20221024113035.607806092@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576382106766893?= X-GMAIL-MSGID: =?utf-8?q?1747576382106766893?= From: Zqiang [ Upstream commit fcd53c8a4dfa38bafb89efdd0b0f718f3a03f884 ] Kernels built with CONFIG_PROVE_RCU=y and CONFIG_DEBUG_LOCK_ALLOC=y attempt to emit a warning when the synchronize_rcu_tasks_generic() function is called during early boot while the rcu_scheduler_active variable is RCU_SCHEDULER_INACTIVE. However the warnings is not actually be printed because the debug_lockdep_rcu_enabled() returns false, exactly because the rcu_scheduler_active variable is still equal to RCU_SCHEDULER_INACTIVE. This commit therefore replaces RCU_LOCKDEP_WARN() with WARN_ONCE() to force these warnings to actually be printed. Signed-off-by: Zqiang Signed-off-by: Paul E. McKenney Signed-off-by: Sasha Levin --- kernel/rcu/tasks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index 14af29fe1377..8b51e6a5b386 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -171,7 +171,7 @@ static void call_rcu_tasks_generic(struct rcu_head *rhp, rcu_callback_t func, static void synchronize_rcu_tasks_generic(struct rcu_tasks *rtp) { /* Complain if the scheduler has not started. */ - RCU_LOCKDEP_WARN(rcu_scheduler_active == RCU_SCHEDULER_INACTIVE, + WARN_ONCE(rcu_scheduler_active == RCU_SCHEDULER_INACTIVE, "synchronize_rcu_tasks called too soon"); /* Wait for the grace period. */