From patchwork Mon Oct 24 11:31:12 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9188 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp458596wru; Mon, 24 Oct 2022 06:37:52 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5h2fGnGLnPxedNnv7Kg7xzKdnA4kSuzWQuewW5zNuWdQ53H64NtLNX44xu874/3BJK3NwM X-Received: by 2002:a17:907:720b:b0:78e:c0e:a434 with SMTP id dr11-20020a170907720b00b0078e0c0ea434mr27663246ejc.741.1666618592372; Mon, 24 Oct 2022 06:36:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618592; cv=none; d=google.com; s=arc-20160816; b=ZHs95gkOH6cIhbFOgMwNsPw/ipKYqlCrbyeDmQkS/BSWQK9bwb1kC+JzXsiyGPfL5w b+TxHIZ0hcojMmHBrdVZXChUcA1I9G/ZGrKlHRVX5r5YuJd2pd/GANicFtSaXgCx/NlT jqKnwQgFm1Yom0QMjyaE9W2lDl6tC32Qf2rdqzfIrcHGWcINZXsRqErOCG/yrDWIQDma 8Nxah8jTSJaOaYe4Vq/6HVjYs6D5bNGOvhPv4Lml90ZXZdT4La2IimTieKvl8TwmU/BW VkblaC3sqe4xHMQM4EPDzGNX59MKmocB2voxd36JdJxfgji55LTLnYJrTTL1/x1QYxYV k9DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Re463ur1U2wiu9FBcNtMjBkF7WpIaychu4lKxQTsQLs=; b=jVtsyLKx+fdSxnLDtxnpQfnzmP8uLpkNuSiNpxnkIMhPPZX79J2LqPdZ+xVWsNttBa nQVxnGQkx36DzWWi856piwjfuMW2mhR/ZvJdk454W0ObvwNWO4JiLIIeD+xRVahJyLAC NTbz2LsyAgGT/xO4Y0vW3Qt/EmS5NX0iJDN32wxR63qtQs4hfLCip4bmi8CN948VHouJ kcqOtoZCWMFiof6SyQpN0tMo+moByKLnLJ/3HdHC1e/IPofbBDQerRKErJvkO87SNAfU xC8iExiS41BkgK+0LUYT3GY7LZaFxUhm2MyhsCz6c70nPW+1iDL1wwNdDTlsThMeofTb HKHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=k5uMHShr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hw8-20020a170907a0c800b00787d0dfe70csi26004112ejc.981.2022.10.24.06.36.06; Mon, 24 Oct 2022 06:36:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=k5uMHShr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231319AbiJXNZs (ORCPT + 99 others); Mon, 24 Oct 2022 09:25:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234058AbiJXNXB (ORCPT ); Mon, 24 Oct 2022 09:23:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8C6A12F397; Mon, 24 Oct 2022 05:29:59 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D997A612E9; Mon, 24 Oct 2022 12:27:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC516C433D6; Mon, 24 Oct 2022 12:27:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614476; bh=AlKGxA5oHb1mhMs88++LuDXBhLryEnVpofotGpHubyE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k5uMHShrY1q2NtApzvhZieoSnKLhkEktpFNG9HOCNpVmRTYp0JEIrwk+6au1sjCvM FcPfkEKiY7SA4l5UtX1jRcxclubOGDFJ8GB2JKsnwp0hpAcPur8+KcyBvawluaWahm Zw0nXrV6yWiRQK3+m+ZPdxvvV1np83CQwW5GXnPc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Robin Murphy , Laurent Pinchart , Joerg Roedel , Sasha Levin Subject: [PATCH 5.10 275/390] iommu/omap: Fix buffer overflow in debugfs Date: Mon, 24 Oct 2022 13:31:12 +0200 Message-Id: <20221024113034.648307904@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576257362181629?= X-GMAIL-MSGID: =?utf-8?q?1747576257362181629?= From: Dan Carpenter [ Upstream commit 184233a5202786b20220acd2d04ddf909ef18f29 ] There are two issues here: 1) The "len" variable needs to be checked before the very first write. Otherwise if omap2_iommu_dump_ctx() with "bytes" less than 32 it is a buffer overflow. 2) The snprintf() function returns the number of bytes that *would* have been copied if there were enough space. But we want to know the number of bytes which were *actually* copied so use scnprintf() instead. Fixes: bd4396f09a4a ("iommu/omap: Consolidate OMAP IOMMU modules") Signed-off-by: Dan Carpenter Reviewed-by: Robin Murphy Reviewed-by: Laurent Pinchart Link: https://lore.kernel.org/r/YuvYh1JbE3v+abd5@kili Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/omap-iommu-debug.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iommu/omap-iommu-debug.c b/drivers/iommu/omap-iommu-debug.c index a99afb5d9011..259f65291d90 100644 --- a/drivers/iommu/omap-iommu-debug.c +++ b/drivers/iommu/omap-iommu-debug.c @@ -32,12 +32,12 @@ static inline bool is_omap_iommu_detached(struct omap_iommu *obj) ssize_t bytes; \ const char *str = "%20s: %08x\n"; \ const int maxcol = 32; \ - bytes = snprintf(p, maxcol, str, __stringify(name), \ + if (len < maxcol) \ + goto out; \ + bytes = scnprintf(p, maxcol, str, __stringify(name), \ iommu_read_reg(obj, MMU_##name)); \ p += bytes; \ len -= bytes; \ - if (len < maxcol) \ - goto out; \ } while (0) static ssize_t