From patchwork Mon Oct 24 11:30:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10306 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp655224wru; Mon, 24 Oct 2022 14:14:43 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6Cj5aLanOJ6IpM+LqqAzcsG0bOv42jqmd6ElnHcWndKAsXKLE3ts3tt6TAwTEq0RYaiJBB X-Received: by 2002:aa7:d8c4:0:b0:461:8d31:41fc with SMTP id k4-20020aa7d8c4000000b004618d3141fcmr11445887eds.202.1666646083691; Mon, 24 Oct 2022 14:14:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666646083; cv=none; d=google.com; s=arc-20160816; b=vAg+4bwu9UT02CEXDFCF3CBh9oC+V5sGmu5MZXuwKImxzL4ehVsFdxARJvdrrhnR5M OluG7HMg5A6sEqfLjlxefvDs4DY6iG/Osznfxo1vmMN4k4BumwQBIQWWYx/OwrPcbbmV 4vZH1xuE1aEOofaKvfEGguiYdmzutjsbf6fkv47FWTz0uEBTs+7mhtRZP/UYNotVBzag 4NuHCGjrfHBoH/ir2cNYr+0IVutjZ51WFitkJPz31hubsaImkRW6RDl+7GHsP+cImYvW j8QOrOltorjorMMm2oWgsCjR/gwvE9JND3lsb4Hqoc6fD/jqrGJ0hDZEbUuZLJn7exJv XLhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=7asfMDE5/D7dKpT8/biKetb4XW91a489M0kGzgXzjQo=; b=JBaaPCwyyo9DoJVydxCl5uK1f6SZb2LDWlCN/UFKVrjMK3h7MUPahVTM9R6WLkLY01 LUJ2rnqKuCYh+5taOeq63z3br7LkldkvdPxl4R4Ad16wNVKJLlp0qBi1uBgriVv1Zg8x slCAtTumW2Snvu5cs/xIJjCbPYS+1y0i28WXJcs1v1KVjyflRyjnJ4Y8moRKPYzziHGD nMWO/qNDSzjcd4TtL1sGPwVfMtJVVoQs2W7UUACUrkDGue7mzR+zObbBBqV00PzQhTdT VBoshyOPWdSK4+8irLA4U4evOG1NMa4Ep+49FxVcNtOoSMXb3YxTuCceVx/ZcQR04B5p 8MAg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KjlHSum2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r11-20020a50aacb000000b00458ab55ccc9si739807edc.168.2022.10.24.14.14.15; Mon, 24 Oct 2022 14:14:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=KjlHSum2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233726AbiJXVMa (ORCPT + 99 others); Mon, 24 Oct 2022 17:12:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231419AbiJXVLj (ORCPT ); Mon, 24 Oct 2022 17:11:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 296D45C35C; Mon, 24 Oct 2022 12:18:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8308EB81686; Mon, 24 Oct 2022 12:28:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4621C433C1; Mon, 24 Oct 2022 12:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614497; bh=V1yLvhX9zdad2+j+Fwim9g75fpNwO3eUX/S2g7mfUCQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KjlHSum2GyWskfREIz5R6DIF8yYVPXsbz3P1Pv6yrf6mXgGzZgtAaQBdhfXaJZGya 5RGA+U4DdmqjvoFd+qvAu2jHcZ9nexua+lv8Nql5L0wIKiyYsGXQe2TB9cOXmWyZN4 lDRKB1PxnC/0YMnx2XFeJsCg0/LU5a2qc1PLznSo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dave Jiang , Vinod Koul , Sasha Levin Subject: [PATCH 5.10 254/390] dmaengine: ioat: stop mod_timer from resurrecting deleted timer in __cleanup() Date: Mon, 24 Oct 2022 13:30:51 +0200 Message-Id: <20221024113033.694624772@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747605084052825160?= X-GMAIL-MSGID: =?utf-8?q?1747605084052825160?= From: Dave Jiang [ Upstream commit 898ec89dbb55b8294695ad71694a0684e62b2a73 ] User reports observing timer event report channel halted but no error observed in CHANERR register. The driver finished self-test and released channel resources. Debug shows that __cleanup() can call mod_timer() after the timer has been deleted and thus resurrect the timer. While harmless, it causes suprious error message to be emitted. Use mod_timer_pending() call to prevent deleted timer from being resurrected. Fixes: 3372de5813e4 ("dmaengine: ioatdma: removal of dma_v3.c and relevant ioat3 references") Signed-off-by: Dave Jiang Link: https://lore.kernel.org/r/166360672197.3851724.17040290563764838369.stgit@djiang5-desk3.ch.intel.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/ioat/dma.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c index 37ff4ec7db76..e2070df6cad2 100644 --- a/drivers/dma/ioat/dma.c +++ b/drivers/dma/ioat/dma.c @@ -656,7 +656,7 @@ static void __cleanup(struct ioatdma_chan *ioat_chan, dma_addr_t phys_complete) if (active - i == 0) { dev_dbg(to_dev(ioat_chan), "%s: cancel completion timeout\n", __func__); - mod_timer(&ioat_chan->timer, jiffies + IDLE_TIMEOUT); + mod_timer_pending(&ioat_chan->timer, jiffies + IDLE_TIMEOUT); } /* microsecond delay by sysfs variable per pending descriptor */ @@ -682,7 +682,7 @@ static void ioat_cleanup(struct ioatdma_chan *ioat_chan) if (chanerr & (IOAT_CHANERR_HANDLE_MASK | IOAT_CHANERR_RECOVER_MASK)) { - mod_timer(&ioat_chan->timer, jiffies + IDLE_TIMEOUT); + mod_timer_pending(&ioat_chan->timer, jiffies + IDLE_TIMEOUT); ioat_eh(ioat_chan); } } @@ -879,7 +879,7 @@ static void check_active(struct ioatdma_chan *ioat_chan) } if (test_and_clear_bit(IOAT_CHAN_ACTIVE, &ioat_chan->state)) - mod_timer(&ioat_chan->timer, jiffies + IDLE_TIMEOUT); + mod_timer_pending(&ioat_chan->timer, jiffies + IDLE_TIMEOUT); } static void ioat_reboot_chan(struct ioatdma_chan *ioat_chan)