From patchwork Mon Oct 24 11:30:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 10130 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp633944wru; Mon, 24 Oct 2022 13:15:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5FmdeIKWX7UggOrSfOHgP0uaU4SG3MUt87gqhzLSR7eLOYbJhkmGIgn369PFjZE0LMbqUy X-Received: by 2002:a17:902:f710:b0:184:7a4c:fdc1 with SMTP id h16-20020a170902f71000b001847a4cfdc1mr34949283plo.27.1666642540054; Mon, 24 Oct 2022 13:15:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666642540; cv=none; d=google.com; s=arc-20160816; b=ZECo3Cu5Gb+VE12H0aXWzBwAh2lWiZbEgSZOZoAJj3eodIVv4H3WubtvWm7OkJQDEk 3k8pNLsHb06oe//J5Q1CqAlzZ61x4/Dy0FerSPC9/LOJwxv36njQ8a9IvhqMQyZG7RXS D6LL5UYcCd6oUfrKcByqId0tjHbLvpVw/tWOycthl8RbxCrmGqggQmMQnsPQFUb5AbBq BABfLNZCPtWumkrX/RKYOShZEMxKzIrcma+MJEi/JeWjP7jQ17pS5svanlJlDvyXAjAf iPW+F9S++mJXpVLx43QjgY+NwMwSuXw+f5q2d4x1vfxOexlzR5DwZuYx8MztpsRdOEdX h49Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=IqCyo+VBCEqyxWEjVp+XrkK16sVyc4d/2d2vYhlDz1U=; b=pCeveN1du1YJXVarrFEwCDEb+JU14z5GC9tC8d8CMbvWlpewSHUZiwKgjluqV8Nny8 oxjilHx/0kG2Hh4FzLlP4Tr/uWpesfjAiAtU1Hx+wNrnNZxiB5Gs4Ix9t+S1CH7hD0FH 279rSP9uB7TBibUrs7bEgztQZS9wDpJmLYX/Vfymz5HdjteI55mKyeoDTcDzGbfbtI3W oI9wduJCw2fzFO2MeHmqDQWq1Dm30JIyP+9WTt6gtm+S1AlD8Es4CcZaAav9CKYLXucT uthxZXRYmtSrC7TxFMUxE3vI9+ll/2qHO2E74Oif4PkK1RTGmwGHHZWZ2FALQgTP0gzB 7aag== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c8FsqwoZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u30-20020a056a00099e00b005397c4ad9e1si743779pfg.134.2022.10.24.13.15.26; Mon, 24 Oct 2022 13:15:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c8FsqwoZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231347AbiJXUHh (ORCPT + 99 others); Mon, 24 Oct 2022 16:07:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233209AbiJXUGs (ORCPT ); Mon, 24 Oct 2022 16:06:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7A7F3FC6; Mon, 24 Oct 2022 11:26:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9D6DEB8125E; Mon, 24 Oct 2022 12:26:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02957C433D6; Mon, 24 Oct 2022 12:26:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614405; bh=vSgsDIvzzF3Mr1Kj1xaAWGv9LZXJ1IaBnh/leVDRPlw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=c8FsqwoZnOp0SmlhUFeYVaJ7qyKvMUTQ/wRRTEyNSOj9dLeGEuBffXZ6x3DmZDw+A VpCjMDeLMWTYUTDGU7jPO+1mS+P5lSuDKo7L58cdilbhWEfWMCDlC0S6ivVO/pWk/p ebTGRfgy3/9tPKFgEmoNVgkgTNQjvsWr9Q42JpKA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Christophe JAILLET , Andy Shevchenko , Hans de Goede , Lee Jones , Sasha Levin Subject: [PATCH 5.10 247/390] mfd: intel_soc_pmic: Fix an error handling path in intel_soc_pmic_i2c_probe() Date: Mon, 24 Oct 2022 13:30:44 +0200 Message-Id: <20221024113033.365656870@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747601368329436966?= X-GMAIL-MSGID: =?utf-8?q?1747601368329436966?= From: Christophe JAILLET [ Upstream commit 48749cabba109397b4e7dd556e85718ec0ec114d ] The commit in Fixes: has added a pwm_add_table() call in the probe() and a pwm_remove_table() call in the remove(), but forget to update the error handling path of the probe. Add the missing pwm_remove_table() call. Fixes: a3aa9a93df9f ("mfd: intel_soc_pmic_core: ADD PWM lookup table for CRC PMIC based PWM") Signed-off-by: Christophe JAILLET Signed-off-by: Andy Shevchenko Reviewed-by: Hans de Goede Signed-off-by: Lee Jones Link: https://lore.kernel.org/r/20220801114211.36267-1-andriy.shevchenko@linux.intel.com Signed-off-by: Sasha Levin --- drivers/mfd/intel_soc_pmic_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index ddd64f9e3341..926653e1f603 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -95,6 +95,7 @@ static int intel_soc_pmic_i2c_probe(struct i2c_client *i2c, return 0; err_del_irq_chip: + pwm_remove_table(crc_pwm_lookup, ARRAY_SIZE(crc_pwm_lookup)); regmap_del_irq_chip(pmic->irq, pmic->irq_chip_data); return ret; }