From patchwork Mon Oct 24 11:30:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9624 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp531662wru; Mon, 24 Oct 2022 09:06:50 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5MMyAb3KZ09ur48+kT1Lm4FnVUbKkJcWm2ZcBlGkN6U+1od899zIiuLRN4++gc5FKtTLUP X-Received: by 2002:a17:907:a428:b0:78d:9fab:84fb with SMTP id sg40-20020a170907a42800b0078d9fab84fbmr27309202ejc.694.1666627609927; Mon, 24 Oct 2022 09:06:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666627609; cv=none; d=google.com; s=arc-20160816; b=stIqmV7VzwqcBxMjseS5bjPrIXWvnvd70RZU16BDdVjfWmR5dy3gjiWt4wimSLCT+F UG61ugv/Kffz1N18eGK0vizAyOHe+rxQBbA1MkXbOLMPUlUJxuAqB8Dx29xUiG6xkbV4 auPPVFmNevZeNqS7nRjW5xWpAi+o2iaegZEkFNTgLyJG7yCA9Gzlp1RJOZxZd6fe/F+C MXGrJ0Olh+qM3vyWaYQoVxxu20yuzG7GwOrK/7afsF80ORjGl7opdpjBiZXtL+I+qre0 i5sWfy8MZNr5073Y0bMGJS8/P7Rpcg4sYAsES6KEy3B8RRwd8eogFahfcciLfz8/QxMj Cxlg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=gUVnmVMwStaZm1HK0ca9SAxPbzA6YbLaYKJMjt6j9hc=; b=YPTANE/wFYrgMjGpXahPvMqTkTKxdPociFTc3xhU+NRfpc9p3XIIT4+5Bda2tsLJGG BSsAKrUV5Ae5kTt45rLhSvIeKSJeeWfRVftgODZ04zpnRRFFc7lsUzzkBEXpaYAsy+FS oD1zSdftBALJHeA+Bl3SzEpQib9aJWVnEqyAJTUNP7BaudnNOatQ+KZdnPnvegSot6i+ hhjFO8Dl3g/2N94PYI98lBKWs8Qdl3rtfd5NbpkDGhOsgr8pMY9qz7C51wuALTzD0esP FsARl63I/MPeLgTmvjzRR8xJ/V9WbvbG04w4PsjyA0EvzYnX70rcFD2yQ+VO5JFMPsZA sDeg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Fr4I7BIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b20-20020a056402279400b00460e691561esi134815ede.630.2022.10.24.09.06.25; Mon, 24 Oct 2022 09:06:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Fr4I7BIS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232887AbiJXQFp (ORCPT + 99 others); Mon, 24 Oct 2022 12:05:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232281AbiJXQDT (ORCPT ); Mon, 24 Oct 2022 12:03:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32A11303E5; Mon, 24 Oct 2022 07:55:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 409BFB81205; Mon, 24 Oct 2022 12:25:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D427C433C1; Mon, 24 Oct 2022 12:25:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614344; bh=j48GD4wqmvfik3nas3KYqwYEPabup8cKXd1O2oBA5/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Fr4I7BISfdTdcRMhLeMSx1REJ+L5CtbNrvMvfWkGCuNNHWEht79OBoahdvu+ngMLJ vkzVYVYlEjxG+vNIczjCcd9aRxdHubwB900URiGMTKm9WN3AbY90xZrel3+4WXhiI+ rwFgZSJUIZsqvIq8sej7/3MRCBTePnNhgfUQ1IGc= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Rasmus Villemoes , Jason Baron , Daniel Vetter , Jim Cromie , Sasha Levin Subject: [PATCH 5.10 218/390] dyndbg: fix module.dyndbg handling Date: Mon, 24 Oct 2022 13:30:15 +0200 Message-Id: <20221024113032.065724366@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747585712704977160?= X-GMAIL-MSGID: =?utf-8?q?1747585712704977160?= From: Jim Cromie [ Upstream commit 85d6b66d31c35158364058ee98fb69ab5bb6a6b1 ] For CONFIG_DYNAMIC_DEBUG=N, the ddebug_dyndbg_module_param_cb() stub-fn is too permissive: bash-5.1# modprobe drm JUNKdyndbg bash-5.1# modprobe drm dyndbgJUNK [ 42.933220] dyndbg param is supported only in CONFIG_DYNAMIC_DEBUG builds [ 42.937484] ACPI: bus type drm_connector registered This caused no ill effects, because unknown parameters are either ignored by default with an "unknown parameter" warning, or ignored because dyndbg allows its no-effect use on non-dyndbg builds. But since the code has an explicit feedback message, it should be issued accurately. Fix with strcmp for exact param-name match. Fixes: b48420c1d301 dynamic_debug: make dynamic-debug work for module initialization Reported-by: Rasmus Villemoes Acked-by: Jason Baron Acked-by: Daniel Vetter Signed-off-by: Jim Cromie Link: https://lore.kernel.org/r/20220904214134.408619-3-jim.cromie@gmail.com Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- include/linux/dynamic_debug.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h index a57ee75342cf..b0b23679b2c2 100644 --- a/include/linux/dynamic_debug.h +++ b/include/linux/dynamic_debug.h @@ -196,7 +196,7 @@ static inline int ddebug_remove_module(const char *mod) static inline int ddebug_dyndbg_module_param_cb(char *param, char *val, const char *modname) { - if (strstr(param, "dyndbg")) { + if (!strcmp(param, "dyndbg")) { /* avoid pr_warn(), which wants pr_fmt() fully defined */ printk(KERN_WARNING "dyndbg param is supported only in " "CONFIG_DYNAMIC_DEBUG builds\n");