From patchwork Mon Oct 24 11:29:59 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9114 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp456150wru; Mon, 24 Oct 2022 06:33:40 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4rYigoz0cVLtYxQwuruaZPiSkIfHB6IPe1TKaB7cVpRFoCA8TaGhfksts/3PZou8nkvvUP X-Received: by 2002:a17:907:72c5:b0:798:1c8f:5bc7 with SMTP id du5-20020a17090772c500b007981c8f5bc7mr19461296ejc.119.1666618419912; Mon, 24 Oct 2022 06:33:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618419; cv=none; d=google.com; s=arc-20160816; b=gcA4mYPUdLlzUaz3YvKFVrv0GvMLluljXyNuJbUKh2DxvIevdT2O1cr/1Hikzcbn90 CSh2C736Mqw0WXwIndhmpwrYeFqE/nh4dRocun3wFGkTjdvn4VcqExTodcMGP0HLrKF1 BigE6l6cYJ+eJvO5onnSdQf2A9grrf4L9PwKd5PgSBP/RyQXQFF2D39VNnMnUuc+/OAx ZRLnTzoXNH4LIRbVwR0Da+iNtjxZVjJ5umvg0+sW07Xhu103jiNl+8o82rTxOZVEhA4g stztOlUIwQx3HitPyvZqcXBe/n2f13Ih6USezx7Wvr7kuhtKDjtc9OsyiPpbRLSArm/t v2WA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=osn3Sd73uGpMJqv8P4LvWhZI9l3c41gqPT3e1Sbrpx8=; b=yoJYrZOq/nuWhuuJPfiZzM3XS0USUwTxWaIL9Mu5RBCzjVGoaYOJSNmnis6P8jQPL1 1qyyboneU0CfvJXEGXtoLkxZi6yVO2v3XfW1GlDb6Id+acXXix3rXeYD2oa+kcISTQ2d AcQ2ygOy3ViwDUC0McEgmZCj1or/HuEStC594ObjWkBwR7titUr4zPP/QZSe5jaOJ7Sp m4O1jehlmWEpl5DaSVA2FkCLhOtA/0cgtyxQ6nEZeMQ1gjcBsGVmcLlJt3eQ0chXkwD4 GvUh81FJQc0e64H2Gmxpj6iKEXLlUFmxio1C5FVu1MWpS+KFaa5Rnw0BrqiI+kLbL38W cnXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ycmx8ge0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w19-20020a056402269300b00461eb5cdcdcsi1271149edd.23.2022.10.24.06.33.14; Mon, 24 Oct 2022 06:33:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=Ycmx8ge0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235872AbiJXNQV (ORCPT + 99 others); Mon, 24 Oct 2022 09:16:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236067AbiJXNOj (ORCPT ); Mon, 24 Oct 2022 09:14:39 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 90A8395AE4; Mon, 24 Oct 2022 05:25:30 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0278061313; Mon, 24 Oct 2022 12:24:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 129B4C43142; Mon, 24 Oct 2022 12:24:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614284; bh=MYOwrjZCrWWsWxaSojRO2Wg1Ovu0P0g0HHH/slM/tnw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Ycmx8ge0P7Ev8oCpg0b1RYVW3PzJkAMC+hdIICzl8umvQ2r/PatTEn44Tmg0xIuCL LWfmZRA6DIMxr3DgLRfjNe21NYYVVPFerdb1gctQpalXW/xvLbTsTmEtmlSzDY2+Ov xHgXjfZD4PAyxm3ecaWDTP/RfULhXnCckTKVCnRY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miaoqian Lin , Stephen Boyd , Sasha Levin Subject: [PATCH 5.10 202/390] clk: tegra: Fix refcount leak in tegra114_clock_init Date: Mon, 24 Oct 2022 13:29:59 +0200 Message-Id: <20221024113031.365776719@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576076449360136?= X-GMAIL-MSGID: =?utf-8?q?1747576076449360136?= From: Miaoqian Lin [ Upstream commit db16a80c76ea395766913082b1e3f939dde29b2c ] of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 2cb5efefd6f7 ("clk: tegra: Implement clocks for Tegra114") Signed-off-by: Miaoqian Lin Link: https://lore.kernel.org/r/20220523143834.7587-1-linmq006@gmail.com Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/tegra/clk-tegra114.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c index bc9e47a4cb60..4e2b26e3e573 100644 --- a/drivers/clk/tegra/clk-tegra114.c +++ b/drivers/clk/tegra/clk-tegra114.c @@ -1317,6 +1317,7 @@ static void __init tegra114_clock_init(struct device_node *np) } pmc_base = of_iomap(node, 0); + of_node_put(node); if (!pmc_base) { pr_err("Can't map pmc registers\n"); WARN_ON(1);