From patchwork Mon Oct 24 11:29:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9116 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp456116wru; Mon, 24 Oct 2022 06:33:35 -0700 (PDT) X-Google-Smtp-Source: AMsMyM4yCmG5wB+JO34K20qSySSxjEUaQdObTQ8704K9Gw5BDv7LivTtr4DXHXSH2VtwD2NT0+Sf X-Received: by 2002:a17:906:dac8:b0:741:545b:796a with SMTP id xi8-20020a170906dac800b00741545b796amr26935588ejb.240.1666618415627; Mon, 24 Oct 2022 06:33:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618415; cv=none; d=google.com; s=arc-20160816; b=OF6g9O+CHDCB4/7BnRE0wSKuvnb0+JCKVE2DNsQE5DCaspHLhS0vU+eFeTnhuzdsG6 X//vISiUohxPxFW6cUJSTZa0iJ/rv7KorN0Jh8iGvgt2ZvLO1XQCwH+cfIjYBHuMdTqg IhZYnJmilnNoe/7NfNy5vuyKP4JIVxiqMleNg3jCvMz7BENyXWSMmbUDELx0HKrFJ8s3 TX+PcoLPMfY5z+hrBT2NZOyiF+mR6DJ/LMoMRtfC2j89ATHElUTt2LuW9vYKsb4JxjEB UPJYeOxypLs5mbgajmoJOlfTnI2fKtjyC1vDN2kf/6RXCQXACbJZmmnRqZc9smKZIy5g +6lg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=6ylUBjnFSRLnbMRGmOIgJ/VEikBjbqvO8kX+naGtEdU=; b=KFcNsadABl4h+FGCYq7Ymp0Zqu6Nxuuxs/RoGvE6xt/s30yn1SuyP53SyYo8UErNuy 9WH/pomTPZ1Z97iW1EPd8O7Ymi/7uifxfkh9xLYmIjFWfUiXxKbPXF5mEu78k2dnAP70 SY7cdA9X0qZKHttdSukVYoAxbVTMLaEqPZOTnbri0yF+VlvzeRj+L7j7m1OOUPlBoEwJ kPH1JzEz4UBhBBTP4ElEJuOSyE5+lWq5IXwPqPN1STPs9lZbaxc95gcd/WGyvhatDyBl eLECtCz6KbEhB1gVIFsNp79CrN1tXqH9O3D2Urmd57A1eD+qRL5OSocYG0V759bgDExv ZMnA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sKxQeD4c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k5-20020a1709062a4500b0079195ddab1bsi15337803eje.221.2022.10.24.06.33.10; Mon, 24 Oct 2022 06:33:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=sKxQeD4c; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235740AbiJXNPU (ORCPT + 99 others); Mon, 24 Oct 2022 09:15:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233079AbiJXNNv (ORCPT ); Mon, 24 Oct 2022 09:13:51 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1BF732D9C; Mon, 24 Oct 2022 05:24:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 213B6612D1; Mon, 24 Oct 2022 12:23:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DFC3C433D7; Mon, 24 Oct 2022 12:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614234; bh=VMdw8bJy5Kr6jBkW3N+JdCV3TTZit0h7aUXL1hDm2/I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=sKxQeD4chB1co2Ul/xr5YiVAJDe/TXVg2LnXcd+6/8aZN4fVQdF3wZBMogWTqkxON SlL20+nYnRIS8yMeKLOV3iXNXlR0veL1jYYX5/vQBxQOdsZBzqt6zm3upWiwGR0FdZ 8veD8Np14M3exHN1++BlQSHV4xqwusm23oEGbiOo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?q?Martin_Povi=C5=A1er?= , Mark Brown , Sasha Levin Subject: [PATCH 5.10 150/390] ASoC: tas2764: Drop conflicting set_bias_level power setting Date: Mon, 24 Oct 2022 13:29:07 +0200 Message-Id: <20221024113029.074859597@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576071976762734?= X-GMAIL-MSGID: =?utf-8?q?1747576071976762734?= From: Martin Povišer [ Upstream commit 09273f38832406db19a8907a934687cc10660a6b ] The driver is setting the PWR_CTRL field in both the set_bias_level callback and on DAPM events of the DAC widget (and also in the mute_stream method). Drop the set_bias_level callback altogether as the power setting it does is in conflict with the other code paths. (This mirrors commit c8a6ae3fe1c8 ("ASoC: tas2770: Drop conflicting set_bias_level power setting") which was a fix to the tas2770 driver.) Fixes: 827ed8a0fa50 ("ASoC: tas2764: Add the driver for the TAS2764") Signed-off-by: Martin Povišer Link: https://lore.kernel.org/r/20220825140241.53963-3-povik+lin@cutebit.org Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- sound/soc/codecs/tas2764.c | 33 --------------------------------- 1 file changed, 33 deletions(-) diff --git a/sound/soc/codecs/tas2764.c b/sound/soc/codecs/tas2764.c index bde92f080459..6b6e30b072f2 100644 --- a/sound/soc/codecs/tas2764.c +++ b/sound/soc/codecs/tas2764.c @@ -50,38 +50,6 @@ static void tas2764_reset(struct tas2764_priv *tas2764) usleep_range(1000, 2000); } -static int tas2764_set_bias_level(struct snd_soc_component *component, - enum snd_soc_bias_level level) -{ - struct tas2764_priv *tas2764 = snd_soc_component_get_drvdata(component); - - switch (level) { - case SND_SOC_BIAS_ON: - snd_soc_component_update_bits(component, TAS2764_PWR_CTRL, - TAS2764_PWR_CTRL_MASK, - TAS2764_PWR_CTRL_ACTIVE); - break; - case SND_SOC_BIAS_STANDBY: - case SND_SOC_BIAS_PREPARE: - snd_soc_component_update_bits(component, TAS2764_PWR_CTRL, - TAS2764_PWR_CTRL_MASK, - TAS2764_PWR_CTRL_MUTE); - break; - case SND_SOC_BIAS_OFF: - snd_soc_component_update_bits(component, TAS2764_PWR_CTRL, - TAS2764_PWR_CTRL_MASK, - TAS2764_PWR_CTRL_SHUTDOWN); - break; - - default: - dev_err(tas2764->dev, - "wrong power level setting %d\n", level); - return -EINVAL; - } - - return 0; -} - #ifdef CONFIG_PM static int tas2764_codec_suspend(struct snd_soc_component *component) { @@ -549,7 +517,6 @@ static const struct snd_soc_component_driver soc_component_driver_tas2764 = { .probe = tas2764_codec_probe, .suspend = tas2764_codec_suspend, .resume = tas2764_codec_resume, - .set_bias_level = tas2764_set_bias_level, .controls = tas2764_snd_controls, .num_controls = ARRAY_SIZE(tas2764_snd_controls), .dapm_widgets = tas2764_dapm_widgets,