From patchwork Mon Oct 24 11:28:33 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9072 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp445149wru; Mon, 24 Oct 2022 06:12:10 -0700 (PDT) X-Google-Smtp-Source: AMsMyM6QViwlIuGtJEu/PqrzXuUdAYjRb4bKty7XvbyZyy54T7EV0OEI1pBI1fvVMTepfmH46IgW X-Received: by 2002:a17:902:c952:b0:184:ba4f:af39 with SMTP id i18-20020a170902c95200b00184ba4faf39mr33463453pla.58.1666617130606; Mon, 24 Oct 2022 06:12:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666617130; cv=none; d=google.com; s=arc-20160816; b=avDwvn21oinmbP1Xu/ixzQx8FEZLLf3uD2YDbPpFc6iC6AZ5kw45HS5d185dm628Hm 1uq1RHahtVk3od80IUGZAxO+pW2AkezA5qTX+hwRXy93lgK+T+nUKPu7LfAZLk6PFk/N zY+a5r/fHVu3cSLFRyFPQ/SkypkRT8AW8jBXwiKQF2V+SJleQrn24ytnNIjUkSLijSOJ aaI6dCUZWIPTmbDtj9O5dCIsO97bQQv2EtcJEK8FjfOb/25rAD1mr4rwd+oRYoMPAxwH z6VWzv7M9armqICbQqIFo/TFl9xof4qBZzXGOdUaek59jwSB0vEZAy1GcB8cF7ufnxFk ISKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0ei/d/+sXN+4gF2wFzHQ+fXdxDl5esUiKnox/P27NkA=; b=cyxTpEQe2929t86TClsnpKD6p9e0+duEHuEYwE/uk7sBABCEfZUKVaSp9kQcXrYBJ2 o17XO6w8hNP8OTFzjBAzBz8Fv64vnefb+UfNrZoEnsZyLb1s1WrNCprbRRQrn1TIixhk 5Lh/L6Fq9BksLOvhWytpcs9i1NMsx172bjpgwTow/O5uIyNATFkUtNgzoKS1O2WNGm3A A+ecCEpZvjUyNcc8RarrTfHrnTt2eM1celB9pvbgW4zdz0lbvKS+w+PoWGDoyaHg8VGO WHrx7XpPm8rvHa174TWwjVsP/AwrTGCGFLT+Lcxkx67aInYlZXkC21oQSpnZ5IV0DXN6 7NMg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZeYJA6B2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x14-20020a63170e000000b0044bf9d57c38si37950169pgl.240.2022.10.24.06.11.57; Mon, 24 Oct 2022 06:12:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=ZeYJA6B2; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235589AbiJXNLh (ORCPT + 99 others); Mon, 24 Oct 2022 09:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235587AbiJXNJF (ORCPT ); Mon, 24 Oct 2022 09:09:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 715589F37D; Mon, 24 Oct 2022 05:22:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 34927612CA; Mon, 24 Oct 2022 12:22:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 439B0C433D6; Mon, 24 Oct 2022 12:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614129; bh=Ky/iogaQ9PRQQKPitP+pBUN4AJW3nr4mLiuxVnMARWw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZeYJA6B2+Pr0WykQNocQ7+UqC54tfxY08XWJAw2jvsOWuzAdEGKYuSEoVcPDlWUtI OaBLyf7SXy8ZOGFj+3I2xPvuJhbOFLuHr/+HDJ1TT8QbEolu0mvcUsBtwibtxhDNiw exQ4zp0/0Cit0kFMLiQzFF5JD4kuMhDpXuaYjwn8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Bitterblue Smith , Kalle Valo , Sasha Levin Subject: [PATCH 5.10 116/390] wifi: rtl8xxxu: gen2: Fix mistake in path B IQ calibration Date: Mon, 24 Oct 2022 13:28:33 +0200 Message-Id: <20221024113027.632131162@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747574724280860664?= X-GMAIL-MSGID: =?utf-8?q?1747574724280860664?= From: Bitterblue Smith [ Upstream commit e963a19c64ac0d2f8785d36a27391abd91ac77aa ] Found by comparing with the vendor driver. Currently this affects only the RTL8192EU, which is the only gen2 chip with 2 TX paths supported by this driver. It's unclear what kind of effect the mistake had in practice, since I don't have any RTL8192EU devices to test it. Fixes: e1547c535ede ("rtl8xxxu: First stab at adding IQK calibration for 8723bu parts") Signed-off-by: Bitterblue Smith Signed-off-by: Kalle Valo Link: https://lore.kernel.org/r/30a59f3a-cfa9-8379-7af0-78a8f4c77cfd@gmail.com Signed-off-by: Sasha Levin --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c index e8b4544b5b15..8668b03bd8c7 100644 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -2925,12 +2925,12 @@ bool rtl8xxxu_gen2_simularity_compare(struct rtl8xxxu_priv *priv, } if (!(simubitmap & 0x30) && priv->tx_paths > 1) { - /* path B RX OK */ + /* path B TX OK */ for (i = 4; i < 6; i++) result[3][i] = result[c1][i]; } - if (!(simubitmap & 0x30) && priv->tx_paths > 1) { + if (!(simubitmap & 0xc0) && priv->tx_paths > 1) { /* path B RX OK */ for (i = 6; i < 8; i++) result[3][i] = result[c1][i];