From patchwork Mon Oct 24 11:28:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9186 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp458449wru; Mon, 24 Oct 2022 06:37:36 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Sj9yB6/1gztC1KeHZ/nAck7KQSs8ZLOrIex6a/WxVnoIIyVYFv296QiZl5Bk0LzMGFti4 X-Received: by 2002:a05:6402:4446:b0:457:eebd:fe52 with SMTP id o6-20020a056402444600b00457eebdfe52mr30463958edb.234.1666618655944; Mon, 24 Oct 2022 06:37:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666618655; cv=none; d=google.com; s=arc-20160816; b=QbaUyEGrEQQwxvTbOizELbnbhYVbEABm0iQPkCXmaHf1P9eSi5f1A1vARD59msajeF RtpC7KpWjXnw++kcu0+C8i8vIhgQZRuNVFL9W6EOEt+/ZzFynI4GGRU9mUASLDybmQsd D5It198Hjwm1Lk3DLUsisekZfUNvgl1hrWL2ZAkRv9cXX52ovT4+cxx+NUbiJA1qYUiy twZ4SgSvMvjz462PaEaf1K9Br+4vCR43zp7e9Bq7xth2TSROMOLft7rbeElGKyKKq8SC ULXXkZeTkTI6fmKc0NX2ElkHl//RSaKCEZx6BnQh5qddUB07ggF8vmTVFzhQVAvyCnk3 7vkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=RDvm04YhO3Iz0Ztma9S3rSoo4sdkGW5mWpMUwAAZtP8=; b=xZCMqW6sGnXwDGsom3f9I78iGK+xqQa6ReHyB2soXiFsLYgzHK2CbO2t8R3YS6Hzat 5i6DDZazynu500o5X43u8CS2fykttypyxQgTMi2uq1OyhEuAFwHdMu7xtT9p0wYkwZvG JQiUP0ACzaZHZajJAJ91A8NduUqPJGK+r/gWQuMHAFN4vkWR5NfYhluN5+xdOUJPD3KS M7U4fnAaXrulN6fsXNe/I18eiTvi88VH/TyjVZjocPuhkyN/muzRufSlPLWHWOIwBedy ftlHyQxVVtm3n26+GnNe5glscN9Tnulkqr4QDVRB00wawYnCOFEW6gUfYQ4vWpIezozV xHeQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nJRbICKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020a056402274200b0045cf3f51a34si32814344edd.24.2022.10.24.06.37.03; Mon, 24 Oct 2022 06:37:35 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=nJRbICKp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232706AbiJXNcG (ORCPT + 99 others); Mon, 24 Oct 2022 09:32:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235949AbiJXN3K (ORCPT ); Mon, 24 Oct 2022 09:29:10 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0CC81ABD55; Mon, 24 Oct 2022 05:32:15 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0715E6129B; Mon, 24 Oct 2022 12:20:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 183B8C433C1; Mon, 24 Oct 2022 12:20:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666614058; bh=ttjB1SlCZ5M3JOhhGTJWbx96VkemfaVc5WhLA3e0RMk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=nJRbICKpaqXHFfMgtK8ztBBAXnFK9yA6v7v9GXlf+FpZlWWUSZOIN2zb0CEDqUJbW LfhohFWDKSe+WBpnQRies87+kT5X4706ivh+keX8eA68DwWPwkGYuwDJCsdzwNJVoM PPtGc/bSq+YluHjvmrftABwGYZWyqq/9IJPbuEgw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Lyude Paul , Karol Herbst Subject: [PATCH 5.10 086/390] drm/nouveau/kms/nv140-: Disable interlacing Date: Mon, 24 Oct 2022 13:28:03 +0200 Message-Id: <20221024113026.275222128@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747576323621086637?= X-GMAIL-MSGID: =?utf-8?q?1747576323621086637?= From: Lyude Paul commit 8ba9249396bef37cb68be9e8dee7847f1737db9d upstream. As it turns out: while Nvidia does actually have interlacing knobs on their GPU still pretty much no current GPUs since Volta actually support it. Trying interlacing on these GPUs will result in NVDisplay being quite unhappy like so: nouveau 0000:1f:00.0: disp: chid 0 stat 00004802 reason 4 [INVALID_ARG] mthd 2008 data 00000001 code 00080000 nouveau 0000:1f:00.0: disp: chid 0 stat 10005080 reason 5 [INVALID_STATE] mthd 0200 data 00000001 code 00000001 So let's fix this by following the same behavior Nvidia's driver does and disable interlacing entirely. Signed-off-by: Lyude Paul Cc: stable@vger.kernel.org Reviewed-by: Karol Herbst Link: https://patchwork.freedesktop.org/patch/msgid/20220816180436.156310-1-lyude@redhat.com Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/nouveau/nouveau_connector.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/nouveau/nouveau_connector.c +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c @@ -500,7 +500,8 @@ nouveau_connector_set_encoder(struct drm connector->interlace_allowed = nv_encoder->caps.dp_interlace; else - connector->interlace_allowed = true; + connector->interlace_allowed = + drm->client.device.info.family < NV_DEVICE_INFO_V0_VOLTA; connector->doublescan_allowed = true; } else if (nv_encoder->dcb->type == DCB_OUTPUT_LVDS ||