From patchwork Mon Oct 24 11:27:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 9702 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp544574wru; Mon, 24 Oct 2022 09:32:24 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7GNwjDYbDKEEqfit59lLIts/Hts/cEgKqxkgtHtJRuflP7COrAYQAkuWyL99ORhL2cYQ8X X-Received: by 2002:a17:907:984:b0:77f:4d95:9e2f with SMTP id bf4-20020a170907098400b0077f4d959e2fmr29228583ejc.176.1666629144002; Mon, 24 Oct 2022 09:32:24 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666629143; cv=none; d=google.com; s=arc-20160816; b=OC/czlwSx0FfcgqUQrK1cXJAUypIOyC3Xfej4K7gSpJ+5lSyQbNA3LWU5lQSBSEnZK xyz3ZR4WtMi8IhvlERlfFA8hozrWrTU7ue4InP2Mf0GbUNcR09CKLfXLgCw8lsiJlyeU AwP/JEJoHeOynTFVIiRuhf0mFEh4usGuStRJaKzVWQmk1a2ez4HMPZNrDTIfQOL9iUIr W2kcksPeIRGpacSG3NidU5OSYgI5VPFKsC+XGP5U7uWIPE5JlHb4uhUkIGOHvrG0i955 W3DvxOb36aMZXAaZIySjbD2xcOXgAikyRqWRVn0fxQtco333IXegvEtyJykaPGy8ItrI oi1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=untL2wP4029fh2STWPV+ZONKPlOGBnjIIb6/zYRySLI=; b=QLi2X4Jw2iYJKtI1CDddiz/20XWYos2v/scE2nVWDhrFUmcICyyV75ukI4WJrsIoM7 dA1SIFPxVgmc27DZdhyjX/LEPNB7FGhBeHjwFdgkUxHhO50ENClIfMrVc/+UO+2L50PK nEmL+rF4LylFIjYTXfvjvPw7jiUgjVSOAQhkk0WM9xDk7tQsxdKB9BLMwhv4GYpsOvqS fuj5XoUKYOCT+pUz4gaTNXJhThxxfTAOIKAt8Hfav+tvt+gQXzI9ZX7tjZBQpFIXICy6 rAUWdfj32uJXwTm79RmkkZjI+OYQimtmqiHSamz8ZEPSBf2zy+6VGLDyNa3Nw3NboSae 9AVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JSFNgbNE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hq28-20020a1709073f1c00b0078db137967dsi204813ejc.566.2022.10.24.09.32.00; Mon, 24 Oct 2022 09:32:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=JSFNgbNE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232632AbiJXQRi (ORCPT + 99 others); Mon, 24 Oct 2022 12:17:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235067AbiJXQPo (ORCPT ); Mon, 24 Oct 2022 12:15:44 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1CA7F52E4B; Mon, 24 Oct 2022 08:03:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id CCC89B815C2; Mon, 24 Oct 2022 12:18:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D5B6C433C1; Mon, 24 Oct 2022 12:18:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1666613913; bh=cDE7mdxA2GnHKcv/HGZn7QWb8vlWewY71vte2eP/0v4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JSFNgbNEeH9lVQTLjudiEZBbYoWQm/LSgcUs268UKfS0GM2vS60VbIfuPDjHrFohm dto+FQSAIT0QGkQADW2gMXnNRxpVkKXgAFQ1uQZKQY90Q7zM6nJoCWxDgRG0VlQoWh JFBcZHZG3NJYzC4sWSEzUEnROYfkfbT2cV8Sxs50= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, stable@kernel.org, Lalith Rajendran , Theodore Tso Subject: [PATCH 5.10 062/390] ext4: make ext4_lazyinit_thread freezable Date: Mon, 24 Oct 2022 13:27:39 +0200 Message-Id: <20221024113025.269897167@linuxfoundation.org> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221024113022.510008560@linuxfoundation.org> References: <20221024113022.510008560@linuxfoundation.org> User-Agent: quilt/0.67 MIME-Version: 1.0 X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747587320888124239?= X-GMAIL-MSGID: =?utf-8?q?1747587320888124239?= From: Lalith Rajendran commit 3b575495ab8dbb4dbe85b4ac7f991693c3668ff5 upstream. ext4_lazyinit_thread is not set freezable. Hence when the thread calls try_to_freeze it doesn't freeze during suspend and continues to send requests to the storage during suspend, resulting in suspend failures. Cc: stable@kernel.org Signed-off-by: Lalith Rajendran Link: https://lore.kernel.org/r/20220818214049.1519544-1-lalithkraj@google.com Signed-off-by: Theodore Ts'o Signed-off-by: Greg Kroah-Hartman --- fs/ext4/super.c | 1 + 1 file changed, 1 insertion(+) --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3550,6 +3550,7 @@ static int ext4_lazyinit_thread(void *ar unsigned long next_wakeup, cur; BUG_ON(NULL == eli); + set_freezable(); cont_thread: while (true) {